Patchworkβ [oe] mc 4.6.2: fix do_configure error on missing config.rpath

login
register
about
Submitter Petr Štetiar
Date 2010-02-08 19:50:12
Message ID <1265658612-19262-1-git-send-email-ynezz@true.cz>
Download mbox | patch
Permalink /patch/1548/
State New
Headers show

Comments

Petr Štetiar - 2010-02-08 19:50:12
This patch fixes configure error, complaining about missing config.rpath file
which gets deleted by autofoo in recipe, so to avoid error bellow we create
empty file, making configure happy.

configure.ac:104: required file `config/config.rpath' not found
[...snip...]
autoreconf: automake failed with exit status: 1
FATAL: autoreconf execution failed.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 recipes/mc/mc_4.6.2.bb |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Jens Seidel - 2010-02-09 08:44:42
On Mon, Feb 08, 2010 at 08:50:12PM +0100, Petr Štetiar wrote:
> This patch fixes configure error, complaining about missing config.rpath file
> which gets deleted by autofoo in recipe, so to avoid error bellow we create
> empty file, making configure happy.
 
> configure.ac:104: required file `config/config.rpath' not found
> [...snip...]
> autoreconf: automake failed with exit status: 1
> FATAL: autoreconf execution failed.

> @@ -86,4 +86,6 @@ AUTOFOO="config.guess config.rpath config.sub depcomp install-sh missing mkinsta
>           for i in ${AUTOFOO}; do
>             rm config/${i}
>           done
> +         # raises error if it's not found
> +         touch config/config.rpath
>  }

Mhm, and you know that this patch is right? If config.rpath is called it is
expected that it sets a few variables such as shlibext (normally to "so"),
libext ("a") but this does not happen with an empty config.rpath. This patch
may indeed fix the current error but what about support for all platforms?
I would ship a proper file instead of a faked one and I mentioned that e.g.
autopoint creates this file ...

Jens

Patch

diff --git a/recipes/mc/mc_4.6.2.bb b/recipes/mc/mc_4.6.2.bb
index 387187d..3eb6bf3 100644
--- a/recipes/mc/mc_4.6.2.bb
+++ b/recipes/mc/mc_4.6.2.bb
@@ -1,5 +1,5 @@ 
 require mc.inc
-PR = "r4"
+PR = "r5"
 HOMEPAGE = "http://www.midnight-commander.org/"
 
 # most of these fixes were copied from openSUSE Factory.
@@ -86,4 +86,6 @@  AUTOFOO="config.guess config.rpath config.sub depcomp install-sh missing mkinsta
          for i in ${AUTOFOO}; do
            rm config/${i}
          done
+         # raises error if it's not found
+         touch config/config.rpath
 }