Patchwork ghostscript-native: Ensure the sys/time/h fix is applied for native builds

login
register
mail settings
Submitter Richard Purdie
Date Nov. 25, 2011, 3:06 p.m.
Message ID <1322233577.22654.0.camel@ted>
Download mbox | patch
Permalink /patch/15431/
State Accepted
Commit 67176378266767cd0cca4f8ecafa865907ca4bdd
Headers show

Comments

Richard Purdie - Nov. 25, 2011, 3:06 p.m.
On my system, the sys/time.h header is in a subdir off /usr/include
which causes a build failure. Apply the target CFLAGS fix to native
builds as well to address this.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Khem Raj - Nov. 26, 2011, 2:39 a.m.
On Fri, Nov 25, 2011 at 7:06 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On my system, the sys/time.h header is in a subdir off /usr/include
> which causes a build failure. Apply the target CFLAGS fix to native
> builds as well to address this.

hmmm I thought CFLAGS would be automtically translated with
BBCLASSEXTEND = "native"

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/recipes-extended/ghostscript/ghostscript_9.04.bb b/meta/recipes-extended/ghostscript/ghostscript_9.04.bb
> index d444810..86d5ef2 100644
> --- a/meta/recipes-extended/ghostscript/ghostscript_9.04.bb
> +++ b/meta/recipes-extended/ghostscript/ghostscript_9.04.bb
> @@ -40,6 +40,7 @@ EXTRA_OECONF = "--without-x --with-system-libtiff --without-jbig2dec --without-j
>  # http://bugs.ghostscript.com/show_bug.cgi?id=692443
>  # http://bugs.ghostscript.com/show_bug.cgi?id=692426
>  CFLAGS += "-DHAVE_SYS_TIME_H=1"
> +BUILD_CFLAGS += "-DHAVE_SYS_TIME_H=1"
>
>  inherit autotools
>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - Nov. 26, 2011, 10:16 a.m.
On Fri, 2011-11-25 at 18:39 -0800, Khem Raj wrote:
> On Fri, Nov 25, 2011 at 7:06 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On my system, the sys/time.h header is in a subdir off /usr/include
> > which causes a build failure. Apply the target CFLAGS fix to native
> > builds as well to address this.
> 
> hmmm I thought CFLAGS would be automtically translated with
> BBCLASSEXTEND = "native"

For native recipes, CFLAGS is replaced by BUILD_CFLAGS...

Cheers,

Richard
Khem Raj - Nov. 26, 2011, 9:50 p.m.
On Sat, Nov 26, 2011 at 2:16 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2011-11-25 at 18:39 -0800, Khem Raj wrote:
>> On Fri, Nov 25, 2011 at 7:06 AM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>> > On my system, the sys/time.h header is in a subdir off /usr/include
>> > which causes a build failure. Apply the target CFLAGS fix to native
>> > builds as well to address this.
>>
>> hmmm I thought CFLAGS would be automtically translated with
>> BBCLASSEXTEND = "native"
>
> For native recipes, CFLAGS is replaced by BUILD_CFLAGS...

yes I see. A little niggle I was thinking of is that at present for a
target recipe if something gets changed in CFLAGS or TARGET_CFLAGS
that makes to the compile phase as combined CFLAGS

for native we rewrite CFLAGS = BUILD_CFLAGS

So either CFLAGS += BUILD_FLAGS for native CFLAGS += TARGET_CFLAGS
will make it consistent or just override CFLAGS with BUILD_CFLAGS or
TARGET_CFLAGS depending on recipe type



>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - Nov. 27, 2011, 11:38 a.m.
On Sat, 2011-11-26 at 13:50 -0800, Khem Raj wrote:
> On Sat, Nov 26, 2011 at 2:16 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2011-11-25 at 18:39 -0800, Khem Raj wrote:
> >> On Fri, Nov 25, 2011 at 7:06 AM, Richard Purdie
> >> <richard.purdie@linuxfoundation.org> wrote:
> >> > On my system, the sys/time.h header is in a subdir off /usr/include
> >> > which causes a build failure. Apply the target CFLAGS fix to native
> >> > builds as well to address this.
> >>
> >> hmmm I thought CFLAGS would be automtically translated with
> >> BBCLASSEXTEND = "native"
> >
> > For native recipes, CFLAGS is replaced by BUILD_CFLAGS...
> 
> yes I see. A little niggle I was thinking of is that at present for a
> target recipe if something gets changed in CFLAGS or TARGET_CFLAGS
> that makes to the compile phase as combined CFLAGS
> 
> for native we rewrite CFLAGS = BUILD_CFLAGS
> 
> So either CFLAGS += BUILD_FLAGS for native CFLAGS += TARGET_CFLAGS
> will make it consistent or just override CFLAGS with BUILD_CFLAGS or
> TARGET_CFLAGS depending on recipe type

We could do with looking into addressing this inconsistency, yes.

Cheers,

Richard

Patch

diff --git a/meta/recipes-extended/ghostscript/ghostscript_9.04.bb b/meta/recipes-extended/ghostscript/ghostscript_9.04.bb
index d444810..86d5ef2 100644
--- a/meta/recipes-extended/ghostscript/ghostscript_9.04.bb
+++ b/meta/recipes-extended/ghostscript/ghostscript_9.04.bb
@@ -40,6 +40,7 @@  EXTRA_OECONF = "--without-x --with-system-libtiff --without-jbig2dec --without-j
 # http://bugs.ghostscript.com/show_bug.cgi?id=692443
 # http://bugs.ghostscript.com/show_bug.cgi?id=692426
 CFLAGS += "-DHAVE_SYS_TIME_H=1"
+BUILD_CFLAGS += "-DHAVE_SYS_TIME_H=1"
 
 inherit autotools