Patchwork bitbake.conf: Set BB_CONSOLELOG so we log console messages by default

login
register
mail settings
Submitter Richard Purdie
Date Nov. 24, 2011, 2:58 p.m.
Message ID <1322146689.10818.1.camel@ted>
Download mbox | patch
Permalink /patch/15413/
State Accepted
Commit 4b916ce59bf88ca92b034b2acaddee6130155e46
Headers show

Comments

Richard Purdie - Nov. 24, 2011, 2:58 p.m.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Darren Hart - Nov. 24, 2011, 4:13 p.m.
I believe this is the fix for Yocto Bug 1771? If so, awesome! A one
liner, something to be said for really knowing the codebase.

I would only suggest a commit log which includes the bug line,
motivation and the approach taken, per the contribution guidelines.
Maybe something like:

"""""
Fixes [YOCTO #1771]

The console log is often helpful for debugging issues. Difficult to
reproduce bugs would benefit from a log being generated by default as it
may be difficult to come by after the fact. Log to
tmp/cooker.log.${DATETIME} by default.
"""""

Thanks,

Darren


On 11/24/2011 06:58 AM, Richard Purdie wrote:
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 01f064c..4589909 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -732,6 +732,8 @@ DISTRO[unexport] = "1"
>  # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
>  TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
>  
> +BB_CONSOLELOG = "${TMPDIR}/cooker.log.${DATETIME}"
> +
>  # Setup our default hash policy
>  BB_SIGNATURE_HANDLER ?= "basic"
>  BB_HASHTASK_WHITELIST ?= "(.*-cross$|.*-native$|.*-cross-initial$|.*-cross-intermediate$|^virtual:native:.*|^virtual:nativesdk:.*)"
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - Nov. 24, 2011, 4:22 p.m.
On Thu, 2011-11-24 at 08:13 -0800, Darren Hart wrote:
> I believe this is the fix for Yocto Bug 1771? If so, awesome! A one
> liner, something to be said for really knowing the codebase.

It has a dependent on a ~5 line change to bitbake over on bitbake-devel
but yes, it fixes 1771.

> I would only suggest a commit log which includes the bug line,
> motivation and the approach taken, per the contribution guidelines.
> Maybe something like:
> 
> """""
> Fixes [YOCTO #1771]
> 
> The console log is often helpful for debugging issues. Difficult to
> reproduce bugs would benefit from a log being generated by default as it
> may be difficult to come by after the fact. Log to
> tmp/cooker.log.${DATETIME} by default.
> """""

FWIW most of the commit message is over on bitbake-devel but I should
have referenced the bug number, yes.

Cheers,

Richard

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 01f064c..4589909 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -732,6 +732,8 @@  DISTRO[unexport] = "1"
 # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed
 TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}"
 
+BB_CONSOLELOG = "${TMPDIR}/cooker.log.${DATETIME}"
+
 # Setup our default hash policy
 BB_SIGNATURE_HANDLER ?= "basic"
 BB_HASHTASK_WHITELIST ?= "(.*-cross$|.*-native$|.*-cross-initial$|.*-cross-intermediate$|^virtual:native:.*|^virtual:nativesdk:.*)"