Patchwork [meta-handheld,4/6] linux-kexecboot: don't disable DEBUG, PRINTK, BUG with CMDLINE_DEBUG not just loglevel=3

login
register
mail settings
Submitter Martin Jansa
Date Nov. 24, 2011, 10:18 a.m.
Message ID <19b573f112f191ea9dd166e3be7edc8310725198.1322129758.git.Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/15401/
State Superseded
Headers show

Comments

Martin Jansa - Nov. 24, 2011, 10:18 a.m.
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-kernel/linux/linux-kexecboot.inc |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)
Andrea Adami - Nov. 24, 2011, 11:01 a.m.
On Thu, Nov 24, 2011 at 11:18 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  recipes-kernel/linux/linux-kexecboot.inc |   14 +++++++++++---
>  1 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/recipes-kernel/linux/linux-kexecboot.inc b/recipes-kernel/linux/linux-kexecboot.inc
> index 83b7018..220bf36 100644
> --- a/recipes-kernel/linux/linux-kexecboot.inc
> +++ b/recipes-kernel/linux/linux-kexecboot.inc
> @@ -108,9 +108,17 @@ do_configure_prepend() {
>         kernel_conf_variable KEXEC y
>         CONF_SED_SCRIPT="$CONF_SED_SCRIPT /=m/d;"
>         kernel_conf_variable MODULES n
> -        kernel_conf_variable DEBUG_ERRORS n
> -        kernel_conf_variable DEBUG_BUGVERBOSE n
> -        kernel_conf_variable DEBUG_KERNEL n
> +        if [ "${CMDLINE_DEBUG}" = "loglevel=3" ] ; then
> +                kernel_conf_variable DEBUG_ERRORS n
> +                kernel_conf_variable DEBUG_BUGVERBOSE n
> +                kernel_conf_variable DEBUG_KERNEL n
> +       else
> +                kernel_conf_variable PRINTK y
> +                kernel_conf_variable BUG y
> +                kernel_conf_variable DEBUG_ERRORS y
> +                kernel_conf_variable DEBUG_BUGVERBOSE y
> +                kernel_conf_variable DEBUG_KERNEL y
> +       fi
>
>         # Force lzma for arm kernels only
>         if [ "${ARCH}" = "arm" ] ; then
> --
> 1.7.8.rc3
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

The idea is good!
The weak point is EXTRA_IMAGE_FEATURES = "debug-tweaks" , default in local.conf.

Remember for collie we have to watch the kernel size! I'm not sure we
respect the limit, probably yes.
No problem on other Zaurus, unless we want to renable networking and usb.

Regards

Andrea
Andrea Adami - Nov. 24, 2011, 12:38 p.m.
On Thu, Nov 24, 2011 at 12:01 PM, Andrea Adami <andrea.adami@gmail.com> wrote:
> On Thu, Nov 24, 2011 at 11:18 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> ---
>>  recipes-kernel/linux/linux-kexecboot.inc |   14 +++++++++++---
>>  1 files changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/recipes-kernel/linux/linux-kexecboot.inc b/recipes-kernel/linux/linux-kexecboot.inc
>> index 83b7018..220bf36 100644
>> --- a/recipes-kernel/linux/linux-kexecboot.inc
>> +++ b/recipes-kernel/linux/linux-kexecboot.inc
>> @@ -108,9 +108,17 @@ do_configure_prepend() {
>>         kernel_conf_variable KEXEC y
>>         CONF_SED_SCRIPT="$CONF_SED_SCRIPT /=m/d;"
>>         kernel_conf_variable MODULES n
>> -        kernel_conf_variable DEBUG_ERRORS n
>> -        kernel_conf_variable DEBUG_BUGVERBOSE n
>> -        kernel_conf_variable DEBUG_KERNEL n
>> +        if [ "${CMDLINE_DEBUG}" = "loglevel=3" ] ; then
>> +                kernel_conf_variable DEBUG_ERRORS n
>> +                kernel_conf_variable DEBUG_BUGVERBOSE n
>> +                kernel_conf_variable DEBUG_KERNEL n
>> +       else
>> +                kernel_conf_variable PRINTK y
>> +                kernel_conf_variable BUG y
>> +                kernel_conf_variable DEBUG_ERRORS y
>> +                kernel_conf_variable DEBUG_BUGVERBOSE y
>> +                kernel_conf_variable DEBUG_KERNEL y
>> +       fi
>>
>>         # Force lzma for arm kernels only
>>         if [ "${ARCH}" = "arm" ] ; then
>> --
>> 1.7.8.rc3
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> The idea is good!
> The weak point is EXTRA_IMAGE_FEATURES = "debug-tweaks" , default in local.conf.

Hm.. and what about using  "tools-debug" instead?

Andrea


>
> Remember for collie we have to watch the kernel size! I'm not sure we
> respect the limit, probably yes.
> No problem on other Zaurus, unless we want to renable networking and usb.
>
> Regards
>
> Andrea
>
Paul Eggleton - Nov. 24, 2011, 12:42 p.m.
On Thursday 24 November 2011 13:38:53 Andrea Adami wrote:
> On Thu, Nov 24, 2011 at 12:01 PM, Andrea Adami <andrea.adami@gmail.com>
> wrote:
> > The weak point is EXTRA_IMAGE_FEATURES = "debug-tweaks" , default in
> > local.conf.
> Hm.. and what about using  "tools-debug" instead?

I realise we've already done it here and elsewhere (e.g. dropbear) but I'm not 
hugely keen on configuration of individual recipes being dependent on 
IMAGE_FEATURES - it's not supposed to be allowed AFAIK.

Cheers,
Paul
Martin Jansa - Nov. 24, 2011, 12:46 p.m.
On Thu, Nov 24, 2011 at 12:42:56PM +0000, Paul Eggleton wrote:
> On Thursday 24 November 2011 13:38:53 Andrea Adami wrote:
> > On Thu, Nov 24, 2011 at 12:01 PM, Andrea Adami <andrea.adami@gmail.com>
> > wrote:
> > > The weak point is EXTRA_IMAGE_FEATURES = "debug-tweaks" , default in
> > > local.conf.
> > Hm.. and what about using  "tools-debug" instead?
> 
> I realise we've already done it here and elsewhere (e.g. dropbear) but I'm not 
> hugely keen on configuration of individual recipes being dependent on 
> IMAGE_FEATURES - it's not supposed to be allowed AFAIK.

I'm fine with keeping default CMDLINE_DEBUG set to just loglevel=3 and
debug can be set from local.conf or linux-git.inc if needed.

Cheers,
Andrea Adami - Nov. 24, 2011, 12:56 p.m.
On Thu, Nov 24, 2011 at 1:42 PM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Thursday 24 November 2011 13:38:53 Andrea Adami wrote:
>> On Thu, Nov 24, 2011 at 12:01 PM, Andrea Adami <andrea.adami@gmail.com>
>> wrote:
>> > The weak point is EXTRA_IMAGE_FEATURES = "debug-tweaks" , default in
>> > local.conf.
>> Hm.. and what about using  "tools-debug" instead?
>
> I realise we've already done it here and elsewhere (e.g. dropbear) but I'm not
> hugely keen on configuration of individual recipes being dependent on
> IMAGE_FEATURES - it's not supposed to be allowed AFAIK.
>

Well, in fact you are right and I rememebr your initial perplexity.

Oe-classic had CMDLINE_DEBUG ?= '${@base_conditional("DISTRO_TYPE",
"release", "loglevel=3", "debug", d)}'
but now DISTRO_TYPE has gone (not in grep results).


Andrea



> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/recipes-kernel/linux/linux-kexecboot.inc b/recipes-kernel/linux/linux-kexecboot.inc
index 83b7018..220bf36 100644
--- a/recipes-kernel/linux/linux-kexecboot.inc
+++ b/recipes-kernel/linux/linux-kexecboot.inc
@@ -108,9 +108,17 @@  do_configure_prepend() {
         kernel_conf_variable KEXEC y
         CONF_SED_SCRIPT="$CONF_SED_SCRIPT /=m/d;"
         kernel_conf_variable MODULES n
-        kernel_conf_variable DEBUG_ERRORS n
-        kernel_conf_variable DEBUG_BUGVERBOSE n
-        kernel_conf_variable DEBUG_KERNEL n
+        if [ "${CMDLINE_DEBUG}" = "loglevel=3" ] ; then
+                kernel_conf_variable DEBUG_ERRORS n
+                kernel_conf_variable DEBUG_BUGVERBOSE n
+                kernel_conf_variable DEBUG_KERNEL n
+	else
+                kernel_conf_variable PRINTK y
+                kernel_conf_variable BUG y
+                kernel_conf_variable DEBUG_ERRORS y
+                kernel_conf_variable DEBUG_BUGVERBOSE y
+                kernel_conf_variable DEBUG_KERNEL y
+	fi
 
         # Force lzma for arm kernels only
         if [ "${ARCH}" = "arm" ] ; then