Patchworkβ [oe] building piccontrol - 0.4 failed due to lack of liblua5.1.a

login
register
about
Submitter Guo Hongruan
Date 2010-01-31 05:56:58
Message ID <op.u7dus8qwmn1qzu@camelguo>
Download mbox | patch
Permalink /patch/1535/
State Superseded
Headers show

Comments

Guo Hongruan - 2010-01-31 05:56:58
在 Sun, 31 Jan 2010 13:44:33 +0800，Guo Hongruan <camelguo@gmail.com> 写道:

> 在 Sun, 31 Jan 2010 13:22:16 +0800，Khem Raj <raj.khem@gmail.com> 写道:
>
>> in your build tree check where liblua5.1.a is installed and then
>> go from there.
>
> instead of liblue5.1.a, I found libua.a on my build tree. Maybe it is  
> the cause of the error.
>
> ./armv5te-oe-linux-gnueabi/lib/liblua.a
>

I found it, it is caused by
1. lua5.1_5.1.4.bb install lib/liblua. to staging directory;
2. but piccoontrol_0.4.bb tries to link liblua5.1.a, which name is  
liblua.a.
    20 LDFLAGS += " ${STAGING_LIBDIR}/liblua5.1.a -lpthread -lm -ldl "

changing piccontrol_0.4.bb may correct the error.
Holger Freyther - 2010-01-31 06:14:09
On Sunday 31 January 2010 06:56:58 Guo Hongruan wrote:
> 在 Sun, 31 Jan 2010 13:44:33 +0800，Guo Hongruan <camelguo@gmail.com> 写道:

>     20 LDFLAGS += " ${STAGING_LIBDIR}/liblua5.1.a -lpthread -lm -ldl "

Okay,
care to write a patch with a proper commit message and a Signed-off-by line?

PS: In the long run the lua recipe should install the .pc and we should link 
with pkg-config --libs lua5.1
Guo Hongruan - 2010-01-31 06:22:03
OK, no problem

在 Sun, 31 Jan 2010 14:14:09 +0800，Holger Hans Peter Freyther  
<holger+oe@freyther.de> 写道:

> On Sunday 31 January 2010 06:56:58 Guo Hongruan wrote:
>> 在 Sun, 31 Jan 2010 13:44:33 +0800，Guo Hongruan <camelguo@gmail.com>  
>> 写道:
>
>>     20 LDFLAGS += " ${STAGING_LIBDIR}/liblua5.1.a -lpthread -lm -ldl "
>
> Okay,
> care to write a patch with a proper commit message and a Signed-off-by  
> line?
>
> PS: In the long run the lua recipe should install the .pc and we should  
> link
> with pkg-config --libs lua5.1
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Petr Štetiar - 2010-01-31 09:34:49
Guo Hongruan <camelguo@gmail.com> [2010-01-31 13:56:58]:

> 2. but piccoontrol_0.4.bb tries to link liblua5.1.a, which name is  
> liblua.a.
>    20 LDFLAGS += " ${STAGING_LIBDIR}/liblua5.1.a -lpthread -lm -ldl "
>
> changing piccontrol_0.4.bb may correct the error.

I think, that correct way of fixing it would be to fix Lua recipe to install
as liblua5.1.a. Maybe creating pkgconfig for Lua would help also.

-- ynezz
Tim Ellis - 2010-01-31 16:53:27
From memory this needed a specific (or minimum) version of lua. Byron may also have an updated version we can test and commit. Sorry all my stuff is packed up at the mo and I can't test!  (Sorry for the extra email Byron the other bounced!)

Tim

On 31 Jan 2010, at 09:34, Petr Štetiar wrote:

> Guo Hongruan <camelguo@gmail.com> [2010-01-31 13:56:58]:
> 
>> 2. but piccoontrol_0.4.bb tries to link liblua5.1.a, which name is  
>> liblua.a.
>>   20 LDFLAGS += " ${STAGING_LIBDIR}/liblua5.1.a -lpthread -lm -ldl "
>> 
>> changing piccontrol_0.4.bb may correct the error.
> 
> I think, that correct way of fixing it would be to fix Lua recipe to install
> as liblua5.1.a. Maybe creating pkgconfig for Lua would help also.
> 
> -- ynezz
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Stefan Schmidt - 2010-03-28 11:56:47
Hello.

On Sun, 2010-01-31 at 07:14, Holger Hans Peter Freyther wrote:
> On Sunday 31 January 2010 06:56:58 Guo Hongruan wrote:
> > 在 Sun, 31 Jan 2010 13:44:33 +0800，Guo Hongruan <camelguo@gmail.com> 写道:
> 
> >     20 LDFLAGS += " ${STAGING_LIBDIR}/liblua5.1.a -lpthread -lm -ldl "
> 
> Okay,
> care to write a patch with a proper commit message and a Signed-off-by line?

That never happened. As the subject line was not fitting, it did no longer apply
and a SOB was missing I redid the one-line change as a band-aid.

> PS: In the long run the lua recipe should install the .pc and we should link 
> with pkg-config --libs lua5.1

Gua, are you interested in working this out?

regards
Stefan Schmidt

Patch

diff --git a/recipes/piccontrol/piccontrol_0.4.bb  
b/recipes/piccontrol/piccontrol_0.4.bb
index cfdef98..854f156 100644
--- a/recipes/piccontrol/piccontrol_0.4.bb
+++ b/recipes/piccontrol/piccontrol_0.4.bb
@@ -17,7 +17,7 @@  inherit update-rc.d
  INITSCRIPT_NAME = "piccontrol"
  INITSCRIPT_PARAMS = "defaults"

-LDFLAGS        += " ${STAGING_LIBDIR}/liblua5.1.a -lpthread -lm -ldl "
+LDFLAGS        += " ${STAGING_LIBDIR}/liblua.a -lpthread -lm -ldl "
  CFLAGS += " -I${STAGING_INCDIR}/lua5.1 "

  do_install() {