| Submitter | Michael Lippautz |
|---|---|
| Date | 2010-01-29 10:07:56 |
| Message ID | <1264759676-23841-1-git-send-email-michael.lippautz@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/1532/ |
| State | Rejected, archived |
| Headers | show |
Comments
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 29-01-10 11:07, Michael Lippautz wrote: > --- > recipes/perl/libdbd-sqlite-perl_1.29.bb | 29 +++++++++++++++++++++++++++++ > 1 files changed, 29 insertions(+), 0 deletions(-) > create mode 100644 recipes/perl/libdbd-sqlite-perl_1.29.bb > > diff --git a/recipes/perl/libdbd-sqlite-perl_1.29.bb b/recipes/perl/libdbd-sqlite-perl_1.29.bb > new file mode 100644 > index 0000000..10fe73a > --- /dev/null > +++ b/recipes/perl/libdbd-sqlite-perl_1.29.bb > @@ -0,0 +1,29 @@ > +DESCRIPTION = "PERL database interface driver for the SQLite database." > +SECTION = "libs" > +LICENSE = "Artistic|GPL" > +DEPENDS = "libdbi-perl-native" > +RDEPENDS = "libdbi-perl \ That should be RDEPENDS_${PN} We did have a script somewhere to check for things like that, does anyone know where that went? And can someone more knowledgable about perl than me push these patches (after fixups)? regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFLYrgTMkyGM64RGpERAnOEAJ0cVpWnavLn9ssl3Q6wKYXcPO2W1wCeKGwC +s4lBh3sMT+RMl7dUgQrplo= =BZHR -----END PGP SIGNATURE-----
On Friday 29 January 2010 11:07:56 Michael Lippautz wrote: > +DESCRIPTION = "PERL database interface driver for the SQLite database." > +SECTION = "libs" > +LICENSE = "Artistic|GPL" Use a space here, we do not have a good way to indicate dual licensing. > +DEPENDS = "libdbi-perl-native" > +BBCLASSEXTEND = "native" I'm not sure about these two.
Am Freitag, den 29.01.2010, 11:28 +0100 schrieb Holger Hans Peter Freyther: > On Friday 29 January 2010 11:07:56 Michael Lippautz wrote: > > > +DESCRIPTION = "PERL database interface driver for the SQLite database." > > +SECTION = "libs" > > +LICENSE = "Artistic|GPL" > > Use a space here, we do not have a good way to indicate dual licensing. Ok, just looked how existing recipes indicated dual licensing (dbd-mysql-perl). > > > > +DEPENDS = "libdbi-perl-native" > > +BBCLASSEXTEND = "native" > > I'm not sure about these two. 1) Perl module needs libdbi-perl natively installed to pass a configure check. 2) Maybe someone needs a native version of this, so I just added the native extension? Regards, Michael
2010/1/29 Koen Kooi <k.kooi@student.utwente.nl>: > > That should be RDEPENDS_${PN} > > We did have a script somewhere to check for things like that, does > anyone know where that went? > And can someone more knowledgable about perl than me push these patches > (after fixups)? Just looked up the deps at CPAN and added them. Additionally some core modules were needed that were not mentioned by CPAN (locale.pm), so manually added them to the list.
On Fri, Jan 29, 2010 at 3:27 AM, Koen Kooi <k.kooi@student.utwente.nl>wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 29-01-10 11:07, Michael Lippautz wrote: > > --- > > recipes/perl/libdbd-sqlite-perl_1.29.bb | 29 > +++++++++++++++++++++++++++++ > > 1 files changed, 29 insertions(+), 0 deletions(-) > > create mode 100644 recipes/perl/libdbd-sqlite-perl_1.29.bb > > > > diff --git a/recipes/perl/libdbd-sqlite-perl_1.29.bb b/recipes/perl/ > libdbd-sqlite-perl_1.29.bb > > new file mode 100644 > > index 0000000..10fe73a > > --- /dev/null > > +++ b/recipes/perl/libdbd-sqlite-perl_1.29.bb > > @@ -0,0 +1,29 @@ > > +DESCRIPTION = "PERL database interface driver for the SQLite database." > > +SECTION = "libs" > > +LICENSE = "Artistic|GPL" > > +DEPENDS = "libdbi-perl-native" > > +RDEPENDS = "libdbi-perl \ > > That should be RDEPENDS_${PN} > > We did have a script somewhere to check for things like that, does > anyone know where that went? > Here's one option: INHERIT += "recipe_sanity" bitbake -c recipe_sanity libdbd-sqlite-perl
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 29-01-10 15:36, Chris Larson wrote: > On Fri, Jan 29, 2010 at 3:27 AM, Koen Kooi <k.kooi@student.utwente.nl>wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> On 29-01-10 11:07, Michael Lippautz wrote: >>> --- >>> recipes/perl/libdbd-sqlite-perl_1.29.bb | 29 >> +++++++++++++++++++++++++++++ >>> 1 files changed, 29 insertions(+), 0 deletions(-) >>> create mode 100644 recipes/perl/libdbd-sqlite-perl_1.29.bb >>> >>> diff --git a/recipes/perl/libdbd-sqlite-perl_1.29.bb b/recipes/perl/ >> libdbd-sqlite-perl_1.29.bb >>> new file mode 100644 >>> index 0000000..10fe73a >>> --- /dev/null >>> +++ b/recipes/perl/libdbd-sqlite-perl_1.29.bb >>> @@ -0,0 +1,29 @@ >>> +DESCRIPTION = "PERL database interface driver for the SQLite database." >>> +SECTION = "libs" >>> +LICENSE = "Artistic|GPL" >>> +DEPENDS = "libdbi-perl-native" >>> +RDEPENDS = "libdbi-perl \ >> >> That should be RDEPENDS_${PN} >> >> We did have a script somewhere to check for things like that, does >> anyone know where that went? >> > > Here's one option: > > INHERIT += "recipe_sanity" > bitbake -c recipe_sanity libdbd-sqlite-perl That explains why I couldn't find it in contrib/ :) regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFLYwcdMkyGM64RGpERAlTkAJwJZkBzZDIEbNrXzXViv/ML8vzkwACggiVb nio5kWyzMYIKgC8MI6n0+b8= =UvMI -----END PGP SIGNATURE-----
Patch
diff --git a/recipes/perl/libdbd-sqlite-perl_1.29.bb b/recipes/perl/libdbd-sqlite-perl_1.29.bb new file mode 100644 index 0000000..10fe73a --- /dev/null +++ b/recipes/perl/libdbd-sqlite-perl_1.29.bb @@ -0,0 +1,29 @@ +DESCRIPTION = "PERL database interface driver for the SQLite database." +SECTION = "libs" +LICENSE = "Artistic|GPL" +DEPENDS = "libdbi-perl-native" +RDEPENDS = "libdbi-perl \ + perl-module-file-spec \ + perl-module-file-path \ + perl-module-scalar-util \ + perl-module-list-util \ + perl-module-test \ + perl-module-test-more \ + perl-module-test-harness \ + perl-module-file-basename \ + perl-module-storable \ + perl-module-extutils-makemaker \ + perl-module-locale \ + perl-module-tie-hash \ +" +PR = "r0" + +SRC_URI = "http://search.cpan.org/CPAN/authors/id/A/AD/ADAMK/DBD-SQLite-${PV}.tar.gz;name=dbdsqlite" +SRC_URI[dbdsqlite.md5sum] = "2a47cea6ecff62508775d90151a8030f" +SRC_URI[dbdsqlite.sha256sum] = "51d0d529e453ada1ce85772deb5cc4c86a2ebe9da2dd2fb0b40b77b555720867" + +S = "${WORKDIR}/DBD-SQLite-${PV}" + +inherit cpan + +BBCLASSEXTEND = "native"