Patchwork [RFC,1/2] libjson: add 0.9

login
register
mail settings
Submitter Koen Kooi
Date Nov. 21, 2011, 6:12 p.m.
Message ID <1321899155-19575-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/15199/
State New
Headers show

Comments

Koen Kooi - Nov. 21, 2011, 6:12 p.m.
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-devtools/libjson/libjson_0.9.bb |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-devtools/libjson/libjson_0.9.bb
Paul Menzel - Nov. 22, 2011, 9:08 a.m.
Dear Koen,


Am Montag, den 21.11.2011, 19:12 +0100 schrieb Koen Kooi:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/recipes-devtools/libjson/libjson_0.9.bb |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
>  create mode 100644 meta/recipes-devtools/libjson/libjson_0.9.bb
> 
> diff --git a/meta/recipes-devtools/libjson/libjson_0.9.bb b/meta/recipes-devtools/libjson/libjson_0.9.bb
> new file mode 100644
> index 0000000..4d609a6
> --- /dev/null
> +++ b/meta/recipes-devtools/libjson/libjson_0.9.bb
> @@ -0,0 +1,13 @@
> +DESCRIPTION = "JSON-C - A JSON implementation in C"
> +
> +LICENSE = "MIT/X11"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=30a276a476b02c2dcd0849bde417fb17"

please add at least the field `HOMEPAGE` as it is done in OE-classic
[1].

> +SRC_URI = "http://oss.metaparadigm.com/json-c/json-c-${PV}.tar.gz"
> +SRC_URI[md5sum] = "3a13d264528dcbaf3931b0cede24abae"
> +SRC_URI[sha256sum] = "702a486c9bf8e19137d484ab5c49b4ad314eb5e1fe37062a72c0a0fa39439475"
> +
> +S = "${WORKDIR}/json-c-${PV}"
> +
> +
> +inherit autotools


Thanks,

Paul


[1] http://git.openembedded.org/openembedded/tree/recipes/libjson/libjson_0.9.bb?id=55b3912f14b1919bf2cd330e48546f11c179794f
Koen Kooi - Nov. 22, 2011, 10:19 a.m.
Op 22 nov. 2011, om 10:08 heeft Paul Menzel het volgende geschreven:

> Dear Koen,
> 
> 
> Am Montag, den 21.11.2011, 19:12 +0100 schrieb Koen Kooi:
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> meta/recipes-devtools/libjson/libjson_0.9.bb |   13 +++++++++++++
>> 1 files changed, 13 insertions(+), 0 deletions(-)
>> create mode 100644 meta/recipes-devtools/libjson/libjson_0.9.bb
>> 
>> diff --git a/meta/recipes-devtools/libjson/libjson_0.9.bb b/meta/recipes-devtools/libjson/libjson_0.9.bb
>> new file mode 100644
>> index 0000000..4d609a6
>> --- /dev/null
>> +++ b/meta/recipes-devtools/libjson/libjson_0.9.bb
>> @@ -0,0 +1,13 @@
>> +DESCRIPTION = "JSON-C - A JSON implementation in C"
>> +
>> +LICENSE = "MIT/X11"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=30a276a476b02c2dcd0849bde417fb17"
> 
> please add at least the field `HOMEPAGE` as it is done in OE-classic
> [1].
> 
>> +SRC_URI = "http://oss.metaparadigm.com/json-c/json-c-${PV}.tar.gz"

Since the homepage can be derived from SRC_URI, is it really needed?

regards,

Koen
Paul Menzel - Nov. 22, 2011, 10:27 a.m.
Am Dienstag, den 22.11.2011, 11:19 +0100 schrieb Koen Kooi:
> Op 22 nov. 2011, om 10:08 heeft Paul Menzel het volgende geschreven:

> > Am Montag, den 21.11.2011, 19:12 +0100 schrieb Koen Kooi:
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> meta/recipes-devtools/libjson/libjson_0.9.bb |   13 +++++++++++++
> >> 1 files changed, 13 insertions(+), 0 deletions(-)
> >> create mode 100644 meta/recipes-devtools/libjson/libjson_0.9.bb
> >> 
> >> diff --git a/meta/recipes-devtools/libjson/libjson_0.9.bb b/meta/recipes-devtools/libjson/libjson_0.9.bb
> >> new file mode 100644
> >> index 0000000..4d609a6
> >> --- /dev/null
> >> +++ b/meta/recipes-devtools/libjson/libjson_0.9.bb
> >> @@ -0,0 +1,13 @@
> >> +DESCRIPTION = "JSON-C - A JSON implementation in C"
> >> +
> >> +LICENSE = "MIT/X11"
> >> +LIC_FILES_CHKSUM = "file://COPYING;md5=30a276a476b02c2dcd0849bde417fb17"
> > 
> > please add at least the field `HOMEPAGE` as it is done in OE-classic
> > [1].
> > 
> >> +SRC_URI = "http://oss.metaparadigm.com/json-c/json-c-${PV}.tar.gz"
> 
> Since the homepage can be derived from SRC_URI, is it really needed?

I always thought these metadata fields are used by interfaces like
package managers to allow people to know more about the package/program.


Thanks,

Paul
Koen Kooi - Nov. 22, 2011, 10:50 a.m.
Op 22 nov. 2011, om 11:27 heeft Paul Menzel het volgende geschreven:

> Am Dienstag, den 22.11.2011, 11:19 +0100 schrieb Koen Kooi:
>> Op 22 nov. 2011, om 10:08 heeft Paul Menzel het volgende geschreven:
> 
>>> Am Montag, den 21.11.2011, 19:12 +0100 schrieb Koen Kooi:
>>>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>>>> ---
>>>> meta/recipes-devtools/libjson/libjson_0.9.bb |   13 +++++++++++++
>>>> 1 files changed, 13 insertions(+), 0 deletions(-)
>>>> create mode 100644 meta/recipes-devtools/libjson/libjson_0.9.bb
>>>> 
>>>> diff --git a/meta/recipes-devtools/libjson/libjson_0.9.bb b/meta/recipes-devtools/libjson/libjson_0.9.bb
>>>> new file mode 100644
>>>> index 0000000..4d609a6
>>>> --- /dev/null
>>>> +++ b/meta/recipes-devtools/libjson/libjson_0.9.bb
>>>> @@ -0,0 +1,13 @@
>>>> +DESCRIPTION = "JSON-C - A JSON implementation in C"
>>>> +
>>>> +LICENSE = "MIT/X11"
>>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=30a276a476b02c2dcd0849bde417fb17"
>>> 
>>> please add at least the field `HOMEPAGE` as it is done in OE-classic
>>> [1].
>>> 
>>>> +SRC_URI = "http://oss.metaparadigm.com/json-c/json-c-${PV}.tar.gz"
>> 
>> Since the homepage can be derived from SRC_URI, is it really needed?
> 
> I always thought these metadata fields are used by interfaces like
> package managers to allow people to know more about the package/program.

You are right, I've modified the patch and will show up in v2.

regards,

Koen
Saul Wold - Nov. 22, 2011, 4:19 p.m.
On 11/21/2011 10:12 AM, Koen Kooi wrote:
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
>   meta/recipes-devtools/libjson/libjson_0.9.bb |   13 +++++++++++++
>   1 files changed, 13 insertions(+), 0 deletions(-)
>   create mode 100644 meta/recipes-devtools/libjson/libjson_0.9.bb
>
> diff --git a/meta/recipes-devtools/libjson/libjson_0.9.bb b/meta/recipes-devtools/libjson/libjson_0.9.bb
> new file mode 100644
> index 0000000..4d609a6
> --- /dev/null
> +++ b/meta/recipes-devtools/libjson/libjson_0.9.bb
> @@ -0,0 +1,13 @@
> +DESCRIPTION = "JSON-C - A JSON implementation in C"
> +
> +LICENSE = "MIT/X11"

I believe that LICENSE = "MIT" (or MIT-X) as the standard entry.
Maybe Beth can give the correct version here.

Thanks
	Sau!

> +LIC_FILES_CHKSUM = "file://COPYING;md5=30a276a476b02c2dcd0849bde417fb17"
> +
> +SRC_URI = "http://oss.metaparadigm.com/json-c/json-c-${PV}.tar.gz"
> +SRC_URI[md5sum] = "3a13d264528dcbaf3931b0cede24abae"
> +SRC_URI[sha256sum] = "702a486c9bf8e19137d484ab5c49b4ad314eb5e1fe37062a72c0a0fa39439475"
> +
> +S = "${WORKDIR}/json-c-${PV}"
> +
> +
> +inherit autotools
Koen Kooi - Nov. 22, 2011, 6:40 p.m.
Op 22 nov. 2011, om 17:19 heeft Saul Wold het volgende geschreven:

> On 11/21/2011 10:12 AM, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> ---
>>  meta/recipes-devtools/libjson/libjson_0.9.bb |   13 +++++++++++++
>>  1 files changed, 13 insertions(+), 0 deletions(-)
>>  create mode 100644 meta/recipes-devtools/libjson/libjson_0.9.bb
>> 
>> diff --git a/meta/recipes-devtools/libjson/libjson_0.9.bb b/meta/recipes-devtools/libjson/libjson_0.9.bb
>> new file mode 100644
>> index 0000000..4d609a6
>> --- /dev/null
>> +++ b/meta/recipes-devtools/libjson/libjson_0.9.bb
>> @@ -0,0 +1,13 @@
>> +DESCRIPTION = "JSON-C - A JSON implementation in C"
>> +
>> +LICENSE = "MIT/X11"
> 
> I believe that LICENSE = "MIT" (or MIT-X) as the standard entry.
> Maybe Beth can give the correct version here.

Thanks for the feedback, I'll wait for Beth to tell use the proper form before sending a v2.

regrds,

Koen
Joshua Lock - Nov. 22, 2011, 6:52 p.m.
On 22/11/11 10:40, Koen Kooi wrote:
>
> Op 22 nov. 2011, om 17:19 heeft Saul Wold het volgende geschreven:
>
>> On 11/21/2011 10:12 AM, Koen Kooi wrote:
>>> +LICENSE = "MIT/X11"
>>
>> I believe that LICENSE = "MIT" (or MIT-X) as the standard entry.
>> Maybe Beth can give the correct version here.
>

I think it's MIT, there's no MIT-X in the SPDX registry:
http://spdx.org/licenses/

Joshua
Saul Wold - Nov. 22, 2011, 7:42 p.m.
On 11/22/2011 10:52 AM, Joshua Lock wrote:
>
>
> On 22/11/11 10:40, Koen Kooi wrote:
>>
>> Op 22 nov. 2011, om 17:19 heeft Saul Wold het volgende geschreven:
>>
>>> On 11/21/2011 10:12 AM, Koen Kooi wrote:
>>>> +LICENSE = "MIT/X11"
>>>
>>> I believe that LICENSE = "MIT" (or MIT-X) as the standard entry.
>>> Maybe Beth can give the correct version here.
>>
>
> I think it's MIT, there's no MIT-X in the SPDX registry:
> http://spdx.org/licenses/
>
In that case, we need to fix some older recipes that still contain MIT-X 
in the LICENSE field (that's why I was unsure, and I did not have the 
spdx.org website loaded in my brain).

Sau!

> Joshua

Patch

diff --git a/meta/recipes-devtools/libjson/libjson_0.9.bb b/meta/recipes-devtools/libjson/libjson_0.9.bb
new file mode 100644
index 0000000..4d609a6
--- /dev/null
+++ b/meta/recipes-devtools/libjson/libjson_0.9.bb
@@ -0,0 +1,13 @@ 
+DESCRIPTION = "JSON-C - A JSON implementation in C"
+
+LICENSE = "MIT/X11"
+LIC_FILES_CHKSUM = "file://COPYING;md5=30a276a476b02c2dcd0849bde417fb17"
+
+SRC_URI = "http://oss.metaparadigm.com/json-c/json-c-${PV}.tar.gz"
+SRC_URI[md5sum] = "3a13d264528dcbaf3931b0cede24abae"
+SRC_URI[sha256sum] = "702a486c9bf8e19137d484ab5c49b4ad314eb5e1fe37062a72c0a0fa39439475"
+
+S = "${WORKDIR}/json-c-${PV}"
+
+
+inherit autotools