| Submitter | Guo Hongruan |
|---|---|
| Date | 2010-01-23 09:36:07 |
| Message ID | <1264239367-26057-1-git-send-email-camelguo@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/1511/ |
| State | New |
| Headers | show |
Comments
On Saturday 23 January 2010 10:36:07 Guo Hongruan wrote: > * 'addtask deploy' sentence in linux-storcenter_2.6.27.7.bb conflicts with > the same one in kernel.bbclass and causes circular dependency between > do_package and do_deploy Could you please grep through recipes/linux and see how many more issues we have of the same kind?
Yes, I did. the same question exists in recipes/linux/gumstix-linux.inc|72| addtask deploy before do_package after do_install which may cause circular dependency too. 在 Sat, 23 Jan 2010 17:51:06 +0800，Holger Hans Peter Freyther <holger+oe@freyther.de> 写道: > On Saturday 23 January 2010 10:36:07 Guo Hongruan wrote: >> * 'addtask deploy' sentence in linux-storcenter_2.6.27.7.bb conflicts >> with >> the same one in kernel.bbclass and causes circular dependency between >> do_package and do_deploy > > Could you please grep through recipes/linux and see how many more issues > we > have of the same kind? > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
On Sat, Jan 23, 2010 at 05:55:54PM +0800, Guo Hongruan wrote: > Yes, I did. > > the same question exists in > recipes/linux/gumstix-linux.inc|72| addtask deploy before do_package > after do_install > which may cause circular dependency too. But if you just remove that line, the custom do_deploy task won't be used at all IIRC.. so proper fix would be to adjust after and before like in a55e9a527a8c9823044196d031f2da2783ff8f35 and then bc2bddb71d8c5db25b80aa6435392ec1c8df39f9 Probably: addtask deploy before do_build after do_package but please check before do_build was needed to force it run at all (for -c build) after do_package was used, because we're packing already stripped modules to modules.tgz and we needed to have packages-split already populated. Regards,
the do_deploy task has been added in kernel.bbclass, which defines the proper order for these tasks. So it should be safe to remove 'addtask deploy' from the recipe. 在 Sat, 23 Jan 2010 18:10:47 +0800，Martin Jansa <martin.jansa@gmail.com> 写道: > On Sat, Jan 23, 2010 at 05:55:54PM +0800, Guo Hongruan wrote: >> Yes, I did. >> >> the same question exists in >> recipes/linux/gumstix-linux.inc|72| addtask deploy before do_package >> after do_install >> which may cause circular dependency too. > > But if you just remove that line, the custom do_deploy task won't be > used at all IIRC.. so proper fix would be to adjust after and before > like in a55e9a527a8c9823044196d031f2da2783ff8f35 and then > bc2bddb71d8c5db25b80aa6435392ec1c8df39f9 > > Probably: > addtask deploy before do_build after do_package > > but please check > before do_build was needed to force it run at all (for -c build) > after do_package was used, because we're packing already stripped > modules to modules.tgz and we needed to have packages-split already > populated. > > Regards, >
Patch
diff --git a/recipes/linux/linux-storcenter_2.6.27.7.bb b/recipes/linux/linux-storcenter_2.6.27.7.bb index b403cda..e842ab7 100644 --- a/recipes/linux/linux-storcenter_2.6.27.7.bb +++ b/recipes/linux/linux-storcenter_2.6.27.7.bb @@ -53,5 +53,3 @@ do_deploy() { } do_deploy[dirs] = "${S}" - -addtask deploy before do_package after do_install
* 'addtask deploy' sentence in linux-storcenter_2.6.27.7.bb conflicts with the same one in kernel.bbclass and causes circular dependency between do_package and do_deploy Signed-off-by: Guo Hongruan <camelguo@gmail.com> --- recipes/linux/linux-storcenter_2.6.27.7.bb | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)