Patchwork [0/4] More useradd cleanups

login
mail settings
Submitter Scott Garman
Date Nov. 9, 2011, 2:56 a.m.
Message ID <cover.1320807056.git.scott.a.garman@intel.com>
Download mbox
Permalink /patch/14591/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib sgarman/useradd-cleanup-final

Comments

Scott Garman - Nov. 9, 2011, 2:56 a.m.
Hello,

Richard pointed out that USERADDPN is no longer needed in
useradd.bbclass. While removing that, I noticed that I was actually
injecting the user/group preinst script into *all* packages whose
recipe inherits useradd. That's not what we want, and is the reason
for the USERADD_PACKAGES variable. So I refactored the class to fix
that and clarified the useradd-example recipe documentation.

Finally, I added another check to avoid modifying -nativesdk packages.

The following changes since commit 25fae81538a92e15eab3fc169ebce44505f67839:

  python: skip setup.py 'import check' when cross-compiling (2011-11-08 21:44:23 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib sgarman/useradd-cleanup-final
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/useradd-cleanup-final

Scott Garman (4):
  useradd.bbclass: only modify packages in USERADD_PACKAGES
  useradd.bbclass: do not modify -nativesdk packages
  useradd-example.bb: update example documentation comments
  avahi: remove USERADDPN

 .../recipes-skeleton/useradd/useradd-example.bb    |    9 ++--
 meta/classes/useradd.bbclass                       |   45 ++++++++------------
 meta/recipes-connectivity/avahi/avahi.inc          |    1 -
 3 files changed, 22 insertions(+), 33 deletions(-)
Saul Wold - Nov. 10, 2011, 5:18 p.m.
On 11/08/2011 06:56 PM, Scott Garman wrote:
> Hello,
>
> Richard pointed out that USERADDPN is no longer needed in
> useradd.bbclass. While removing that, I noticed that I was actually
> injecting the user/group preinst script into *all* packages whose
> recipe inherits useradd. That's not what we want, and is the reason
> for the USERADD_PACKAGES variable. So I refactored the class to fix
> that and clarified the useradd-example recipe documentation.
>
> Finally, I added another check to avoid modifying -nativesdk packages.
>
> The following changes since commit 25fae81538a92e15eab3fc169ebce44505f67839:
>
>    python: skip setup.py 'import check' when cross-compiling (2011-11-08 21:44:23 +0000)
>
> are available in the git repository at:
>    git://git.pokylinux.org/poky-contrib sgarman/useradd-cleanup-final
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/useradd-cleanup-final
>
> Scott Garman (4):
>    useradd.bbclass: only modify packages in USERADD_PACKAGES
>    useradd.bbclass: do not modify -nativesdk packages
>    useradd-example.bb: update example documentation comments
>    avahi: remove USERADDPN
>
>   .../recipes-skeleton/useradd/useradd-example.bb    |    9 ++--
>   meta/classes/useradd.bbclass                       |   45 ++++++++------------
>   meta/recipes-connectivity/avahi/avahi.inc          |    1 -
>   3 files changed, 22 insertions(+), 33 deletions(-)
>

Merged int OE-Core

Thanks
	Sau!