[meta-arago,master/kirkstone] net-snmp: Remove broken net-snmp recipe

This bbappend is not functional on the latest net-snmp. The additional
patches are ~61k lines, half the entire size of meta-arago. This extra
functionality should have been added to a forked repo and that is how we
should add this back if ever needed again. Remove this recipe.

Signed-off-by: Andrew Davis <afd@ti.com>
---

Patch created with --irreversible-delete to prevent oversized email,
will need manually applied.

 .../packagegroup-arago-tisdk-connectivity.bb  |     2 -
 .../net-snmp/files/snmpd.conf                 |   422 -
 ...initial-support-for-hsr-prp-mib-supp.patch |  1224 -
 ...a-dummy-lreInterfaceConfigTable-for-.patch |   326 -
 ...update-lreInterfaceConfigTable-for-M.patch | 12791 -------
 ...update-lreInterfaceTable-to-use-real.patch |   413 -
 ...2439-3-MIB-refractor-code-for-re-use.patch |   403 -
 ...update-to-get-real-slave-admin-and-l.patch |   612 -
 ...add-functions-to-get-set-real-values.patch |   471 -
 ...Move-existing-lre-access-functions-t.patch |   884 -
 ...add-initial-version-of-stats-and-nod.patch | 10371 -----
 ...-3-MIB-Add-support-for-lreNodesTable.patch |  1236 -
 .../0011-IEC-62439-3-MIB-bug-fixes.patch      |   722 -
 ...Fix-index-issue-in-table-implementat.patch |    87 -
 ...39-3-MIB-Add-command-to-set-HSR-mode.patch |    34 -
 ...-3-MIB-add-license-header-to-sources.patch | 31871 ----------------
 ...fix-lreManufacturerName-displaying-d.patch |    34 -
 ...fix-duplicate-discard-mode-setting-f.patch |    53 -
 ...to-retrieve-mibs-from-main-interface.patch |   700 -
 ...update-to-work-with-iproute2-changes.patch |    71 -
 .../net-snmp/net-snmp_%.bbappend              |    31 -
 21 files changed, 62758 deletions(-)
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/files/snmpd.conf
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0001-IEC-62439-3-add-initial-support-for-hsr-prp-mib-supp.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0002-IEC-62439-3-add-a-dummy-lreInterfaceConfigTable-for-.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0003-IEC-62439-3-MIB-update-lreInterfaceConfigTable-for-M.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0004-IEC-62439-3-MIB-update-lreInterfaceTable-to-use-real.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0005-IEC-62439-3-MIB-refractor-code-for-re-use.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0006-IEC-62439-3-MIB-update-to-get-real-slave-admin-and-l.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0007-IEC-62439-3-MIB-add-functions-to-get-set-real-values.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0008-IEC-62439-3-MIB-Move-existing-lre-access-functions-t.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0009-IEC-62439-3-MIB-add-initial-version-of-stats-and-nod.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0010-IEC-62439-3-MIB-Add-support-for-lreNodesTable.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0011-IEC-62439-3-MIB-bug-fixes.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0012-IEC-62439-3-MIB-Fix-index-issue-in-table-implementat.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0013-IEC-62439-3-MIB-Add-command-to-set-HSR-mode.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0014-IEC-62439-3-MIB-add-license-header-to-sources.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0015-IEC-62439-3-MIB-fix-lreManufacturerName-displaying-d.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0016-IEC-62439-3-MIB-fix-duplicate-discard-mode-setting-f.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0017-hsr-prp-update-to-retrieve-mibs-from-main-interface.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0018-IEC-62439-3-MIB-update-to-work-with-iproute2-changes.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp_%.bbappend

On Tue, Oct 25, 2022 at 09:22:35AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> This bbappend is not functional on the latest net-snmp. The additional
> patches are ~61k lines, half the entire size of meta-arago. This extra
> functionality should have been added to a forked repo and that is how we
> should add this back if ever needed again. Remove this recipe.

I'm fine with removing these patches, since they break the latest snmp and 
it's been disabled in default images since Kirkstone.

But I'm not so sure about promoting forked repo concept...

The best approach, of course, is to get the patches submitted, reviewed and 
accepted upstream (snmp in this case).

Making changes with patches, instead of a forked repo, has this benefit - when 
updating layer to a new release/LTS and these patches start breaking, it gets 
noticed right away. It forces a decision - either someone is tasked with 
updating the patches and fixing the breakage, or they get removed/disabled at 
least.

Using a forked repo has a high possibility of a stale and outdated component, 
collecting security vulnerabilities, unfixed bugs, etc.

On 10/25/22 4:30 PM, Denys Dmytriyenko wrote:
> On Tue, Oct 25, 2022 at 09:22:35AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
>> This bbappend is not functional on the latest net-snmp. The additional
>> patches are ~61k lines, half the entire size of meta-arago. This extra
>> functionality should have been added to a forked repo and that is how we
>> should add this back if ever needed again. Remove this recipe.
> 
> I'm fine with removing these patches, since they break the latest snmp and
> it's been disabled in default images since Kirkstone.
> 
> But I'm not so sure about promoting forked repo concept...
> 
> The best approach, of course, is to get the patches submitted, reviewed and
> accepted upstream (snmp in this case).
> 
> Making changes with patches, instead of a forked repo, has this benefit - when
> updating layer to a new release/LTS and these patches start breaking, it gets
> noticed right away. It forces a decision - either someone is tasked with
> updating the patches and fixing the breakage, or they get removed/disabled at
> least.
> 

That's fair. I'd say we also start to reduce our wildcard bbappends, if the
package moves forward underneath, then we should re-evaluate anyway.

> Using a forked repo has a high possibility of a stale and outdated component,
> collecting security vulnerabilities, unfixed bugs, etc.
> 

I'd normally agree, but at some point the amount of change justifies the fork.
This would certainly be such a case.

Andrew