Patchwork [CONSOLIDATED,PULL,14/28] Add new IMAGE_CLASSES variable for classes for image generation

login
register
mail settings
Submitter Saul Wold
Date Nov. 5, 2011, 5:22 p.m.
Message ID <8e793bb4092c80baf441a33f348852bfbd4a4420.1320513631.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/14341/
State New
Headers show

Comments

Saul Wold - Nov. 5, 2011, 5:22 p.m.
From: Matthew McClintock <msm@freescale.com>

Allows us to import classes only for images and not to the global
namespace

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 meta/classes/image.bbclass  |    3 ++-
 meta/conf/local.conf.sample |    6 ++++++
 2 files changed, 8 insertions(+), 1 deletions(-)
Richard Purdie - Nov. 7, 2011, 2:04 p.m.
On Sat, 2011-11-05 at 10:22 -0700, Saul Wold wrote:
> From: Matthew McClintock <msm@freescale.com>
> 
> Allows us to import classes only for images and not to the global
> namespace
> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  meta/classes/image.bbclass  |    3 ++-
>  meta/conf/local.conf.sample |    6 ++++++
>  2 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 05f4331..a2770a4 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -111,7 +111,8 @@ def get_devtable_list(d):
>          str += " %s" % bb.which(bb.data.getVar('BBPATH', d, 1), devtable)
>      return str
>  
> -inherit image_types
> +IMAGE_CLASSES ?= "image_types"
> +inherit ${IMAGE_CLASSES}
>  
>  IMAGE_POSTPROCESS_COMMAND ?= ""
>  MACHINE_POSTPROCESS_COMMAND ?= ""
> diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
> index 73ab9f8..aa546c7 100644
> --- a/meta/conf/local.conf.sample
> +++ b/meta/conf/local.conf.sample
> @@ -141,6 +141,12 @@ EXTRA_IMAGE_FEATURES = "debug-tweaks"
>  # NOTE: mklibs also needs to be explicitly enabled for a given image, see local.conf.extended
>  USER_CLASSES ?= "image-mklibs image-prelink"
>  
> +# Additional image generation features
> +#
> +# The following is a list of classes to import to use in the generation of images
> +# currently an example class is image_types_uboot
> +# IMAGE_CLASSES = " image_types_uboot"
> +

Most initial new users don't need to see this. Can we place this into
local.conf.sample.extended please?

Cheers,

Richard
McClintock Matthew-B29882 - Nov. 7, 2011, 8:16 p.m.
On Mon, Nov 7, 2011 at 8:04 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Most initial new users don't need to see this. Can we place this into
> local.conf.sample.extended please?

Follow up patch sent on other thread.

-M

Patch

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 05f4331..a2770a4 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -111,7 +111,8 @@  def get_devtable_list(d):
         str += " %s" % bb.which(bb.data.getVar('BBPATH', d, 1), devtable)
     return str
 
-inherit image_types
+IMAGE_CLASSES ?= "image_types"
+inherit ${IMAGE_CLASSES}
 
 IMAGE_POSTPROCESS_COMMAND ?= ""
 MACHINE_POSTPROCESS_COMMAND ?= ""
diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
index 73ab9f8..aa546c7 100644
--- a/meta/conf/local.conf.sample
+++ b/meta/conf/local.conf.sample
@@ -141,6 +141,12 @@  EXTRA_IMAGE_FEATURES = "debug-tweaks"
 # NOTE: mklibs also needs to be explicitly enabled for a given image, see local.conf.extended
 USER_CLASSES ?= "image-mklibs image-prelink"
 
+# Additional image generation features
+#
+# The following is a list of classes to import to use in the generation of images
+# currently an example class is image_types_uboot
+# IMAGE_CLASSES = " image_types_uboot"
+
 #
 # Runtime testing of images
 #