Patchwork [4/5] dhcp: rename dhcp4.inc to dhcp.inc

login
register
mail settings
Submitter Otavio Salvador
Date Nov. 4, 2011, 6:20 p.m.
Message ID <7e3c2e21652019ed5dd2d45beff62a855152f0a4.1320430778.git.otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/14307/
State New
Headers show

Comments

Otavio Salvador - Nov. 4, 2011, 6:20 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../dhcp/{dhcp4.inc => dhcp.inc}                   |    0
 meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb       |    2 +-
 2 files changed, 1 insertions(+), 1 deletions(-)
 rename meta/recipes-connectivity/dhcp/{dhcp4.inc => dhcp.inc} (100%)
Phil Blundell - Nov. 4, 2011, 9:17 p.m.
On Fri, 2011-11-04 at 18:20 +0000, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  .../dhcp/{dhcp4.inc => dhcp.inc}                   |    0
>  meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb       |    2 +-
>  2 files changed, 1 insertions(+), 1 deletions(-)
>  rename meta/recipes-connectivity/dhcp/{dhcp4.inc => dhcp.inc} (100%)

Why is this patch an improvement?  I don't have anything against it
particularly but it doesn't seem that it buys much either, and there is
no clue in the commit message as to what it is trying to achieve.

p.
Otavio Salvador - Nov. 5, 2011, 8:42 p.m.
On Fri, Nov 4, 2011 at 19:17, Phil Blundell <philb@gnu.org> wrote:
> Why is this patch an improvement?  I don't have anything against it
> particularly but it doesn't seem that it buys much either, and there is
> no clue in the commit message as to what it is trying to achieve.

Since we dropped the dhcp3.inc file makes no sense to have it named
dhcp4.inc so I renamed it. Just as simple as that.

Patch

diff --git a/meta/recipes-connectivity/dhcp/dhcp4.inc b/meta/recipes-connectivity/dhcp/dhcp.inc
similarity index 100%
rename from meta/recipes-connectivity/dhcp/dhcp4.inc
rename to meta/recipes-connectivity/dhcp/dhcp.inc
diff --git a/meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb b/meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb
index 85f473d..223522f 100644
--- a/meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb
+++ b/meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb
@@ -1,4 +1,4 @@ 
-require dhcp4.inc
+require dhcp.inc
 
 PR = "r2"