Patchwork [2/3] core-image-minimal-initramfs: force IMAGE_FSTYPES

login
register
mail settings
Submitter Paul Eggleton
Date Nov. 4, 2011, 5:52 p.m.
Message ID <8ae5b3cd9ef609e444cc360e226f857685e2e254.1320429060.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/14281/
State Accepted
Headers show

Comments

Paul Eggleton - Nov. 4, 2011, 5:52 p.m.
If the user has set their own value for IMAGE_FSTYPES, they may have
disabled the cpio.gz image type, preventing the initramfs from being
produced in the format that image-live.bbclass expects; so force
IMAGE_FSTYPES to cpio.gz within the initramfs image recipe.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 .../images/core-image-minimal-initramfs.bb         |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Koen Kooi - Nov. 4, 2011, 6:18 p.m.
Op 4 nov. 2011, om 18:52 heeft Paul Eggleton het volgende geschreven:

> If the user has set their own value for IMAGE_FSTYPES, they may have
> disabled the cpio.gz image type, preventing the initramfs from being
> produced in the format that image-live.bbclass expects; so force
> IMAGE_FSTYPES to cpio.gz within the initramfs image recipe.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> .../images/core-image-minimal-initramfs.bb         |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bb b/meta/recipes-core/images/core-image-minimal-initramfs.bb
> index 0bac27a..e4d0e51 100644
> --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
> +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
> @@ -13,3 +13,4 @@ LICENSE = "MIT"
> inherit core-image
> 
> IMAGE_ROOTFS_SIZE = "8192"
> +IMAGE_FSTYPES = "cpio.gz"

_append or += would give less suprises.

regards,

Koen
lumag - Nov. 15, 2011, 8:30 a.m.
On 11/04/2011 10:18 PM, Koen Kooi wrote:
>
> Op 4 nov. 2011, om 18:52 heeft Paul Eggleton het volgende geschreven:
>
>> If the user has set their own value for IMAGE_FSTYPES, they may have
>> disabled the cpio.gz image type, preventing the initramfs from being
>> produced in the format that image-live.bbclass expects; so force
>> IMAGE_FSTYPES to cpio.gz within the initramfs image recipe.
>>
>> Signed-off-by: Paul Eggleton<paul.eggleton@linux.intel.com>
>> ---
>> .../images/core-image-minimal-initramfs.bb         |    1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bb b/meta/recipes-core/images/core-image-minimal-initramfs.bb
>> index 0bac27a..e4d0e51 100644
>> --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
>> +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
>> @@ -13,3 +13,4 @@ LICENSE = "MIT"
>> inherit core-image
>>
>> IMAGE_ROOTFS_SIZE = "8192"
>> +IMAGE_FSTYPES = "cpio.gz"
>
> _append or += would give less suprises.

This was merged as IMAGE_FSTYPES =+ "cpio.gz"
Now this brings problems if I have IMAGE_FSTYPES += "live" in my 
local.conf / BSP machine.conf.

1) OE tries to generate hddimg for this initramfs image, which is 
strange idea
2) If OE is trying to generate bootimg (hddimg) when the kernel is not 
yet deployed, building fails (as bootimg can't find a deployed kernel to 
put into hddimg).

Please revert this back to original patch as proposed by Paul.
Paul Eggleton - Nov. 18, 2011, 1:55 p.m.
On Tuesday 15 November 2011 12:30:15 Dmitry Eremin-Solenikov wrote:
> This was merged as IMAGE_FSTYPES =+ "cpio.gz"
> Now this brings problems if I have IMAGE_FSTYPES += "live" in my
> local.conf / BSP machine.conf.
> 
> 1) OE tries to generate hddimg for this initramfs image, which is
> strange idea
> 2) If OE is trying to generate bootimg (hddimg) when the kernel is not
> yet deployed, building fails (as bootimg can't find a deployed kernel to
> put into hddimg).
> 
> Please revert this back to original patch as proposed by Paul.

OK, so what are we going to do about this? Do we have to do some filtering of 
this variable?

Cheers,
Paul
lumag - Nov. 18, 2011, 1:56 p.m.
On 11/18/2011 05:55 PM, Paul Eggleton wrote:
> On Tuesday 15 November 2011 12:30:15 Dmitry Eremin-Solenikov wrote:
>> This was merged as IMAGE_FSTYPES =+ "cpio.gz"
>> Now this brings problems if I have IMAGE_FSTYPES += "live" in my
>> local.conf / BSP machine.conf.
>>
>> 1) OE tries to generate hddimg for this initramfs image, which is
>> strange idea
>> 2) If OE is trying to generate bootimg (hddimg) when the kernel is not
>> yet deployed, building fails (as bootimg can't find a deployed kernel to
>> put into hddimg).
>>
>> Please revert this back to original patch as proposed by Paul.
>
> OK, so what are we going to do about this? Do we have to do some filtering of
> this variable?

I'd propose to just set it via:

IMAGE_FSTYPES = "cpio.gz". It is really no point in generating other 
types of inititramfs images.

>
> Cheers,
> Paul
>
Andrea Adami - Nov. 18, 2011, 2:06 p.m.
On Fri, Nov 18, 2011 at 2:56 PM, Dmitry Eremin-Solenikov
<dbaryshkov@gmail.com> wrote:
> On 11/18/2011 05:55 PM, Paul Eggleton wrote:
>>
>> On Tuesday 15 November 2011 12:30:15 Dmitry Eremin-Solenikov wrote:
>>>
>>> This was merged as IMAGE_FSTYPES =+ "cpio.gz"
>>> Now this brings problems if I have IMAGE_FSTYPES += "live" in my
>>> local.conf / BSP machine.conf.
>>>
>>> 1) OE tries to generate hddimg for this initramfs image, which is
>>> strange idea
>>> 2) If OE is trying to generate bootimg (hddimg) when the kernel is not
>>> yet deployed, building fails (as bootimg can't find a deployed kernel to
>>> put into hddimg).
>>>
>>> Please revert this back to original patch as proposed by Paul.
>>
>> OK, so what are we going to do about this? Do we have to do some filtering
>> of
>> this variable?
>
> I'd propose to just set it via:
>
> IMAGE_FSTYPES = "cpio.gz". It is really no point in generating other types
> of inititramfs images.

In some other initramfs-images "cpio.lzma" is a welcomed option to save size.

Regards

Andrea

>
>>
>> Cheers,
>> Paul
>>
>
>
> --
> With best wishes
> Dmitry
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bb b/meta/recipes-core/images/core-image-minimal-initramfs.bb
index 0bac27a..e4d0e51 100644
--- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
+++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
@@ -13,3 +13,4 @@  LICENSE = "MIT"
 inherit core-image
 
 IMAGE_ROOTFS_SIZE = "8192"
+IMAGE_FSTYPES = "cpio.gz"