Patchwork dbus: Use $D not ${D} in the postinstall

login
register
mail settings
Submitter Richard Purdie
Date Nov. 1, 2011, 2:26 p.m.
Message ID <1320157607.15387.10.camel@ted>
Download mbox | patch
Permalink /patch/14131/
State Accepted
Commit 509a8a9ea428debf3ff2115fcff0aa89d0239ced
Headers show

Comments

Richard Purdie - Nov. 1, 2011, 2:26 p.m.
We need to do this as we don't want bitbake to expand the variable
but use the shell variable instead.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Koen Kooi - Nov. 1, 2011, 2:43 p.m.
Op 1 nov. 2011, om 15:26 heeft Richard Purdie het volgende geschreven:

> We need to do this as we don't want bitbake to expand the variable
> but use the shell variable instead.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Acked-by: Koen Kooi <k-kooi@ti.com>

Although it technically needs a PR bump, we can skip it since there's one later in this patch set.

> ---
> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> index 4c7d87a..b378bda 100644
> --- a/meta/recipes-core/dbus/dbus.inc
> +++ b/meta/recipes-core/dbus/dbus.inc
> @@ -51,7 +51,7 @@ RRECOMMENDS_${PN}-lib = "${PN}"
> FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-glib-tool"
> 
> pkg_postinst_dbus() {
> -	if [ -z "${D}" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
> +	if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
> 		/etc/init.d/populate-volatile.sh update
> 	fi
> }
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
index 4c7d87a..b378bda 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -51,7 +51,7 @@  RRECOMMENDS_${PN}-lib = "${PN}"
 FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-glib-tool"
 
 pkg_postinst_dbus() {
-	if [ -z "${D}" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
+	if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
 		/etc/init.d/populate-volatile.sh update
 	fi
 }