Patchwork u-boot.inc: allow variable make targets

login
register
mail settings
Submitter chase maupin
Date March 15, 2011, 2:42 p.m.
Message ID <1300200121-31822-1-git-send-email-Chase.Maupin@ti.com>
Download mbox | patch
Permalink /patch/1413/
State Accepted
Headers show

Comments

chase maupin - March 15, 2011, 2:42 p.m.
* Later versions of u-boot sometimes have top level make targets
  such as u-boot.imx, u-boot.kwb, and for upcoming TI devices
  u-boot.ti.
* These targets define different calls to the mkimage tool to
  change the images created, such as changing the load address.
* This change allows recipes to change the default make target
  of "all" to something like u-boot.ti or u-boot.imx by setting
  the UBOOT_MAKE_TARGET variable.

Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
 recipes/u-boot/u-boot.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
chase maupin - March 15, 2011, 3:16 p.m.
I should have probably clarified that this was intended for the 2011.03-maintenance branch.  Tom, I have also submitted this to the oe-core.  Would you be willing to pick this up?

Sincerely,
Chase Maupin
Open Platforms
ARM MPU
e-mail: chase.maupin@ti.com
phone: (214) 567-2950

For support:
Forums - http://community.ti.com/forums/
Wiki - http://wiki.davincidsp.com/

> -----Original Message-----
> From: Chase Maupin [mailto:chasemaupin03@gmail.com]
> Sent: Tuesday, March 15, 2011 9:42 AM
> To: openembedded-devel@lists.openembedded.org
> Cc: Maupin, Chase
> Subject: [PATCH] u-boot.inc: allow variable make targets
> 
> * Later versions of u-boot sometimes have top level make targets
>   such as u-boot.imx, u-boot.kwb, and for upcoming TI devices
>   u-boot.ti.
> * These targets define different calls to the mkimage tool to
>   change the images created, such as changing the load address.
> * This change allows recipes to change the default make target
>   of "all" to something like u-boot.ti or u-boot.imx by setting
>   the UBOOT_MAKE_TARGET variable.
> 
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
>  recipes/u-boot/u-boot.inc |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/u-boot/u-boot.inc b/recipes/u-boot/u-boot.inc
> index 88c6a4d..ffd1e1e 100644
> --- a/recipes/u-boot/u-boot.inc
> +++ b/recipes/u-boot/u-boot.inc
> @@ -16,6 +16,7 @@ UBOOT_MACHINE ?= "${MACHINE}_config"
>  UBOOT_BINARY ?= "u-boot.bin"
>  UBOOT_IMAGE ?= "u-boot-${MACHINE}-${PV}-${PR}.bin"
>  UBOOT_SYMLINK ?= "u-boot-${MACHINE}.bin"
> +UBOOT_MAKE_TARGET ?= "all"
> 
>  do_configure () {
>  	oe_runmake ${UBOOT_MACHINE}
> @@ -25,7 +26,7 @@ do_compile () {
>  	unset LDFLAGS
>  	unset CFLAGS
>  	unset CPPFLAGS
> -	oe_runmake all
> +	oe_runmake ${UBOOT_MAKE_TARGET}
>  	oe_runmake tools env HOSTCC="${CC}"
>  }
> 
> --
> 1.7.0.4
chase maupin - March 16, 2011, 1:40 p.m.
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Maupin, Chase
> Sent: Tuesday, March 15, 2011 10:16 AM
> To: Chase Maupin; openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [PATCH] u-boot.inc: allow variable make targets
> 
> I should have probably clarified that this was intended for the 2011.03-
> maintenance branch.  Tom, I have also submitted this to the oe-core.
> Would you be willing to pick this up?

Just FYI this has been merged into the oe-core master (see http://lists.linuxtogo.org/pipermail/openembedded-core/2011-March/000533.html) as well as the angstrom-layers master (see http://lists.linuxtogo.org/pipermail/openembedded-core/2011-March/000512.html) 

> 
> > -----Original Message-----
> > From: Chase Maupin [mailto:chasemaupin03@gmail.com]
> > Sent: Tuesday, March 15, 2011 9:42 AM
> > To: openembedded-devel@lists.openembedded.org
> > Cc: Maupin, Chase
> > Subject: [PATCH] u-boot.inc: allow variable make targets
> >
> > * Later versions of u-boot sometimes have top level make targets
> >   such as u-boot.imx, u-boot.kwb, and for upcoming TI devices
> >   u-boot.ti.
> > * These targets define different calls to the mkimage tool to
> >   change the images created, such as changing the load address.
> > * This change allows recipes to change the default make target
> >   of "all" to something like u-boot.ti or u-boot.imx by setting
> >   the UBOOT_MAKE_TARGET variable.
> >
> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> > ---
> >  recipes/u-boot/u-boot.inc |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/recipes/u-boot/u-boot.inc b/recipes/u-boot/u-boot.inc
> > index 88c6a4d..ffd1e1e 100644
> > --- a/recipes/u-boot/u-boot.inc
> > +++ b/recipes/u-boot/u-boot.inc
> > @@ -16,6 +16,7 @@ UBOOT_MACHINE ?= "${MACHINE}_config"
> >  UBOOT_BINARY ?= "u-boot.bin"
> >  UBOOT_IMAGE ?= "u-boot-${MACHINE}-${PV}-${PR}.bin"
> >  UBOOT_SYMLINK ?= "u-boot-${MACHINE}.bin"
> > +UBOOT_MAKE_TARGET ?= "all"
> >
> >  do_configure () {
> >  	oe_runmake ${UBOOT_MACHINE}
> > @@ -25,7 +26,7 @@ do_compile () {
> >  	unset LDFLAGS
> >  	unset CFLAGS
> >  	unset CPPFLAGS
> > -	oe_runmake all
> > +	oe_runmake ${UBOOT_MAKE_TARGET}
> >  	oe_runmake tools env HOSTCC="${CC}"
> >  }
> >
> > --
> > 1.7.0.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/recipes/u-boot/u-boot.inc b/recipes/u-boot/u-boot.inc
index 88c6a4d..ffd1e1e 100644
--- a/recipes/u-boot/u-boot.inc
+++ b/recipes/u-boot/u-boot.inc
@@ -16,6 +16,7 @@  UBOOT_MACHINE ?= "${MACHINE}_config"
 UBOOT_BINARY ?= "u-boot.bin"
 UBOOT_IMAGE ?= "u-boot-${MACHINE}-${PV}-${PR}.bin"
 UBOOT_SYMLINK ?= "u-boot-${MACHINE}.bin"
+UBOOT_MAKE_TARGET ?= "all"
 
 do_configure () {
 	oe_runmake ${UBOOT_MACHINE}
@@ -25,7 +26,7 @@  do_compile () {
 	unset LDFLAGS
 	unset CFLAGS
 	unset CPPFLAGS
-	oe_runmake all
+	oe_runmake ${UBOOT_MAKE_TARGET}
 	oe_runmake tools env HOSTCC="${CC}"
 }