Patchwork package_ipk: There is no longer any need to force owners/groups to root

login
register
mail settings
Submitter Richard Purdie
Date Nov. 1, 2011, 2:25 p.m.
Message ID <1320157543.15387.8.camel@ted>
Download mbox | patch
Permalink /patch/14129/
State Accepted
Commit ea11f71432e2741d5f8c7cecec41c6155db34393
Headers show

Comments

Richard Purdie - Nov. 1, 2011, 2:25 p.m.
Since the packaging process is run under pseudo, the default user
is now root so there is no longer any need to hardcode this. Also
take this opportunity to move the variable to package_ipk.bbclass
since this is the only user of it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Koen Kooi - Nov. 1, 2011, 2:42 p.m.
Op 1 nov. 2011, om 15:25 heeft Richard Purdie het volgende geschreven:

> Since the packaging process is run under pseudo, the default user
> is now root so there is no longer any need to hardcode this. Also
> take this opportunity to move the variable to package_ipk.bbclass
> since this is the only user of it.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Acked-by: Koen Kooi <k-kooi@ti.com>

> ---
> diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass
> index c0893a6..c97e36e 100644
> --- a/meta/classes/package_ipk.bbclass
> +++ b/meta/classes/package_ipk.bbclass
> @@ -7,6 +7,9 @@ IPKGCONF_SDK =  "${WORKDIR}/opkg-sdk.conf"
> 
> PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
> 
> +# Program to be used to build opkg packages
> +OPKGBUILDCMD ??= "opkg-build"
> +
> python package_ipk_fn () {
> 	bb.data.setVar('PKGFN', bb.data.getVar('PKG',d), d)
> }
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index e2c1b6f..0d05805 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -623,10 +623,6 @@ MKTEMPCMD = "mktemp -q ${TMPBASE}"
> 
> export PATCH_GET="0"
> 
> -# Program to be used to build opkg packages
> -
> -OPKGBUILDCMD = "opkg-build -o 0 -g 0"
> -
> ##################################################################
> # Not sure about the rest of this yet.
> ##################################################################
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass
index c0893a6..c97e36e 100644
--- a/meta/classes/package_ipk.bbclass
+++ b/meta/classes/package_ipk.bbclass
@@ -7,6 +7,9 @@  IPKGCONF_SDK =  "${WORKDIR}/opkg-sdk.conf"
 
 PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
 
+# Program to be used to build opkg packages
+OPKGBUILDCMD ??= "opkg-build"
+
 python package_ipk_fn () {
 	bb.data.setVar('PKGFN', bb.data.getVar('PKG',d), d)
 }
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index e2c1b6f..0d05805 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -623,10 +623,6 @@  MKTEMPCMD = "mktemp -q ${TMPBASE}"
 
 export PATCH_GET="0"
 
-# Program to be used to build opkg packages
-
-OPKGBUILDCMD = "opkg-build -o 0 -g 0"
-
 ##################################################################
 # Not sure about the rest of this yet.
 ##################################################################