Patchwork [angstrom-layers] u-boot.inc: allow variable make targets

login
register
mail settings
Submitter chase maupin
Date March 15, 2011, 1:30 p.m.
Message ID <1300195841-21137-1-git-send-email-Chase.Maupin@ti.com>
Download mbox | patch
Permalink /patch/1411/
State New, archived
Headers show

Comments

chase maupin - March 15, 2011, 1:30 p.m.
* Later versions of u-boot sometimes have top level make targets
  such as u-boot.imx, u-boot.kwb, and for upcoming TI devices
  u-boot.ti.
* These targets define different calls to the mkimage tool to
  change the images created, such as changing the load address.
* This change allows recipes to change the default make target
  of "all" to something like u-boot.ti or u-boot.imx by setting
  the UBOOT_MAKE_TARGET variable.

Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
 BSP/TI/recipes-bsp/u-boot/u-boot.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Koen Kooi - March 15, 2011, 4:34 p.m.
Op 15 mrt 2011, om 14:30 heeft Chase Maupin het volgende geschreven:

> * Later versions of u-boot sometimes have top level make targets
>  such as u-boot.imx, u-boot.kwb, and for upcoming TI devices
>  u-boot.ti.
> * These targets define different calls to the mkimage tool to
>  change the images created, such as changing the load address.
> * This change allows recipes to change the default make target
>  of "all" to something like u-boot.ti or u-boot.imx by setting
>  the UBOOT_MAKE_TARGET variable.
> 
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
> BSP/TI/recipes-bsp/u-boot/u-boot.inc |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)

Thanks, pushed to angstrom-layers master.
Tom Rini - March 15, 2011, 9:04 p.m.
On 03/15/2011 09:34 AM, Koen Kooi wrote:
>
> Op 15 mrt 2011, om 14:30 heeft Chase Maupin het volgende geschreven:
>
>> * Later versions of u-boot sometimes have top level make targets
>>   such as u-boot.imx, u-boot.kwb, and for upcoming TI devices
>>   u-boot.ti.
>> * These targets define different calls to the mkimage tool to
>>   change the images created, such as changing the load address.
>> * This change allows recipes to change the default make target
>>   of "all" to something like u-boot.ti or u-boot.imx by setting
>>   the UBOOT_MAKE_TARGET variable.
>>
>> Signed-off-by: Chase Maupin<Chase.Maupin@ti.com>
>> ---
>> BSP/TI/recipes-bsp/u-boot/u-boot.inc |    3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> Thanks, pushed to angstrom-layers master.

Anyone have an opinion about for oe-core itself?
Koen Kooi - March 15, 2011, 9:37 p.m.
imo it can go in. I'll look at the differences between oe-core and angstrom-layers later.

Op 15 mrt. 2011 om 22:04 heeft Tom Rini <tom_rini@mentor.com> het volgende geschreven:

> On 03/15/2011 09:34 AM, Koen Kooi wrote:
>> 
>> Op 15 mrt 2011, om 14:30 heeft Chase Maupin het volgende geschreven:
>> 
>>> * Later versions of u-boot sometimes have top level make targets
>>>  such as u-boot.imx, u-boot.kwb, and for upcoming TI devices
>>>  u-boot.ti.
>>> * These targets define different calls to the mkimage tool to
>>>  change the images created, such as changing the load address.
>>> * This change allows recipes to change the default make target
>>>  of "all" to something like u-boot.ti or u-boot.imx by setting
>>>  the UBOOT_MAKE_TARGET variable.
>>> 
>>> Signed-off-by: Chase Maupin<Chase.Maupin@ti.com>
>>> ---
>>> BSP/TI/recipes-bsp/u-boot/u-boot.inc |    3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>> 
>> Thanks, pushed to angstrom-layers master.
> 
> Anyone have an opinion about for oe-core itself?
> 
> -- 
> Tom Rini
> Mentor Graphics Corporation
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/BSP/TI/recipes-bsp/u-boot/u-boot.inc b/BSP/TI/recipes-bsp/u-boot/u-boot.inc
index 3859a4c..3a9a72f 100644
--- a/BSP/TI/recipes-bsp/u-boot/u-boot.inc
+++ b/BSP/TI/recipes-bsp/u-boot/u-boot.inc
@@ -18,6 +18,7 @@  UBOOT_MACHINE ?= "${MACHINE}_config"
 UBOOT_BINARY ?= "u-boot.bin"
 UBOOT_IMAGE ?= "u-boot-${MACHINE}-${PV}-${PR}.bin"
 UBOOT_SYMLINK ?= "u-boot-${MACHINE}.bin"
+UBOOT_MAKE_TARGET ?= "all"
 
 do_configure () {
 	oe_runmake ${UBOOT_MACHINE}
@@ -27,7 +28,7 @@  do_compile () {
 	unset LDFLAGS
 	unset CFLAGS
 	unset CPPFLAGS
-	oe_runmake all
+	oe_runmake ${UBOOT_MAKE_TARGET}
 	oe_runmake tools env
 }