diff mbox series

runqemu: Fix gl-es argument from causing other arguments to be ignored

Message ID 20221021145311.52133-1-JPEWhacker@gmail.com
State Accepted, archived
Commit 718bb8d56f6a24c86e67830a7d13af54df2ebb4e
Headers show
Series runqemu: Fix gl-es argument from causing other arguments to be ignored | expand

Commit Message

Joshua Watt Oct. 21, 2022, 2:53 p.m. UTC
The code to parse arguments was inadvertently skipping all arguments in
the elif block after gl-es if it was specified on the command line.

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 scripts/runqemu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joshua Watt Oct. 26, 2022, 2:08 p.m. UTC | #1
Steve,

Please backport this to kirkstone at your convenience.

Thanks

On Fri, Oct 21, 2022 at 9:53 AM Joshua Watt <jpewhacker@gmail.com> wrote:
>
> The code to parse arguments was inadvertently skipping all arguments in
> the elif block after gl-es if it was specified on the command line.
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>  scripts/runqemu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 983f7514c7..189fc3da91 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -497,7 +497,7 @@ class BaseConfig(object):
>                  self.gtk = True
>              elif arg == 'gl':
>                  self.gl = True
> -            elif 'gl-es' in sys.argv[1:]:
> +            elif arg == 'gl-es':
>                  self.gl_es = True
>              elif arg == 'egl-headless':
>                  self.egl_headless = True
> --
> 2.33.0
>
diff mbox series

Patch

diff --git a/scripts/runqemu b/scripts/runqemu
index 983f7514c7..189fc3da91 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -497,7 +497,7 @@  class BaseConfig(object):
                 self.gtk = True
             elif arg == 'gl':
                 self.gl = True
-            elif 'gl-es' in sys.argv[1:]:
+            elif arg == 'gl-es':
                 self.gl_es = True
             elif arg == 'egl-headless':
                 self.egl_headless = True