| Submitter | Andreas Müller |
|---|---|
| Date | Oct. 30, 2011, 10:01 a.m. |
| Message ID | <1319968917-3120-2-git-send-email-schnitzeltony@gmx.de> |
| Download | mbox | patch |
| Permalink | /patch/14033/ |
| State | Rejected |
| Headers | show |
Comments
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 30-10-11 11:01, Andreas Müller schreef: > > Signed-off-by: Andreas Müller <schnitzeltony@gmx.de> --- > meta-oe/recipes-core/tasks/task-basic.bb | 2 +- 1 files changed, 1 > insertions(+), 1 deletions(-) > > diff --git a/meta-oe/recipes-core/tasks/task-basic.bb > b/meta-oe/recipes-core/tasks/task-basic.bb index 34aa7e1..9b9385e 100644 > --- a/meta-oe/recipes-core/tasks/task-basic.bb +++ > b/meta-oe/recipes-core/tasks/task-basic.bb @@ -51,7 +51,7 @@ > RRECOMMENDS_${PN} = "\ ${@base_contains("MACHINE_FEATURES", "usbgadget", > "kernel-module-g-ether kernel-module-g-serial > kernel-module-g-mass-storage", "", d)} \ \ > ${@base_contains("DISTRO_FEATURES", "bluetooth", "bluez4", "", d)} \ - > ${@base_contains("DISTRO_FEATURES", "wifi", "iw wpa-supplicant", "", d)} > \ + ${@base_contains("DISTRO_FEATURES", "wifi", "iw wireless-tools > wpa-supplicant", "", d)} \ I have to NAK this one, 'iw' has replaced wireless in the linux-wireless world and having both doesn't make sense. regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) Comment: GPGTools - http://gpgtools.org iD8DBQFOrnugMkyGM64RGpERAlz9AKCVmZKrR98wxQ0X7sbVtlpJCeXlmACfba2v 9kKB7H1D6OrM2DgxRWmiyLg= =R97K -----END PGP SIGNATURE-----
On Monday, October 31, 2011 11:42:40 AM Koen Kooi wrote: > Op 30-10-11 11:01, Andreas Müller schreef: > > Signed-off-by: Andreas Müller <schnitzeltony@gmx.de> --- > > meta-oe/recipes-core/tasks/task-basic.bb | 2 +- 1 files changed, 1 > > insertions(+), 1 deletions(-) > > > > diff --git a/meta-oe/recipes-core/tasks/task-basic.bb > > b/meta-oe/recipes-core/tasks/task-basic.bb index 34aa7e1..9b9385e 100644 > > --- a/meta-oe/recipes-core/tasks/task-basic.bb +++ > > b/meta-oe/recipes-core/tasks/task-basic.bb @@ -51,7 +51,7 @@ > > RRECOMMENDS_${PN} = "\ ${@base_contains("MACHINE_FEATURES", "usbgadget", > > "kernel-module-g-ether kernel-module-g-serial > > kernel-module-g-mass-storage", "", d)} \ \ > > ${@base_contains("DISTRO_FEATURES", "bluetooth", "bluez4", "", d)} \ - > > ${@base_contains("DISTRO_FEATURES", "wifi", "iw wpa-supplicant", "", d)} > > \ + ${@base_contains("DISTRO_FEATURES", "wifi", "iw wireless-tools > > wpa-supplicant", "", d)} \ > > I have to NAK this one, 'iw' has replaced wireless in the linux-wireless > world and having both doesn't make sense. > I had the feeling (am not 100% sure), that adding wireless-tools to image made my wlan work under networkmanger control - will do some tests on that. FYI: networkmanager has wireless-tools in DEPENDS but that is not enough to make wireless-tools into the image. How about wireless-tools in RDEPENDS for networkmanager? Andreas
On Monday, October 31, 2011 12:10:28 PM Andreas Müller wrote: > On Monday, October 31, 2011 11:42:40 AM Koen Kooi wrote: > > Op 30-10-11 11:01, Andreas Müller schreef: > > > Signed-off-by: Andreas Müller <schnitzeltony@gmx.de> --- > > > meta-oe/recipes-core/tasks/task-basic.bb | 2 +- 1 files changed, 1 > > > insertions(+), 1 deletions(-) > > > > > > diff --git a/meta-oe/recipes-core/tasks/task-basic.bb > > > b/meta-oe/recipes-core/tasks/task-basic.bb index 34aa7e1..9b9385e > > > 100644 --- a/meta-oe/recipes-core/tasks/task-basic.bb +++ > > > b/meta-oe/recipes-core/tasks/task-basic.bb @@ -51,7 +51,7 @@ > > > RRECOMMENDS_${PN} = "\ ${@base_contains("MACHINE_FEATURES", > > > "usbgadget", "kernel-module-g-ether kernel-module-g-serial > > > kernel-module-g-mass-storage", "", d)} \ \ > > > ${@base_contains("DISTRO_FEATURES", "bluetooth", "bluez4", "", d)} \ - > > > ${@base_contains("DISTRO_FEATURES", "wifi", "iw wpa-supplicant", "", > > > d)} \ + ${@base_contains("DISTRO_FEATURES", "wifi", "iw wireless-tools > > > wpa-supplicant", "", d)} \ > > > > I have to NAK this one, 'iw' has replaced wireless in the linux-wireless > > world and having both doesn't make sense. > > I had the feeling (am not 100% sure), that adding wireless-tools to image > made my wlan work under networkmanger control - will do some tests on > that. > > FYI: networkmanager has wireless-tools in DEPENDS but that is not enough to > make wireless-tools into the image. > > How about wireless-tools in RDEPENDS for networkmanager? > I took a look at networkmanager configure.ac: | AC_MSG_ERROR(wireless-tools or libiw development headers >= 28pre9 not installed or not functional) I seems better to have iw in dependencies there instead of wireless-tools. Will give that one a try. Andreas
On Monday, October 31, 2011 12:17:28 PM Andreas Müller wrote: > On Monday, October 31, 2011 12:10:28 PM Andreas Müller wrote: > > On Monday, October 31, 2011 11:42:40 AM Koen Kooi wrote: > > > Op 30-10-11 11:01, Andreas Müller schreef: > > > > Signed-off-by: Andreas Müller <schnitzeltony@gmx.de> --- > > > > meta-oe/recipes-core/tasks/task-basic.bb | 2 +- 1 files changed, 1 > > > > insertions(+), 1 deletions(-) > > > > > > > > diff --git a/meta-oe/recipes-core/tasks/task-basic.bb > > > > b/meta-oe/recipes-core/tasks/task-basic.bb index 34aa7e1..9b9385e > > > > 100644 --- a/meta-oe/recipes-core/tasks/task-basic.bb +++ > > > > b/meta-oe/recipes-core/tasks/task-basic.bb @@ -51,7 +51,7 @@ > > > > RRECOMMENDS_${PN} = "\ ${@base_contains("MACHINE_FEATURES", > > > > "usbgadget", "kernel-module-g-ether kernel-module-g-serial > > > > kernel-module-g-mass-storage", "", d)} \ \ > > > > ${@base_contains("DISTRO_FEATURES", "bluetooth", "bluez4", "", d)} \ > > > > - ${@base_contains("DISTRO_FEATURES", "wifi", "iw wpa-supplicant", > > > > "", d)} \ + ${@base_contains("DISTRO_FEATURES", "wifi", "iw > > > > wireless-tools wpa-supplicant", "", d)} \ > > > > > > I have to NAK this one, 'iw' has replaced wireless in the > > > linux-wireless world and having both doesn't make sense. > > > > I had the feeling (am not 100% sure), that adding wireless-tools to image > > made my wlan work under networkmanger control - will do some tests on > > that. > > > > FYI: networkmanager has wireless-tools in DEPENDS but that is not enough > > to make wireless-tools into the image. > > > > How about wireless-tools in RDEPENDS for networkmanager? > > I took a look at networkmanager configure.ac: > | AC_MSG_ERROR(wireless-tools or libiw development headers >= 28pre9 not > > installed or not functional) > > I seems better to have iw in dependencies there instead of wireless-tools. > Will give that one a try. > For maiden image wlan works without change / wireless-tools. Sorry for the noise. Andreas
Patch
diff --git a/meta-oe/recipes-core/tasks/task-basic.bb b/meta-oe/recipes-core/tasks/task-basic.bb index 34aa7e1..9b9385e 100644 --- a/meta-oe/recipes-core/tasks/task-basic.bb +++ b/meta-oe/recipes-core/tasks/task-basic.bb @@ -51,7 +51,7 @@ RRECOMMENDS_${PN} = "\ ${@base_contains("MACHINE_FEATURES", "usbgadget", "kernel-module-g-ether kernel-module-g-serial kernel-module-g-mass-storage", "", d)} \ \ ${@base_contains("DISTRO_FEATURES", "bluetooth", "bluez4", "", d)} \ - ${@base_contains("DISTRO_FEATURES", "wifi", "iw wpa-supplicant", "", d)} \ + ${@base_contains("DISTRO_FEATURES", "wifi", "iw wireless-tools wpa-supplicant", "", d)} \ \ tzdata \ \
Signed-off-by: Andreas Müller <schnitzeltony@gmx.de> --- meta-oe/recipes-core/tasks/task-basic.bb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)