| Submitter | Julian Pidancet |
|---|---|
| Date | Oct. 25, 2011, 1:18 a.m. |
| Message ID | <1319505532-23199-2-git-send-email-julian.pidancet@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/13841/ |
| State | New, archived |
| Headers | show |
Comments
On Mon, Oct 24, 2011 at 8:18 PM, Julian Pidancet <julian.pidancet@gmail.com> wrote: > +do_configure_prepend () { > + export fu_cv_sys_stat_statfs2_bsize=yes I'm asking out of curiosity.. why don't these go in meta/site/common instead? -M
On Wed, Oct 26, 2011 at 2:59 AM, McClintock Matthew-B29882 <B29882@freescale.com> wrote: > On Mon, Oct 24, 2011 at 8:18 PM, Julian Pidancet > <julian.pidancet@gmail.com> wrote: >> +do_configure_prepend () { >> + export fu_cv_sys_stat_statfs2_bsize=yes > > I'm asking out of curiosity.. why don't these go in meta/site/common instead? To be honest, I ignored the very existence of this file. Is this globally applied to all the recipes ? Isn't there a risk of breaking other packages by doing this ?
On Wed, 2011-10-26 at 14:58 +0100, Julian Pidancet wrote: > On Wed, Oct 26, 2011 at 2:59 AM, McClintock Matthew-B29882 > <B29882@freescale.com> wrote: > > On Mon, Oct 24, 2011 at 8:18 PM, Julian Pidancet > > <julian.pidancet@gmail.com> wrote: > >> +do_configure_prepend () { > >> + export fu_cv_sys_stat_statfs2_bsize=yes > > > > I'm asking out of curiosity.. why don't these go in meta/site/common instead? > > To be honest, I ignored the very existence of this file. Is this > globally applied to all the recipes ? Isn't there a risk of breaking > other packages by doing this ? A small risk, yes. On the other hand, by hardcoding one particular value in the recipe, there is a risk that it might be the wrong answer for some target systems. Whereas the site files are, intentionally, target and OS specific. p.
Patch
diff --git a/meta/recipes-core/coreutils/coreutils_8.14.bb b/meta/recipes-core/coreutils/coreutils_8.14.bb index f3b7af7..3c75ddf 100644 --- a/meta/recipes-core/coreutils/coreutils_8.14.bb +++ b/meta/recipes-core/coreutils/coreutils_8.14.bb @@ -27,7 +27,7 @@ bindir_progs = "base64 basename chcon cksum comm csplit cut dir dircolors dirnam join link logname md5sum mkfifo mktemp nice nl nohup nproc od paste pathchk \ pinky pr printenv printf ptx readlink runcon seq sha1sum sha224sum sha256sum \ sha384sum sha512sum shred shuf sort split stat stdbuf sum tac tail tee test timeout\ - tr truncate tsort tty unexpand uniq unlink uptime users vdir wc who whoami yes" + tr truncate tsort tty unexpand uniq unlink uptime users vdir wc who whoami yes df" # hostname gets a special treatment and is not included in this base_bindir_progs = "cat chgrp chmod chown cp date dd echo false kill ln ls mkdir \ @@ -35,6 +35,10 @@ base_bindir_progs = "cat chgrp chmod chown cp date dd echo false kill ln ls mkdi sbindir_progs= "chroot" +do_configure_prepend () { + export fu_cv_sys_stat_statfs2_bsize=yes +} + do_install_append() { for i in ${bindir_progs}; do mv ${D}${bindir}/$i ${D}${bindir}/$i.${PN}; done
The coreutils configure script is unable determine how to get free space from the Operating System when cross-compiling. This patch gives it some extra help by setting the fu_cv_sys_stat_statfs2_bsize variable to yes before invoking the configure script. Signed-off-by: Julian Pidancet <julian.pidancet@gmail.com> --- meta/recipes-core/coreutils/coreutils_8.14.bb | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)