Patchwork [meta-oe] memtester: Import from OE classic

login
register
mail settings
Submitter Joel A Fernandes
Date Oct. 24, 2011, 3:40 a.m.
Message ID <1319427652-9401-1-git-send-email-joelagnel@ti.com>
Download mbox | patch
Permalink /patch/13809/
State Accepted
Commit 5da48e6e4a4ab0488943c5e93f005211bd7a22f7
Headers show

Comments

Joel A Fernandes - Oct. 24, 2011, 3:40 a.m.
Added LIC_FILES_CHKSUM

Signed-off-by: Joel A Fernandes <joelagnel@ti.com>
---
This package is required by the beaglebone-tester

 .../memtester/files/Makefile.patch                 |   15 +++++++++++
 .../recipes-benchmark/memtester/memtester_4.1.3.bb |   27 ++++++++++++++++++++
 2 files changed, 42 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-benchmark/memtester/files/Makefile.patch
 create mode 100644 meta-oe/recipes-benchmark/memtester/memtester_4.1.3.bb
Paul Menzel - Oct. 24, 2011, 8:05 a.m.
Koen,


could you please wait at least a day until merging the patches to get
time for proper review.


Am Sonntag, den 23.10.2011, 22:40 -0500 schrieb Joel A Fernandes:

Joel, when importing recipes please add the corresponding commit ID too
as required by the commit guide lines [1].

> Added LIC_FILES_CHKSUM
> 
> Signed-off-by: Joel A Fernandes <joelagnel@ti.com>
> ---
> This package is required by the beaglebone-tester
> 
>  .../memtester/files/Makefile.patch                 |   15 +++++++++++
>  .../recipes-benchmark/memtester/memtester_4.1.3.bb |   27 ++++++++++++++++++++
>  2 files changed, 42 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-benchmark/memtester/files/Makefile.patch
>  create mode 100644 meta-oe/recipes-benchmark/memtester/memtester_4.1.3.bb
> 
> diff --git a/meta-oe/recipes-benchmark/memtester/files/Makefile.patch b/meta-oe/recipes-benchmark/memtester/files/Makefile.patch
> new file mode 100644
> index 0000000..57a0464
> --- /dev/null
> +++ b/meta-oe/recipes-benchmark/memtester/files/Makefile.patch

Please add a patch header.

> @@ -0,0 +1,15 @@
> +Index: memtester-4.0.5/Makefile
> +===================================================================
> +--- memtester-4.0.5.orig/Makefile	2005-03-14 06:02:30.000000000 -0800
> ++++ memtester-4.0.5/Makefile	2006-07-08 23:53:42.000000000 -0700
> +@@ -24,8 +24,8 @@
> + auto-ccld.sh: \
> + conf-cc conf-ld warn-auto.sh
> + 	( cat warn-auto.sh; \
> +-	echo CC=\'`head -1 conf-cc`\'; \
> +-	echo LD=\'`head -1 conf-ld`\' \
> ++	echo CC=\'`head -n 1 conf-cc`\'; \
> ++	echo LD=\'`head -n 1 conf-ld`\' \
> + 	) > auto-ccld.sh
> + 
> + compile: \
> diff --git a/meta-oe/recipes-benchmark/memtester/memtester_4.1.3.bb b/meta-oe/recipes-benchmark/memtester/memtester_4.1.3.bb
> new file mode 100644
> index 0000000..9f4e53e
> --- /dev/null
> +++ b/meta-oe/recipes-benchmark/memtester/memtester_4.1.3.bb
> @@ -0,0 +1,27 @@
> +SECTION = "console/utils"
> +DESCRIPTION = "Utility to test for faulty memory subsystem"
> +LICENSE = "GPLv2"

The ordering is wrong and the field `HOMEPAGE` is missing [3].

> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
> +
> +SRC_URI = "http://pyropus.ca/software/memtester/old-versions/memtester-${PV}.tar.gz"
> +SRC_URI += "file://Makefile.patch"
> +
> +SRC_URI[md5sum] = "e562451620cf5343016950462bc0dc38"
> +SRC_URI[sha256sum] = "ac56f0b6d6d6e58bcf2a3fa7f2c9b29894f5177871f21115a1906c535106acf6"
> +
> +S = "${WORKDIR}/memtester-${PV}"

This is the default.

> +
> +do_compile () {
> +	echo '${CC} ${CFLAGS} -DPOSIX -c' > conf-cc
> +	echo '${CC} ${LDFLAGS}' > conf-ld
> +	oe_runmake
> +}
> +
> +do_install () {
> +	install -d ${D}${bindir}
> +	install -d ${D}${mandir}/man8
> +	install -m 0755 memtester ${D}${bindir}/
> +	install -m 0755 memtester.8 ${D}${mandir}/man8/
> +}
> +

No empty line at the end is needed.

I fixed some of the above in OE classic. Please fix the issues mentioned
above in meta-oe with follow-up patches.


Thanks,

Paul


[1] http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Importing_from_Elsewhere
[2] http://git.openembedded.org/openembedded/tree/recipes/memtester?id=07e215db9870db1a0f88edb328024781eb9ac852
[3] http://wiki.openembedded.org/index.php/Styleguide
Joel A Fernandes - Oct. 24, 2011, 7:01 p.m.
Hi Paul,

On Mon, Oct 24, 2011 at 3:05 AM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
..
> I fixed some of the above in OE classic. Please fix the issues mentioned
> above in meta-oe with follow-up patches.

Thanks for your review comments, I'll work on resubmitting a new patch
today with the suggested changes.

Regards,
Joel
Paul Menzel - Oct. 24, 2011, 7:13 p.m.
Dear Joel,


Am Montag, den 24.10.2011, 14:01 -0500 schrieb Joel A Fernandes:

> On Mon, Oct 24, 2011 at 3:05 AM, Paul Menzel wrote:
> ..
> > I fixed some of the above in OE classic. Please fix the issues mentioned
> > above in meta-oe with follow-up patches.
> 
> Thanks for your review comments, I'll work on resubmitting a new patch
> today with the suggested changes.

please note that your patch was already pushed so resubmitting is not
needed and just a follow up patch.


Thanks,

Paul

Patch

diff --git a/meta-oe/recipes-benchmark/memtester/files/Makefile.patch b/meta-oe/recipes-benchmark/memtester/files/Makefile.patch
new file mode 100644
index 0000000..57a0464
--- /dev/null
+++ b/meta-oe/recipes-benchmark/memtester/files/Makefile.patch
@@ -0,0 +1,15 @@ 
+Index: memtester-4.0.5/Makefile
+===================================================================
+--- memtester-4.0.5.orig/Makefile	2005-03-14 06:02:30.000000000 -0800
++++ memtester-4.0.5/Makefile	2006-07-08 23:53:42.000000000 -0700
+@@ -24,8 +24,8 @@
+ auto-ccld.sh: \
+ conf-cc conf-ld warn-auto.sh
+ 	( cat warn-auto.sh; \
+-	echo CC=\'`head -1 conf-cc`\'; \
+-	echo LD=\'`head -1 conf-ld`\' \
++	echo CC=\'`head -n 1 conf-cc`\'; \
++	echo LD=\'`head -n 1 conf-ld`\' \
+ 	) > auto-ccld.sh
+ 
+ compile: \
diff --git a/meta-oe/recipes-benchmark/memtester/memtester_4.1.3.bb b/meta-oe/recipes-benchmark/memtester/memtester_4.1.3.bb
new file mode 100644
index 0000000..9f4e53e
--- /dev/null
+++ b/meta-oe/recipes-benchmark/memtester/memtester_4.1.3.bb
@@ -0,0 +1,27 @@ 
+SECTION = "console/utils"
+DESCRIPTION = "Utility to test for faulty memory subsystem"
+LICENSE = "GPLv2"
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
+
+SRC_URI = "http://pyropus.ca/software/memtester/old-versions/memtester-${PV}.tar.gz"
+SRC_URI += "file://Makefile.patch"
+
+SRC_URI[md5sum] = "e562451620cf5343016950462bc0dc38"
+SRC_URI[sha256sum] = "ac56f0b6d6d6e58bcf2a3fa7f2c9b29894f5177871f21115a1906c535106acf6"
+
+S = "${WORKDIR}/memtester-${PV}"
+
+do_compile () {
+	echo '${CC} ${CFLAGS} -DPOSIX -c' > conf-cc
+	echo '${CC} ${LDFLAGS}' > conf-ld
+	oe_runmake
+}
+
+do_install () {
+	install -d ${D}${bindir}
+	install -d ${D}${mandir}/man8
+	install -m 0755 memtester ${D}${bindir}/
+	install -m 0755 memtester.8 ${D}${mandir}/man8/
+}
+