Patchwork [CONSOLIDATED,PULL,11/27] pulseaudio-0.9.23: inherit perlnative to work around build on host without XML/Parser.pm

login
register
mail settings
Submitter Saul Wold
Date Oct. 23, 2011, 6:26 p.m.
Message ID <6038b7e0961ca4aec70cc6de8adbc79567500e2b.1319394187.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/13769/
State New, archived
Headers show

Comments

Saul Wold - Oct. 23, 2011, 6:26 p.m.
From: Martin Jansa <Martin.Jansa@gmail.com>

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 .../pulseaudio/pulseaudio_0.9.23.bb                |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Richard Purdie - Oct. 24, 2011, 1:15 p.m.
On Sun, 2011-10-23 at 11:26 -0700, Saul Wold wrote:
> From: Martin Jansa <Martin.Jansa@gmail.com>
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  .../pulseaudio/pulseaudio_0.9.23.bb                |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> index 33f5e15..4ac2418 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> @@ -4,7 +4,7 @@ PR = "r5"
>  
>  DEPENDS += "gdbm speex"
>  
> -inherit gettext
> +inherit gettext perlnative

This doesn't look right. If we need xmlparser, we should state that in
DEPENDS. If that is added to DEPENDS, I'm not sure we still need the
inherit of perlnative?

Cheers,

Richard
Koen Kooi - Oct. 24, 2011, 1:19 p.m.
Op 24 okt. 2011, om 15:15 heeft Richard Purdie het volgende geschreven:

> On Sun, 2011-10-23 at 11:26 -0700, Saul Wold wrote:
>> From: Martin Jansa <Martin.Jansa@gmail.com>
>> 
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> ---
>> .../pulseaudio/pulseaudio_0.9.23.bb                |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
>> index 33f5e15..4ac2418 100644
>> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
>> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
>> @@ -4,7 +4,7 @@ PR = "r5"
>> 
>> DEPENDS += "gdbm speex"
>> 
>> -inherit gettext
>> +inherit gettext perlnative
> 
> This doesn't look right. If we need xmlparser, we should state that in
> DEPENDS. If that is added to DEPENDS, I'm not sure we still need the
> inherit of perlnative?

If you need xmlparser during the build you almost always need the perlnative wrapper as well :(

regards,

Koen
Martin Jansa - Oct. 24, 2011, 1:24 p.m.
On Mon, Oct 24, 2011 at 02:15:57PM +0100, Richard Purdie wrote:
> On Sun, 2011-10-23 at 11:26 -0700, Saul Wold wrote:
> > From: Martin Jansa <Martin.Jansa@gmail.com>
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  .../pulseaudio/pulseaudio_0.9.23.bb                |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > index 33f5e15..4ac2418 100644
> > --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > @@ -4,7 +4,7 @@ PR = "r5"
> >  
> >  DEPENDS += "gdbm speex"
> >  
> > -inherit gettext
> > +inherit gettext perlnative
> 
> This doesn't look right. If we need xmlparser, we should state that in
> DEPENDS. If that is added to DEPENDS, I'm not sure we still need the
> inherit of perlnative?

Yes I've forgot to put it in DEPENDS, khem sent version where he is
adding this inherit and DEPENDs..

but both are needed and only work arounds because build is calling perl
(not env perl) and perlnative helps to put perl from perl-native before
perl from host in PATH.

Reported here:
http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/011323.html

And I've sent this as work around before I'll fill oe-core bug report or
someone updates it to 1.1 and maybe fix it too.

Regards,
Richard Purdie - Oct. 24, 2011, 2:15 p.m.
On Mon, 2011-10-24 at 15:19 +0200, Koen Kooi wrote:
> Op 24 okt. 2011, om 15:15 heeft Richard Purdie het volgende geschreven:
> 
> > On Sun, 2011-10-23 at 11:26 -0700, Saul Wold wrote:
> >> From: Martin Jansa <Martin.Jansa@gmail.com>
> >> 
> >> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >> ---
> >> .../pulseaudio/pulseaudio_0.9.23.bb                |    2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >> 
> >> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> >> index 33f5e15..4ac2418 100644
> >> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> >> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> >> @@ -4,7 +4,7 @@ PR = "r5"
> >> 
> >> DEPENDS += "gdbm speex"
> >> 
> >> -inherit gettext
> >> +inherit gettext perlnative
> > 
> > This doesn't look right. If we need xmlparser, we should state that in
> > DEPENDS. If that is added to DEPENDS, I'm not sure we still need the
> > inherit of perlnative?
> 
> If you need xmlparser during the build you almost always need the
> perlnative wrapper as well :(

I was under the impression that we'd fixed most of those issues :/. It
could well be a valid dependency in this case so I'll take the patch
with the added DEPENDS.

Cheers,

Richard
Richard Purdie - Oct. 24, 2011, 2:19 p.m.
On Mon, 2011-10-24 at 15:24 +0200, Martin Jansa wrote:
> On Mon, Oct 24, 2011 at 02:15:57PM +0100, Richard Purdie wrote:
> > On Sun, 2011-10-23 at 11:26 -0700, Saul Wold wrote:
> > > From: Martin Jansa <Martin.Jansa@gmail.com>
> > > 
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > >  .../pulseaudio/pulseaudio_0.9.23.bb                |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > > index 33f5e15..4ac2418 100644
> > > --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > > +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > > @@ -4,7 +4,7 @@ PR = "r5"
> > >  
> > >  DEPENDS += "gdbm speex"
> > >  
> > > -inherit gettext
> > > +inherit gettext perlnative
> > 
> > This doesn't look right. If we need xmlparser, we should state that in
> > DEPENDS. If that is added to DEPENDS, I'm not sure we still need the
> > inherit of perlnative?
> 
> Yes I've forgot to put it in DEPENDS, khem sent version where he is
> adding this inherit and DEPENDs..
> 
> but both are needed and only work arounds because build is calling perl
> (not env perl) and perlnative helps to put perl from perl-native before
> perl from host in PATH.
> 
> Reported here:
> http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/011323.html
> 
> And I've sent this as work around before I'll fill oe-core bug report or
> someone updates it to 1.1 and maybe fix it too.

I've taken Khem's version of this so that should help address this
problem.

Cheers,

Richard
Martin Jansa - Oct. 24, 2011, 2:24 p.m.
On Mon, Oct 24, 2011 at 03:15:07PM +0100, Richard Purdie wrote:
> On Mon, 2011-10-24 at 15:19 +0200, Koen Kooi wrote:
> > Op 24 okt. 2011, om 15:15 heeft Richard Purdie het volgende geschreven:
> > 
> > > On Sun, 2011-10-23 at 11:26 -0700, Saul Wold wrote:
> > >> From: Martin Jansa <Martin.Jansa@gmail.com>
> > >> 
> > >> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > >> ---
> > >> .../pulseaudio/pulseaudio_0.9.23.bb                |    2 +-
> > >> 1 files changed, 1 insertions(+), 1 deletions(-)
> > >> 
> > >> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > >> index 33f5e15..4ac2418 100644
> > >> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > >> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > >> @@ -4,7 +4,7 @@ PR = "r5"
> > >> 
> > >> DEPENDS += "gdbm speex"
> > >> 
> > >> -inherit gettext
> > >> +inherit gettext perlnative
> > > 
> > > This doesn't look right. If we need xmlparser, we should state that in
> > > DEPENDS. If that is added to DEPENDS, I'm not sure we still need the
> > > inherit of perlnative?
> > 
> > If you need xmlparser during the build you almost always need the
> > perlnative wrapper as well :(
> 
> I was under the impression that we'd fixed most of those issues :/. It
> could well be a valid dependency in this case so I'll take the patch
> with the added DEPENDS.

Those were imho transitive deps from intltool, that's why this is a bit
different.

Cheers,

Patch

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
index 33f5e15..4ac2418 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
@@ -4,7 +4,7 @@  PR = "r5"
 
 DEPENDS += "gdbm speex"
 
-inherit gettext
+inherit gettext perlnative
 
 SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/pulseaudio-${PV}.tar.gz \
   file://buildfix.patch \