Patchwork [3/4] slugos: prefer busybox 1.18.4

login
register
mail settings
Submitter Eric BENARD
Date March 13, 2011, 4:57 p.m.
Message ID <1300035425-15984-3-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/1357/
State Accepted
Headers show

Comments

Eric BENARD - March 13, 2011, 4:57 p.m.
Signed-off-by: Eric Bénard <eric@eukrea.com>
Cc: Mike Westerhof <mike@mwester.net>
---
 conf/distro/include/preferred-slugos-versions.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Mike Westerhof - March 14, 2011, 2:40 a.m.
On 3/13/2011 11:57 AM, Eric Bénard wrote:
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> Cc: Mike Westerhof <mike@mwester.net>

Acked-by: Mike Westerhof <mike@mwester.net>

> ---
>  conf/distro/include/preferred-slugos-versions.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/conf/distro/include/preferred-slugos-versions.inc b/conf/distro/include/preferred-slugos-versions.inc
> index b1b3255..b864dac 100644
> --- a/conf/distro/include/preferred-slugos-versions.inc
> +++ b/conf/distro/include/preferred-slugos-versions.inc
> @@ -24,7 +24,7 @@ PREFERRED_VERSION_autoconf			?= "2.65"
>  PREFERRED_VERSION_autoconf-native		?= "2.65"
>  PREFERRED_VERSION_automake			?= "1.11.1"
>  PREFERRED_VERSION_automake-native		?= "1.11.1"
> -PREFERRED_VERSION_busybox			?= "1.18.3"
> +PREFERRED_VERSION_busybox			?= "1.18.4"
>  PREFERRED_VERSION_dbus				?= "1.4.1"
>  PREFERRED_VERSION_glib-2.0			?= "2.26.1"
>  PREFERRED_VERSION_glib-2.0-native		?= "2.26.1"
Marcin Juszkiewicz - March 14, 2011, 8:51 a.m.
Dnia 2011-03-13, nie o godzinie 17:57 +0100, Eric Bénard pisze:
> --- a/conf/distro/include/preferred-slugos-versions.inc
> +++ b/conf/distro/include/preferred-slugos-versions.inc
> @@ -24,7 +24,7 @@ PREFERRED_VERSION_autoconf                    ?=
> "2.65"
>  PREFERRED_VERSION_autoconf-native              ?= "2.65"
>  PREFERRED_VERSION_automake                     ?= "1.11.1"
>  PREFERRED_VERSION_automake-native              ?= "1.11.1"
> -PREFERRED_VERSION_busybox                      ?= "1.18.3"
> +PREFERRED_VERSION_busybox                      ?= "1.18.4" 

Can't it be handled by DEFAULT_PREFERENCE_slugos = "1" in
busybox_1.18.4.bb recipe? Less reparsing.
Eric BENARD - March 14, 2011, 9:41 a.m.
Hi Marcin,

On 14/03/2011 09:51, Marcin Juszkiewicz wrote:
> Dnia 2011-03-13, nie o godzinie 17:57 +0100, Eric Bénard pisze:
>> --- a/conf/distro/include/preferred-slugos-versions.inc
>> +++ b/conf/distro/include/preferred-slugos-versions.inc
>> @@ -24,7 +24,7 @@ PREFERRED_VERSION_autoconf                    ?=
>> "2.65"
>>   PREFERRED_VERSION_autoconf-native              ?= "2.65"
>>   PREFERRED_VERSION_automake                     ?= "1.11.1"
>>   PREFERRED_VERSION_automake-native              ?= "1.11.1"
>> -PREFERRED_VERSION_busybox                      ?= "1.18.3"
>> +PREFERRED_VERSION_busybox                      ?= "1.18.4"
>
> Can't it be handled by DEFAULT_PREFERENCE_slugos = "1" in
> busybox_1.18.4.bb recipe? Less reparsing.
>
that is a distro choice so if distro want to track the latest stable busybox, 
they can remove this PREFERRED_VERSION_busybox line and the latest stable 
version will be used as a default.
For next version I'll use a 1.19 PV and will only increase PR when fixes are 
added, that will make less changes in the preferred-versions.inc files.

Eric

Patch

diff --git a/conf/distro/include/preferred-slugos-versions.inc b/conf/distro/include/preferred-slugos-versions.inc
index b1b3255..b864dac 100644
--- a/conf/distro/include/preferred-slugos-versions.inc
+++ b/conf/distro/include/preferred-slugos-versions.inc
@@ -24,7 +24,7 @@  PREFERRED_VERSION_autoconf			?= "2.65"
 PREFERRED_VERSION_autoconf-native		?= "2.65"
 PREFERRED_VERSION_automake			?= "1.11.1"
 PREFERRED_VERSION_automake-native		?= "1.11.1"
-PREFERRED_VERSION_busybox			?= "1.18.3"
+PREFERRED_VERSION_busybox			?= "1.18.4"
 PREFERRED_VERSION_dbus				?= "1.4.1"
 PREFERRED_VERSION_glib-2.0			?= "2.26.1"
 PREFERRED_VERSION_glib-2.0-native		?= "2.26.1"