| Submitter | Otavio Salvador |
|---|---|
| Date | Oct. 19, 2011, 3:35 p.m. |
| Message ID | <790990daa702e1ca0c4688b0c45d2fd95c4ed0eb.1319038482.git.otavio@ossystems.com.br> |
| Download | mbox | patch |
| Permalink | /patch/13545/ |
| State | Accepted |
| Commit | e8bc57581191cf9181a1b5dd207559b259c87db6 |
| Headers | show |
Comments
Dear Otavio,
Am Mittwoch, den 19.10.2011, 15:35 +0000 schrieb Otavio Salvador:
your Signed-off-by line is missing. Additionally please describe your
changes in the commit message [1].
In this case
udev_173: Package all systemd files in udev-systemd
should be good.
Is that change just cosmetic or does it yield a (big?) size reduction of
package `udev`?
> ---
> meta-oe/recipes-core/udev/udev_173.bb | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/meta-oe/recipes-core/udev/udev_173.bb b/meta-oe/recipes-core/udev/udev_173.bb
> index 56ebb77..e4e634a 100644
> --- a/meta-oe/recipes-core/udev/udev_173.bb
> +++ b/meta-oe/recipes-core/udev/udev_173.bb
> @@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
> # Needed for udev-extras
> DEPENDS = "gperf-native usbutils acl glib-2.0"
>
> -PR = "r1"
> +PR = "r2"
>
> # version specific SRC_URI
> SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz \
> @@ -61,7 +61,8 @@ INITSCRIPT_PARAMS = "start 04 S ."
>
> PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit"
>
> -FILES_${PN}-systemd = "${base_libdir}/systemd/system/"
> +FILES_${PN}-systemd = "${base_libdir}/systemd"
> +RDEPENDS_${PN}-systemd += "udev"
>
> FILES_libudev = "${base_libdir}/libudev.so.*"
> FILES_libgudev = "${base_libdir}/libgudev*.so.*"
> @@ -82,9 +83,6 @@ FILES_${PN}-dbg += "/lib/udev/.debug"
> FILES_${PN}-consolekit += "${libdir}/ConsoleKit"
> RDEPENDS_${PN}-consolekit += "consolekit"
>
> -# Package up systemd files
> -FILES_${PN} += "${base_libdir}/systemd"
> -
> do_install () {
> install -d ${D}${usrsbindir} \
> ${D}${sbindir}
Thanks,
Paul
[1] http://openembedded.org/wiki/Commit_Patch_Message_Guidelines
Patch
diff --git a/meta-oe/recipes-core/udev/udev_173.bb b/meta-oe/recipes-core/udev/udev_173.bb index 56ebb77..e4e634a 100644 --- a/meta-oe/recipes-core/udev/udev_173.bb +++ b/meta-oe/recipes-core/udev/udev_173.bb @@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \ # Needed for udev-extras DEPENDS = "gperf-native usbutils acl glib-2.0" -PR = "r1" +PR = "r2" # version specific SRC_URI SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz \ @@ -61,7 +61,8 @@ INITSCRIPT_PARAMS = "start 04 S ." PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit" -FILES_${PN}-systemd = "${base_libdir}/systemd/system/" +FILES_${PN}-systemd = "${base_libdir}/systemd" +RDEPENDS_${PN}-systemd += "udev" FILES_libudev = "${base_libdir}/libudev.so.*" FILES_libgudev = "${base_libdir}/libgudev*.so.*" @@ -82,9 +83,6 @@ FILES_${PN}-dbg += "/lib/udev/.debug" FILES_${PN}-consolekit += "${libdir}/ConsoleKit" RDEPENDS_${PN}-consolekit += "consolekit" -# Package up systemd files -FILES_${PN} += "${base_libdir}/systemd" - do_install () { install -d ${D}${usrsbindir} \ ${D}${sbindir}