Patchwork [0/1] Fix race while building external modules

login
mail settings
Submitter Anders Darander
Date Oct. 19, 2011, 11:14 a.m.
Message ID <cover.1319022793.git.anders@chargestorm.se>
Download mbox
Permalink /patch/13531/
State Accepted
Headers show

Pull-request

git://github.com/darander/oe-core ext-mod-race

Comments

Anders Darander - Oct. 19, 2011, 11:14 a.m.
When building an image with several external modules, a race is likely to
occur. This race is when building scripts in the staged kernel tree (sysroot).

To prevent this, we promote the do_make_scripts() function to a task, which we
protect by a lock. Tip on how to make this work was received by Richard in
[1]. To avoid new problems, introduced by this promotion, we make this new
task depend on do_populate_sysroot from the modules dependencies
(i.e. virtual/kernel).

This patch has been extensively tested on the 2011-1 release branch, on a
custom ARM-machine and distro with several external modules.

[1] http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/011163.html

The following changes since commit e31dd9b65f3b03f79cabab25eca157532de3bd9c:

  fontconfig: fix fix-pkgconfig.patch (2011-10-18 18:13:47 +0100)

are available in the git repository at:
  git://github.com/darander/oe-core ext-mod-race
  https://github.com/darander/oe-core/tree/ext-mod-race

Anders Darander (1):
  module.bbclass: add lock to prevent error bulding ext modules

 meta/classes/module.bbclass |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Saul Wold - Oct. 20, 2011, 5:17 p.m.
On 10/19/2011 04:15 AM, Anders Darander wrote:
>
> When building an image with several external modules, a race is likely to
> occur. This race is when building scripts in the staged kernel tree (sysroot).
>
> To prevent this, we promote the do_make_scripts() function to a task, which we
> protect by a lock. Tip on how to make this work was received by Richard in
> [1]. To avoid new problems, introduced by this promotion, we make this new
> task depend on do_populate_sysroot from the modules dependencies
> (i.e. virtual/kernel).
>
> This patch has been extensively tested on the 2011-1 release branch, on a
> custom ARM-machine and distro with several external modules.
>
> [1] http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/011163.html
>
> The following changes since commit e31dd9b65f3b03f79cabab25eca157532de3bd9c:
>
>    fontconfig: fix fix-pkgconfig.patch (2011-10-18 18:13:47 +0100)
>
> are available in the git repository at:
>    git://github.com/darander/oe-core ext-mod-race
>    https://github.com/darander/oe-core/tree/ext-mod-race
>
> Anders Darander (1):
>    module.bbclass: add lock to prevent error bulding ext modules
>
>   meta/classes/module.bbclass |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)
>
Merged into OE-Core

Thanks
	Sau!