Patchwork [05/11] udev (165): move ConsoleKit support to udev-consolekit package

login
register
mail settings
Submitter Otavio Salvador
Date March 12, 2011, 7:27 p.m.
Message ID <1299958038-25216-6-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/1343/
State New, archived
Headers show

Comments

Otavio Salvador - March 12, 2011, 7:27 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes/udev/udev_165.bb |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
Otavio Salvador - March 12, 2011, 8:21 p.m.
On Sat, Mar 12, 2011 at 16:27, Otavio Salvador <otavio@ossystems.com.br> wrote:
...
> -PACKAGES =+ "libudev libgudev udev-utils"
> +PACKAGES =+ "libudev libgudev udev-utils udev-consolekit"
...

Koen, can you take a look on this change?

It seems Angstrom is the only used of this version and seems better to
not provide support for consolekit by default so adding it as
recommends or suggests seems wrong to me.
Otavio Salvador - March 14, 2011, 12:33 p.m.
On Sat, Mar 12, 2011 at 19:03, Koen Kooi <koen@beagleboard.org> wrote:
> If someone can quickly explain me what it does then we can see what needs to get changed. Without having looked into it I think adding RRECOMMENDS_${PN} += "udev-consolekit" to the consolekit recipe should fix most possible breakage.

I think it manages to register the 'seat' on consolekit. So I think
this would solve this issue.

> Adding oe-core to CC:
>
> What are the plans in oe-core for udev? There currently is a recipe overlayed in meta-oe because I haven't had time to look into the differences between the oe-dev and oe-core version. If we're going to touch udev we might as well do it properly :)

I think 165 ought to be our base there.
Otavio Salvador - March 22, 2011, 3:23 p.m.
On Sat, Mar 12, 2011 at 16:27, Otavio Salvador <otavio@ossystems.com.br> wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

ping?

Patch

diff --git a/recipes/udev/udev_165.bb b/recipes/udev/udev_165.bb
index 63e62f1..9605cb3 100644
--- a/recipes/udev/udev_165.bb
+++ b/recipes/udev/udev_165.bb
@@ -3,7 +3,7 @@  DESCRIPTION = "udev is a daemon which dynamically creates and removes device nod
 the hotplug package and requires a kernel not older than 2.6.12."
 LICENSE = "GPLv2+"
 
-PR = "r3"
+PR = "r4"
 
 # Untested
 DEFAULT_PREFERENCE = "-1"
@@ -71,7 +71,7 @@  EXTRA_OECONF += " --with-udev-prefix= \
 INITSCRIPT_NAME = "udev"
 INITSCRIPT_PARAMS = "start 03 S ."
 
-PACKAGES =+ "libudev libgudev udev-utils"
+PACKAGES =+ "libudev libgudev udev-utils udev-consolekit"
 
 FILES_libudev = "${base_libdir}/libudev.so.*"
 FILES_libgudev = "${base_libdir}/libgudev*.so.*"
@@ -84,7 +84,8 @@  FILES_${PN}-dbg += "${usrbindir}/.debug ${usrsbindir}/.debug"
 
 # udev installs binaries under $(udev_prefix)/lib/udev, even if ${libdir}
 # is ${prefix}/lib64
-FILES_${PN} += "/lib/udev* ${libdir}/ConsoleKit"
+FILES_${PN} += "/lib/udev*"
+FILES_${PN}-consokekit += "${libdir}/ConsoleKit"
 FILES_${PN}-dbg += "/lib/udev/.debug"
 
 RPROVIDES_udev_append = " udev-compat-wrapper"