Patchwork [2/5] gmp: also generate the libgmpcxx library

login
register
mail settings
Submitter Nitin A Kamble
Date Oct. 18, 2011, 8:14 p.m.
Message ID <09731abe1a3295426dfef8d54c52c7f6805fe5dc.1318968860.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/13427/
State New, archived
Headers show

Comments

Nitin A Kamble - Oct. 18, 2011, 8:14 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-support/gmp/gmp.inc      |    2 ++
 meta/recipes-support/gmp/gmp_4.2.1.bb |    2 +-
 meta/recipes-support/gmp/gmp_5.0.2.bb |    2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)
Khem Raj - Oct. 18, 2011, 8:53 p.m.
On (18/10/11 13:14), nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-support/gmp/gmp.inc      |    2 ++
>  meta/recipes-support/gmp/gmp_4.2.1.bb |    2 +-
>  meta/recipes-support/gmp/gmp_5.0.2.bb |    2 +-
>  3 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-support/gmp/gmp.inc b/meta/recipes-support/gmp/gmp.inc
> index 66349e6..77ce10d 100644
> --- a/meta/recipes-support/gmp/gmp.inc
> +++ b/meta/recipes-support/gmp/gmp.inc
> @@ -14,3 +14,5 @@ ARM_INSTRUCTION_SET = "arm"
>  acpaths = ""
>  
>  BBCLASSEXTEND = "native nativesdk"
> +
> +EXTRA_OECONF += " --enable-cxx=yes"

if you want 'yes' then just --enable-cxx is enough have you tried with
--enable-cxx=detect that would make sure that C++ compiler and runtime
is ok. Secondly is this option needed for native recipes too ?

> diff --git a/meta/recipes-support/gmp/gmp_4.2.1.bb b/meta/recipes-support/gmp/gmp_4.2.1.bb
> index 74da6b8..97ac4b2 100644
> --- a/meta/recipes-support/gmp/gmp_4.2.1.bb
> +++ b/meta/recipes-support/gmp/gmp_4.2.1.bb
> @@ -6,7 +6,7 @@ LICENSE = "LGPLv2.1+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=892f569a555ba9c07a568a7c0c4fa63a \
>                      file://COPYING.LIB;md5=fbc093901857fcd118f065f900982c24 \
>                      file://gmp-h.in;startline=6;endline=21;md5=5e25ffd16996faba8c1cd27b04b16099"
> -PR = "r0"
> +PR = "r1"
>  
>  SRC_URI = "${GNU_MIRROR}/gmp/${BP}.tar.bz2 \
>             file://disable-stdc.patch"
> diff --git a/meta/recipes-support/gmp/gmp_5.0.2.bb b/meta/recipes-support/gmp/gmp_5.0.2.bb
> index 03fef45..f80971e 100644
> --- a/meta/recipes-support/gmp/gmp_5.0.2.bb
> +++ b/meta/recipes-support/gmp/gmp_5.0.2.bb
> @@ -2,7 +2,7 @@ require gmp.inc
>  LICENSE="LGPLv3&GPLv3"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
>  		    file://version.c;endline=18;md5=d8c56b52b9092346b9f93b4da65ef790"
> -PR = "r0"
> +PR = "r1"
>  
>  SRC_URI_append += "file://sh4-asmfix.patch \
>                     file://use-includedir.patch "
> -- 
> 1.7.4.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Nitin A Kamble - Oct. 18, 2011, 9:06 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Khem Raj
> Sent: Tuesday, October 18, 2011 1:54 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 2/5] gmp: also generate the libgmpcxx
> library
> 
> On (18/10/11 13:14), nitin.a.kamble@intel.com wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  meta/recipes-support/gmp/gmp.inc      |    2 ++
> >  meta/recipes-support/gmp/gmp_4.2.1.bb |    2 +-
> >  meta/recipes-support/gmp/gmp_5.0.2.bb |    2 +-
> >  3 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-support/gmp/gmp.inc b/meta/recipes-
> support/gmp/gmp.inc
> > index 66349e6..77ce10d 100644
> > --- a/meta/recipes-support/gmp/gmp.inc
> > +++ b/meta/recipes-support/gmp/gmp.inc
> > @@ -14,3 +14,5 @@ ARM_INSTRUCTION_SET = "arm"
> >  acpaths = ""
> >
> >  BBCLASSEXTEND = "native nativesdk"
> > +
> > +EXTRA_OECONF += " --enable-cxx=yes"
> 
> if you want 'yes' then just --enable-cxx is enough have you tried with
> --enable-cxx=detect that would make sure that C++ compiler and runtime
> is ok. Secondly is this option needed for native recipes too ?

Thanks Khem for your comments. This option is also needed for native recipe to avoid having gmp-devel installed on the build system. "--enable-cxx=detect" can be used, but I am not sure if it is the best way yet, I think we always have c++ as part of gcc, not having c++ is not a case to worry. And if "detect" tests if c++ & runtime are not working as expected, then it should not disable the enable-cxx option with that reason; better would be to get a recipe build failure. So I still favor keeping the option as "--enable-cxx" until I can see the merit of "detect".

Thanks,
Nitin

> 
> > diff --git a/meta/recipes-support/gmp/gmp_4.2.1.bb b/meta/recipes-
> support/gmp/gmp_4.2.1.bb
> > index 74da6b8..97ac4b2 100644
> > --- a/meta/recipes-support/gmp/gmp_4.2.1.bb
> > +++ b/meta/recipes-support/gmp/gmp_4.2.1.bb
> > @@ -6,7 +6,7 @@ LICENSE = "LGPLv2.1+"
> >  LIC_FILES_CHKSUM =
> "file://COPYING;md5=892f569a555ba9c07a568a7c0c4fa63a \
> >
> file://COPYING.LIB;md5=fbc093901857fcd118f065f900982c24 \
> >                      file://gmp-
> h.in;startline=6;endline=21;md5=5e25ffd16996faba8c1cd27b04b16099"
> > -PR = "r0"
> > +PR = "r1"
> >
> >  SRC_URI = "${GNU_MIRROR}/gmp/${BP}.tar.bz2 \
> >             file://disable-stdc.patch"
> > diff --git a/meta/recipes-support/gmp/gmp_5.0.2.bb b/meta/recipes-
> support/gmp/gmp_5.0.2.bb
> > index 03fef45..f80971e 100644
> > --- a/meta/recipes-support/gmp/gmp_5.0.2.bb
> > +++ b/meta/recipes-support/gmp/gmp_5.0.2.bb
> > @@ -2,7 +2,7 @@ require gmp.inc
> >  LICENSE="LGPLv3&GPLv3"
> >  LIC_FILES_CHKSUM =
> "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
> >
> file://version.c;endline=18;md5=d8c56b52b9092346b9f93b4da65ef790"
> > -PR = "r0"
> > +PR = "r1"
> >
> >  SRC_URI_append += "file://sh4-asmfix.patch \
> >                     file://use-includedir.patch "
> > --
> > 1.7.4.4
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> --
> -Khem
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - Oct. 18, 2011, 9:13 p.m.
On (18/10/11 14:06), Kamble, Nitin A wrote:
> 
> 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Khem Raj
> > Sent: Tuesday, October 18, 2011 1:54 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 2/5] gmp: also generate the libgmpcxx
> > library
> > 
> > On (18/10/11 13:14), nitin.a.kamble@intel.com wrote:
> > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > >
> > > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > ---
> > >  meta/recipes-support/gmp/gmp.inc      |    2 ++
> > >  meta/recipes-support/gmp/gmp_4.2.1.bb |    2 +-
> > >  meta/recipes-support/gmp/gmp_5.0.2.bb |    2 +-
> > >  3 files changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta/recipes-support/gmp/gmp.inc b/meta/recipes-
> > support/gmp/gmp.inc
> > > index 66349e6..77ce10d 100644
> > > --- a/meta/recipes-support/gmp/gmp.inc
> > > +++ b/meta/recipes-support/gmp/gmp.inc
> > > @@ -14,3 +14,5 @@ ARM_INSTRUCTION_SET = "arm"
> > >  acpaths = ""
> > >
> > >  BBCLASSEXTEND = "native nativesdk"
> > > +
> > > +EXTRA_OECONF += " --enable-cxx=yes"
> > 
> > if you want 'yes' then just --enable-cxx is enough have you tried with
> > --enable-cxx=detect that would make sure that C++ compiler and runtime
> > is ok. Secondly is this option needed for native recipes too ?
> 
> Thanks Khem for your comments. This option is also needed for native recipe to avoid having gmp-devel installed on the build system. "--enable-cxx=detect" can be used, but I am not sure if it is the best way yet, I think we always have c++ as part of gcc, not having c++ is not a case to worry. And if "detect" tests if c++ & runtime are not working as expected, then it should not disable the enable-cxx option with that reason; better would be to get a recipe build failure. So I still favor keeping the option as "--enable-cxx" until I can see the merit of "detect".

detect can make sure that compilers are working as it expects them to
be. so likely less issues when it is used later.

> 
> Thanks,
> Nitin
> 
> > 
> > > diff --git a/meta/recipes-support/gmp/gmp_4.2.1.bb b/meta/recipes-
> > support/gmp/gmp_4.2.1.bb
> > > index 74da6b8..97ac4b2 100644
> > > --- a/meta/recipes-support/gmp/gmp_4.2.1.bb
> > > +++ b/meta/recipes-support/gmp/gmp_4.2.1.bb
> > > @@ -6,7 +6,7 @@ LICENSE = "LGPLv2.1+"
> > >  LIC_FILES_CHKSUM =
> > "file://COPYING;md5=892f569a555ba9c07a568a7c0c4fa63a \
> > >
> > file://COPYING.LIB;md5=fbc093901857fcd118f065f900982c24 \
> > >                      file://gmp-
> > h.in;startline=6;endline=21;md5=5e25ffd16996faba8c1cd27b04b16099"
> > > -PR = "r0"
> > > +PR = "r1"
> > >
> > >  SRC_URI = "${GNU_MIRROR}/gmp/${BP}.tar.bz2 \
> > >             file://disable-stdc.patch"
> > > diff --git a/meta/recipes-support/gmp/gmp_5.0.2.bb b/meta/recipes-
> > support/gmp/gmp_5.0.2.bb
> > > index 03fef45..f80971e 100644
> > > --- a/meta/recipes-support/gmp/gmp_5.0.2.bb
> > > +++ b/meta/recipes-support/gmp/gmp_5.0.2.bb
> > > @@ -2,7 +2,7 @@ require gmp.inc
> > >  LICENSE="LGPLv3&GPLv3"
> > >  LIC_FILES_CHKSUM =
> > "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
> > >
> > file://version.c;endline=18;md5=d8c56b52b9092346b9f93b4da65ef790"
> > > -PR = "r0"
> > > +PR = "r1"
> > >
> > >  SRC_URI_append += "file://sh4-asmfix.patch \
> > >                     file://use-includedir.patch "
> > > --
> > > 1.7.4.4
> > >
> > >
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> > 
> > --
> > -Khem
> > 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Nitin A Kamble - Oct. 19, 2011, 12:06 a.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Khem Raj
> Sent: Tuesday, October 18, 2011 2:14 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 2/5] gmp: also generate the libgmpcxx
> library
> 
> On (18/10/11 14:06), Kamble, Nitin A wrote:
> >
> >
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org
> > > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of
> > > Khem Raj
> > > Sent: Tuesday, October 18, 2011 1:54 PM
> > > To: Patches and discussions about the oe-core layer
> > > Subject: Re: [OE-core] [PATCH 2/5] gmp: also generate the libgmpcxx
> > > library
> > >
> > > On (18/10/11 13:14), nitin.a.kamble@intel.com wrote:
> > > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > >
> > > > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > > ---
> > > >  meta/recipes-support/gmp/gmp.inc      |    2 ++
> > > >  meta/recipes-support/gmp/gmp_4.2.1.bb |    2 +-
> > > >  meta/recipes-support/gmp/gmp_5.0.2.bb |    2 +-
> > > >  3 files changed, 4 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/meta/recipes-support/gmp/gmp.inc b/meta/recipes-
> > > support/gmp/gmp.inc
> > > > index 66349e6..77ce10d 100644
> > > > --- a/meta/recipes-support/gmp/gmp.inc
> > > > +++ b/meta/recipes-support/gmp/gmp.inc
> > > > @@ -14,3 +14,5 @@ ARM_INSTRUCTION_SET = "arm"
> > > >  acpaths = ""
> > > >
> > > >  BBCLASSEXTEND = "native nativesdk"
> > > > +
> > > > +EXTRA_OECONF += " --enable-cxx=yes"
> > >
> > > if you want 'yes' then just --enable-cxx is enough have you tried
> with
> > > --enable-cxx=detect that would make sure that C++ compiler and
> runtime
> > > is ok. Secondly is this option needed for native recipes too ?
> >
> > Thanks Khem for your comments. This option is also needed for native
> recipe to avoid having gmp-devel installed on the build system. "--
> enable-cxx=detect" can be used, but I am not sure if it is the best way
> yet, I think we always have c++ as part of gcc, not having c++ is not a
> case to worry. And if "detect" tests if c++ & runtime are not working
> as expected, then it should not disable the enable-cxx option with that
> reason; better would be to get a recipe build failure. So I still favor
> keeping the option as "--enable-cxx" until I can see the merit of
> "detect".
> 
> detect can make sure that compilers are working as it expects them to
> be. so likely less issues when it is used later.

Khem,
  When detect fails then configure will get an error, and will not proceed with disabling cxx, so that is good.

# If --enable-cxx=yes but a C++ compiler can't be found, then abort.
  if test $want_cxx = no && test $enable_cxx = yes; then
    as_fn_error $? "C++ compiler not available, see config.log for details" "$LINENO" 5
  fi

Thanks,
Nitin


> 
> >
> > Thanks,
> > Nitin
> >
> > >
> > > > diff --git a/meta/recipes-support/gmp/gmp_4.2.1.bb
> b/meta/recipes-
> > > support/gmp/gmp_4.2.1.bb
> > > > index 74da6b8..97ac4b2 100644
> > > > --- a/meta/recipes-support/gmp/gmp_4.2.1.bb
> > > > +++ b/meta/recipes-support/gmp/gmp_4.2.1.bb
> > > > @@ -6,7 +6,7 @@ LICENSE = "LGPLv2.1+"
> > > >  LIC_FILES_CHKSUM =
> > > "file://COPYING;md5=892f569a555ba9c07a568a7c0c4fa63a \
> > > >
> > > file://COPYING.LIB;md5=fbc093901857fcd118f065f900982c24 \
> > > >                      file://gmp-
> > > h.in;startline=6;endline=21;md5=5e25ffd16996faba8c1cd27b04b16099"
> > > > -PR = "r0"
> > > > +PR = "r1"
> > > >
> > > >  SRC_URI = "${GNU_MIRROR}/gmp/${BP}.tar.bz2 \
> > > >             file://disable-stdc.patch"
> > > > diff --git a/meta/recipes-support/gmp/gmp_5.0.2.bb
> b/meta/recipes-
> > > support/gmp/gmp_5.0.2.bb
> > > > index 03fef45..f80971e 100644
> > > > --- a/meta/recipes-support/gmp/gmp_5.0.2.bb
> > > > +++ b/meta/recipes-support/gmp/gmp_5.0.2.bb
> > > > @@ -2,7 +2,7 @@ require gmp.inc
> > > >  LICENSE="LGPLv3&GPLv3"
> > > >  LIC_FILES_CHKSUM =
> > > "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
> > > >
> > > file://version.c;endline=18;md5=d8c56b52b9092346b9f93b4da65ef790"
> > > > -PR = "r0"
> > > > +PR = "r1"
> > > >
> > > >  SRC_URI_append += "file://sh4-asmfix.patch \
> > > >                     file://use-includedir.patch "
> > > > --
> > > > 1.7.4.4
> > > >
> > > >
> > > > _______________________________________________
> > > > Openembedded-core mailing list
> > > > Openembedded-core@lists.openembedded.org
> > > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-
> core
> > >
> > > --
> > > -Khem
> > >
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-
> core
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> --
> -Khem
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-support/gmp/gmp.inc b/meta/recipes-support/gmp/gmp.inc
index 66349e6..77ce10d 100644
--- a/meta/recipes-support/gmp/gmp.inc
+++ b/meta/recipes-support/gmp/gmp.inc
@@ -14,3 +14,5 @@  ARM_INSTRUCTION_SET = "arm"
 acpaths = ""
 
 BBCLASSEXTEND = "native nativesdk"
+
+EXTRA_OECONF += " --enable-cxx=yes"
diff --git a/meta/recipes-support/gmp/gmp_4.2.1.bb b/meta/recipes-support/gmp/gmp_4.2.1.bb
index 74da6b8..97ac4b2 100644
--- a/meta/recipes-support/gmp/gmp_4.2.1.bb
+++ b/meta/recipes-support/gmp/gmp_4.2.1.bb
@@ -6,7 +6,7 @@  LICENSE = "LGPLv2.1+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=892f569a555ba9c07a568a7c0c4fa63a \
                     file://COPYING.LIB;md5=fbc093901857fcd118f065f900982c24 \
                     file://gmp-h.in;startline=6;endline=21;md5=5e25ffd16996faba8c1cd27b04b16099"
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "${GNU_MIRROR}/gmp/${BP}.tar.bz2 \
            file://disable-stdc.patch"
diff --git a/meta/recipes-support/gmp/gmp_5.0.2.bb b/meta/recipes-support/gmp/gmp_5.0.2.bb
index 03fef45..f80971e 100644
--- a/meta/recipes-support/gmp/gmp_5.0.2.bb
+++ b/meta/recipes-support/gmp/gmp_5.0.2.bb
@@ -2,7 +2,7 @@  require gmp.inc
 LICENSE="LGPLv3&GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
 		    file://version.c;endline=18;md5=d8c56b52b9092346b9f93b4da65ef790"
-PR = "r0"
+PR = "r1"
 
 SRC_URI_append += "file://sh4-asmfix.patch \
                    file://use-includedir.patch "