Patchwork [meta-oe] ldconfig-native: Change the license field

login
register
mail settings
Submitter Khem Raj
Date Oct. 7, 2011, 5:39 p.m.
Message ID <1318009164-6677-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/12945/
State New, archived
Headers show

Comments

Khem Raj - Oct. 7, 2011, 5:39 p.m.
The license should be GPLv2+

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../recipes-core/eglibc/ldconfig-native_2.12.1.bb  |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Paul Menzel - Oct. 9, 2011, 10:11 p.m.
Am Freitag, den 07.10.2011, 10:39 -0700 schrieb Khem Raj:
> The license should be GPLv2+

Koen has already committed this in 2f04e069 [1].

I have to remarks.

1. Combining your commit summary and message to

    ldconfig-native Correct license field to GPLv2+

would be better next time. Especially if looking at the commit log with
`--format=oneline` or on the Web.

> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  .../recipes-core/eglibc/ldconfig-native_2.12.1.bb  |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb b/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
> index 00edb6e..2a93913 100644
> --- a/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
> +++ b/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "A standalone native ldconfig build"
>  
> -LICENSE = "GPLv2.1"
> +LICENSE = "GPLv2+"

[…]

2. Looking at the source headers of for example `cache.c`

           /* Copyright (C) 1999-2003,2005,2006,2007 Free Software Foundation, Inc.
           This file is part of the GNU C Library.
           Contributed by Andreas Jaeger <aj@suse.de>, 1999.
        
           This program is free software; you can redistribute it and/or modify
           it under the terms of the GNU General Public License as published
           by the Free Software Foundation; version 2 of the License, or
           (at your option) any later version.
        
           This program is distributed in the hope that it will be useful,
           but WITHOUT ANY WARRANTY; without even the implied warranty of
           MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
           GNU General Public License for more details.
        
           You should have received a copy of the GNU General Public License
           along with this program; if not, write to the Free Software Foundation,
           Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
        
the license is GPLv2+ as you changed it to. But in `readelflib.c` we have

           /* Copyright (C) 1999, 2000, 2001, 2002, 2007 Free Software Foundation, Inc.
           This file is part of the GNU C Library.
           Contributed by Andreas Jaeger <aj@suse.de>, 1999 and
        		  Jakub Jelinek <jakub@redhat.com>, 1999.
        
           The GNU C Library is free software; you can redistribute it and/or
           modify it under the terms of the GNU Lesser General Public
           License as published by the Free Software Foundation; either
           version 2.1 of the License, or (at your option) any later version.
        
           The GNU C Library is distributed in the hope that it will be useful,
           but WITHOUT ANY WARRANTY; without even the implied warranty of
           MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
           Lesser General Public License for more details.
        
           You should have received a copy of the GNU Lesser General Public
           License along with the GNU C Library; if not, write to the Free
           Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
           02111-1307 USA.  */
        
which is LGPLv2.1+. Also `dl-cache.c` has the `LGPLv2.1+` license header.

So should the field be changed to `LICENSE = "GPLv2+ LGPL"`?


Thanks,

Paul
Khem Raj - Oct. 10, 2011, 1:58 a.m.
On Sun, Oct 9, 2011 at 3:11 PM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> So should the field be changed to `LICENSE = "GPLv2+ LGPL"`?

GPLv2+ & LGPLv2.1+ would be ok however we do not generate packages
which are LGPL only
in this case.

Patch

diff --git a/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb b/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
index 00edb6e..2a93913 100644
--- a/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
+++ b/meta-oe/recipes-core/eglibc/ldconfig-native_2.12.1.bb
@@ -1,6 +1,6 @@ 
 DESCRIPTION = "A standalone native ldconfig build"
 
-LICENSE = "GPLv2.1"
+LICENSE = "GPLv2+"
 
 LIC_FILES_CHKSUM = "file://${S}/ldconfig.c;endline=17;md5=1d15f20937c055cb5de2329a4c054399"
 
@@ -12,7 +12,7 @@  SRC_URI = "file://ldconfig-native-2.12.1.tar.bz2 \
            file://flag_fix.patch \
            file://endianess-header.patch"
 
-PR = "r1"
+PR = "r2"
 
 inherit native