Patchwork [2/6] Fix perl for powerpc64 build

login
register
mail settings
Submitter Matthew McClintock
Date Oct. 4, 2011, 10:03 p.m.
Message ID <1317765787-19127-2-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/12755/
State New, archived
Headers show

Comments

Matthew McClintock - Oct. 4, 2011, 10:03 p.m.
Build environment for ARCH was set to powerpc on a powerpc64
build, this adds an override to set this to powerpc64 when
doing this type of build

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
No comments on original patch:

http://lists.linuxtogo.org/pipermail/openembedded-core/2011-September/010340.html

 meta/recipes-devtools/perl/perl_5.12.3.bb |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Richard Purdie - Oct. 5, 2011, 11:46 a.m.
On Tue, 2011-10-04 at 17:03 -0500, Matthew McClintock wrote:
> Build environment for ARCH was set to powerpc on a powerpc64
> build, this adds an override to set this to powerpc64 when
> doing this type of build
> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
> No comments on original patch:
> 
> http://lists.linuxtogo.org/pipermail/openembedded-core/2011-September/010340.html
> 
>  meta/recipes-devtools/perl/perl_5.12.3.bb |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/perl/perl_5.12.3.bb b/meta/recipes-devtools/perl/perl_5.12.3.bb
> index e4769a4..d1ac0e8 100644
> --- a/meta/recipes-devtools/perl/perl_5.12.3.bb
> +++ b/meta/recipes-devtools/perl/perl_5.12.3.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
>  # We need gnugrep (for -I)
>  DEPENDS = "virtual/db grep-native"
>  DEPENDS += "gdbm zlib"
> -PR = "r5"
> +PR = "r6"
>  
>  # 5.10.1 has Module::Build built-in
>  PROVIDES += "libmodule-build-perl"
> @@ -95,6 +95,8 @@ export LDDLFLAGS = "${LDFLAGS} -shared"
>  # We're almost Debian, aren't we?
>  CFLAGS += "-DDEBIAN"
>  
> +export ARCH_powerpc64 = "powerpc64"
> +

I'm finding it really hard to believe this makes any difference. I just
tried a powerpc64 build here and perl built fine. I can't find any
evidence for any part of the perl build using an ARCH variable
(TARGET_ARCH is used but that isn't ARCH).

Can you give some further information about how/where this is used?

>  do_nolargefile() {
>  	sed -i -e "s,\(uselargefiles=\)'define',\1'undef',g" \
>  		-e "s,\(d_readdir64_r=\)'define',\1'undef',g" \
> @@ -156,7 +158,7 @@ do_configure() {
>              config.sh-${TARGET_ARCH}-${TARGET_OS}
>  
>  	case "${TARGET_ARCH}" in
> -		x86_64 | powerpc | s390)
> +		x86_64 | powerpc | powerpc64 | s390)
>  			sed -i -e "s,\(need_va_copy=\)'undef',\1'define',g" \
>  				config.sh-${TARGET_ARCH}-${TARGET_OS}
>  			;;

This bit is fine...

Cheers,

Richard
McClintock Matthew-B29882 - Oct. 5, 2011, 7:04 p.m.
On Wed, Oct 5, 2011 at 6:46 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>> --- a/meta/recipes-devtools/perl/perl_5.12.3.bb
>> +++ b/meta/recipes-devtools/perl/perl_5.12.3.bb
>> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
>>  # We need gnugrep (for -I)
>>  DEPENDS = "virtual/db grep-native"
>>  DEPENDS += "gdbm zlib"
>> -PR = "r5"
>> +PR = "r6"
>>
>>  # 5.10.1 has Module::Build built-in
>>  PROVIDES += "libmodule-build-perl"
>> @@ -95,6 +95,8 @@ export LDDLFLAGS = "${LDFLAGS} -shared"
>>  # We're almost Debian, aren't we?
>>  CFLAGS += "-DDEBIAN"
>>
>> +export ARCH_powerpc64 = "powerpc64"
>> +
>
> I'm finding it really hard to believe this makes any difference. I just
> tried a powerpc64 build here and perl built fine. I can't find any
> evidence for any part of the perl build using an ARCH variable
> (TARGET_ARCH is used but that isn't ARCH).
>
> Can you give some further information about how/where this is used?

I'm trying to reproduce this again on 'edison' as well and it does not
appear to be occurring anymore! The problem before had to do with a
configuration script error:

config.sh-powerpc64-linux

This script was getting invoked as 'config.sh-powerpc-linux' on the
64bit build, then the file did not exist and the configure step failed
out. Not sure if this was somehow fixed in a different manner.

Please drop this patch for now. I'll bring it up again if I see issues.

-M
Richard Purdie - Oct. 7, 2011, 3:52 p.m.
On Wed, 2011-10-05 at 19:04 +0000, McClintock Matthew-B29882 wrote:
> On Wed, Oct 5, 2011 at 6:46 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >> --- a/meta/recipes-devtools/perl/perl_5.12.3.bb
> >> +++ b/meta/recipes-devtools/perl/perl_5.12.3.bb
> >> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
> >>  # We need gnugrep (for -I)
> >>  DEPENDS = "virtual/db grep-native"
> >>  DEPENDS += "gdbm zlib"
> >> -PR = "r5"
> >> +PR = "r6"
> >>
> >>  # 5.10.1 has Module::Build built-in
> >>  PROVIDES += "libmodule-build-perl"
> >> @@ -95,6 +95,8 @@ export LDDLFLAGS = "${LDFLAGS} -shared"
> >>  # We're almost Debian, aren't we?
> >>  CFLAGS += "-DDEBIAN"
> >>
> >> +export ARCH_powerpc64 = "powerpc64"
> >> +
> >
> > I'm finding it really hard to believe this makes any difference. I just
> > tried a powerpc64 build here and perl built fine. I can't find any
> > evidence for any part of the perl build using an ARCH variable
> > (TARGET_ARCH is used but that isn't ARCH).
> >
> > Can you give some further information about how/where this is used?
> 
> I'm trying to reproduce this again on 'edison' as well and it does not
> appear to be occurring anymore! The problem before had to do with a
> configuration script error:
> 
> config.sh-powerpc64-linux
> 
> This script was getting invoked as 'config.sh-powerpc-linux' on the
> 64bit build, then the file did not exist and the configure step failed
> out. Not sure if this was somehow fixed in a different manner.
> 
> Please drop this patch for now. I'll bring it up again if I see issues.

Do you still need this bit:

        case "${TARGET_ARCH}" in
-               x86_64 | powerpc | s390)
+               x86_64 | powerpc | powerpc64 | s390)
                        sed -i -e "s,\(need_va_copy=\)'undef',\1'define',g" \
                                config.sh-${TARGET_ARCH}-${TARGET_OS}
                        ;;

?

Cheers,

Richard
McClintock Matthew-B29882 - Oct. 7, 2011, 4:07 p.m.
On Fri, Oct 7, 2011 at 10:52 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Do you still need this bit:
>
>        case "${TARGET_ARCH}" in
> -               x86_64 | powerpc | s390)
> +               x86_64 | powerpc | powerpc64 | s390)
>                        sed -i -e "s,\(need_va_copy=\)'undef',\1'define',g" \
>                                config.sh-${TARGET_ARCH}-${TARGET_OS}
>                        ;;

Missing this does not seem to affect things negatively so far, I've
been build testing mostly though - will revisit this later if
something comes up.

-M

Patch

diff --git a/meta/recipes-devtools/perl/perl_5.12.3.bb b/meta/recipes-devtools/perl/perl_5.12.3.bb
index e4769a4..d1ac0e8 100644
--- a/meta/recipes-devtools/perl/perl_5.12.3.bb
+++ b/meta/recipes-devtools/perl/perl_5.12.3.bb
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
 # We need gnugrep (for -I)
 DEPENDS = "virtual/db grep-native"
 DEPENDS += "gdbm zlib"
-PR = "r5"
+PR = "r6"
 
 # 5.10.1 has Module::Build built-in
 PROVIDES += "libmodule-build-perl"
@@ -95,6 +95,8 @@  export LDDLFLAGS = "${LDFLAGS} -shared"
 # We're almost Debian, aren't we?
 CFLAGS += "-DDEBIAN"
 
+export ARCH_powerpc64 = "powerpc64"
+
 do_nolargefile() {
 	sed -i -e "s,\(uselargefiles=\)'define',\1'undef',g" \
 		-e "s,\(d_readdir64_r=\)'define',\1'undef',g" \
@@ -156,7 +158,7 @@  do_configure() {
             config.sh-${TARGET_ARCH}-${TARGET_OS}
 
 	case "${TARGET_ARCH}" in
-		x86_64 | powerpc | s390)
+		x86_64 | powerpc | powerpc64 | s390)
 			sed -i -e "s,\(need_va_copy=\)'undef',\1'define',g" \
 				config.sh-${TARGET_ARCH}-${TARGET_OS}
 			;;