| Submitter | Matthew McClintock |
|---|---|
| Date | Oct. 3, 2011, 11:39 p.m. |
| Message ID | <1317685187-9041-1-git-send-email-msm@freescale.com> |
| Download | mbox | patch |
| Permalink | /patch/12735/ |
| State | New, archived |
| Headers | show |
Comments
On Mon, Oct 3, 2011 at 6:39 PM, Matthew McClintock <msm@freescale.com> wrote: > Signed-off-by: Matthew McClintock <msm@freescale.com> Whoops =) > --- > Not sure if this is correct but it looks like a typo, also > there appears to be some issues with the fix as well > > meta/classes/sanity.bbclass | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index 4067408..cf30927 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass > @@ -169,7 +169,7 @@ def check_sanity_validmachine(e): > messages = messages + 'TUNE_ARCH is unset. Please ensure your MACHINE configuration includes a valid tune configuration file which will set this correctly.\n' > > # Check TARGET_ARCH is set correctly > - if data.getVar('TARGE_ARCH', e.data, False) == '${TUNE_ARCH}': > + if data.getVar('TARGET_ARCH', e.data, False) == '${TUNE_ARCH}': > messages = messages + 'TARGET_ARCH is being overwritten, likely by your MACHINE configuration files.\nPlease use a valid tune configuration file which should set this correctly automatically\nand avoid setting this in the machine configuration. See the OE-Core mailing list for more information.\n' > > # Check TARGET_OS is set After fixing this I see the following: ERROR: Poky's config sanity checker detected a potential misconfiguration. Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories: TARGET_ARCH is being overwritten, likely by your MACHINE configuration files. Please use a valid tune configuration file which should set this correctly automatically and avoid setting this in the machine configuration. See the OE-Core mailing list for more information. ERROR: Execution of event handler 'check_sanity_eventhandler' failed -M
Ping? Any comments? -M On Mon, Oct 3, 2011 at 6:48 PM, McClintock Matthew-B29882 <B29882@freescale.com> wrote: > On Mon, Oct 3, 2011 at 6:39 PM, Matthew McClintock <msm@freescale.com> wrote: >> Signed-off-by: Matthew McClintock <msm@freescale.com> > > Whoops =) > >> --- >> Not sure if this is correct but it looks like a typo, also >> there appears to be some issues with the fix as well >> >> meta/classes/sanity.bbclass | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass >> index 4067408..cf30927 100644 >> --- a/meta/classes/sanity.bbclass >> +++ b/meta/classes/sanity.bbclass >> @@ -169,7 +169,7 @@ def check_sanity_validmachine(e): >> messages = messages + 'TUNE_ARCH is unset. Please ensure your MACHINE configuration includes a valid tune configuration file which will set this correctly.\n' >> >> # Check TARGET_ARCH is set correctly >> - if data.getVar('TARGE_ARCH', e.data, False) == '${TUNE_ARCH}': >> + if data.getVar('TARGET_ARCH', e.data, False) == '${TUNE_ARCH}': >> messages = messages + 'TARGET_ARCH is being overwritten, likely by your MACHINE configuration files.\nPlease use a valid tune configuration file which should set this correctly automatically\nand avoid setting this in the machine configuration. See the OE-Core mailing list for more information.\n' >> >> # Check TARGET_OS is set > > After fixing this I see the following: > > ERROR: Poky's config sanity checker detected a potential misconfiguration. > Either fix the cause of this error or at your own risk disable the > checker (see sanity.conf). > Following is the list of potential problems / advisories: > > TARGET_ARCH is being overwritten, likely by your MACHINE > configuration files. > Please use a valid tune configuration file which should set this > correctly automatically > and avoid setting this in the machine configuration. See the OE-Core > mailing list for more information. > > ERROR: Execution of event handler 'check_sanity_eventhandler' failed > > -M > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On Mon, 2011-10-10 at 18:21 +0000, McClintock Matthew-B29882 wrote: > Ping? Any comments? > > -M > > On Mon, Oct 3, 2011 at 6:48 PM, McClintock Matthew-B29882 > <B29882@freescale.com> wrote: > > On Mon, Oct 3, 2011 at 6:39 PM, Matthew McClintock <msm@freescale.com> wrote: > >> Signed-off-by: Matthew McClintock <msm@freescale.com> > > > > Whoops =) > > > >> --- > >> Not sure if this is correct but it looks like a typo, also > >> there appears to be some issues with the fix as well > >> > >> meta/classes/sanity.bbclass | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > >> index 4067408..cf30927 100644 > >> --- a/meta/classes/sanity.bbclass > >> +++ b/meta/classes/sanity.bbclass > >> @@ -169,7 +169,7 @@ def check_sanity_validmachine(e): > >> messages = messages + 'TUNE_ARCH is unset. Please ensure your MACHINE configuration includes a valid tune configuration file which will set this correctly.\n' > >> > >> # Check TARGET_ARCH is set correctly > >> - if data.getVar('TARGE_ARCH', e.data, False) == '${TUNE_ARCH}': > >> + if data.getVar('TARGET_ARCH', e.data, False) == '${TUNE_ARCH}': > >> messages = messages + 'TARGET_ARCH is being overwritten, likely by your MACHINE configuration files.\nPlease use a valid tune configuration file which should set this correctly automatically\nand avoid setting this in the machine configuration. See the OE-Core mailing list for more information.\n' > >> > >> # Check TARGET_OS is set > > > > After fixing this I see the following: > > > > ERROR: Poky's config sanity checker detected a potential misconfiguration. > > Either fix the cause of this error or at your own risk disable the > > checker (see sanity.conf). > > Following is the list of potential problems / advisories: > > > > TARGET_ARCH is being overwritten, likely by your MACHINE > > configuration files. > > Please use a valid tune configuration file which should set this > > correctly automatically > > and avoid setting this in the machine configuration. See the OE-Core > > mailing list for more information. > > > > ERROR: Execution of event handler 'check_sanity_eventhandler' failed I've been meaning to check OECore to ensure this isn't going to cause failures before adding the patch. I then forgot I needed to do this, sorry :/. What I don't want to do is merge something which breaks things for everyone... Cheers, Richard
Patch
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 4067408..cf30927 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -169,7 +169,7 @@ def check_sanity_validmachine(e): messages = messages + 'TUNE_ARCH is unset. Please ensure your MACHINE configuration includes a valid tune configuration file which will set this correctly.\n' # Check TARGET_ARCH is set correctly - if data.getVar('TARGE_ARCH', e.data, False) == '${TUNE_ARCH}': + if data.getVar('TARGET_ARCH', e.data, False) == '${TUNE_ARCH}': messages = messages + 'TARGET_ARCH is being overwritten, likely by your MACHINE configuration files.\nPlease use a valid tune configuration file which should set this correctly automatically\nand avoid setting this in the machine configuration. See the OE-Core mailing list for more information.\n' # Check TARGET_OS is set
Signed-off-by: Matthew McClintock <msm@freescale.com> --- Not sure if this is correct but it looks like a typo, also there appears to be some issues with the fix as well meta/classes/sanity.bbclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)