Patchwork gettext.bbclass: Add virtclass DEPENDS prepends

login
register
mail settings
Submitter Tom Rini
Date March 10, 2011, 5:37 p.m.
Message ID <1299778654-14912-1-git-send-email-tom_rini@mentor.com>
Download mbox | patch
Permalink /patch/1257/
State Accepted
Headers show

Comments

Tom Rini - March 10, 2011, 5:37 p.m.
With BBCLASSEXTEND recipes which also modify DEPENDS_virtclass-native
gettext.bbclass is otherwise not working and gettext-native isn't
added.  So we need to have a DEPENDS_virtclass-$foo_prepend to
make sure GETTEXT_DEPENDS gets in.

Signed-off-by: Tom Rini <tom_rini@mentor.com>
---
 classes/gettext.bbclass |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Graeme Gregory - March 11, 2011, 2:40 p.m.
Looks sensible to me

Acked-by: Graeme Gregory <dp@xora.org.uk>

G

On 10/03/2011 17:37, Tom Rini wrote:
> With BBCLASSEXTEND recipes which also modify DEPENDS_virtclass-native
> gettext.bbclass is otherwise not working and gettext-native isn't
> added.  So we need to have a DEPENDS_virtclass-$foo_prepend to
> make sure GETTEXT_DEPENDS gets in.
> 
> Signed-off-by: Tom Rini <tom_rini@mentor.com>
> ---
>  classes/gettext.bbclass |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/classes/gettext.bbclass b/classes/gettext.bbclass
> index 6c480b5..2303311 100644
> --- a/classes/gettext.bbclass
> +++ b/classes/gettext.bbclass
> @@ -14,4 +14,7 @@ python () {
>  DEPENDS_GETTEXT = "gettext-native virtual/libiconv virtual/libintl"
>  
>  DEPENDS =+ "${DEPENDS_GETTEXT}"
> +DEPENDS_virtclass-native_prepend = "${DEPENDS_GETTEXT} "
> +DEPENDS_virtclass-nativesdk_prepend = "${DEPENDS_GETTEXT} "
> +DEPENDS_virtclass-cross_prepend = "${DEPENDS_GETTEXT} "
>  EXTRA_OECONF += "--enable-nls"

Patch

diff --git a/classes/gettext.bbclass b/classes/gettext.bbclass
index 6c480b5..2303311 100644
--- a/classes/gettext.bbclass
+++ b/classes/gettext.bbclass
@@ -14,4 +14,7 @@  python () {
 DEPENDS_GETTEXT = "gettext-native virtual/libiconv virtual/libintl"
 
 DEPENDS =+ "${DEPENDS_GETTEXT}"
+DEPENDS_virtclass-native_prepend = "${DEPENDS_GETTEXT} "
+DEPENDS_virtclass-nativesdk_prepend = "${DEPENDS_GETTEXT} "
+DEPENDS_virtclass-cross_prepend = "${DEPENDS_GETTEXT} "
 EXTRA_OECONF += "--enable-nls"