Patchwork Add bash as RDEPENDS for gstreamer

login
register
mail settings
Submitter Matthew McClintock
Date Sept. 30, 2011, 1:56 a.m.
Message ID <1317347777-10288-1-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/12441/
State New, archived
Headers show

Comments

Matthew McClintock - Sept. 30, 2011, 1:56 a.m.
This fixes the following build issue:

| error: Failed dependencies:
| 	/bin/sh is needed by gstreamer-0.10.32-r1.ppce500v2

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
Not sure how to say we just depend on /bin/sh instead of requiring
the full blown version of bash

 .../gstreamer/gstreamer_0.10.32.bb                 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Martin Jansa - Sept. 30, 2011, 7:08 a.m.
On Thu, Sep 29, 2011 at 08:56:17PM -0500, Matthew McClintock wrote:
> This fixes the following build issue:
> 
> | error: Failed dependencies:
> | 	/bin/sh is needed by gstreamer-0.10.32-r1.ppce500v2
> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
> Not sure how to say we just depend on /bin/sh instead of requiring
> the full blown version of bash
> 
>  .../gstreamer/gstreamer_0.10.32.bb                 |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer_0.10.32.bb b/meta/recipes-multimedia/gstreamer/gstreamer_0.10.32.bb
> index 1713755..63ed7cb 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer_0.10.32.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer_0.10.32.bb
> @@ -8,8 +8,9 @@ LICENSE = "LGPLv2+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605 \
>                      file://gst/gst.h;beginline=1;endline=21;md5=8e5fe5e87d33a04479fde862e238eaa4"
>  DEPENDS = "glib-2.0 libxml2 bison-native flex-native"
> +RDEPENDS = "bash"

This should be RDEPENDS_${PN} at least, but are you sure it's needed by
target package? not just for build?

Regards,

>  
> -PR = "r1"
> +PR = "r2"
>  
>  SRC_URI = "http://gstreamer.freedesktop.org/src/gstreamer/gstreamer-${PV}.tar.bz2 \
>             file://check_fix.patch \
> -- 
> 1.7.6.1
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Phil Blundell - Sept. 30, 2011, 7:49 a.m.
On Thu, 2011-09-29 at 20:56 -0500, Matthew McClintock wrote:
> Not sure how to say we just depend on /bin/sh instead of requiring
> the full blown version of bash

You can invent a virtual-bourne-shell (if one doesn't already exist),
have bash and busybox (and whatever else) provide it, then make
gstreamer depend on that.

p.
Richard Purdie - Sept. 30, 2011, 9:20 a.m.
On Thu, 2011-09-29 at 20:56 -0500, Matthew McClintock wrote:
> This fixes the following build issue:
> 
> | error: Failed dependencies:
> | 	/bin/sh is needed by gstreamer-0.10.32-r1.ppce500v2
> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
> Not sure how to say we just depend on /bin/sh instead of requiring
> the full blown version of bash

What image target are you building? I'm having trouble visualising an
image that doesn't include bash or busybox and if either of these are
present, that dependency should be met...

If this is a toolchain/SDK, there were some recent tweaks which address
this problem.

Cheers,

Richard
McClintock Matthew-B29882 - Sept. 30, 2011, 3:48 p.m.
On Fri, Sep 30, 2011 at 4:20 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> What image target are you building? I'm having trouble visualising an
> image that doesn't include bash or busybox and if either of these are
> present, that dependency should be met...
>
> If this is a toolchain/SDK, there were some recent tweaks which address
> this problem.

It was meta-toolchain-sdk, please drop this patch if that is the case.

-M
McClintock Matthew-B29882 - Sept. 30, 2011, 4:30 p.m.
On Fri, Sep 30, 2011 at 10:47 AM, Matthew McClintock <msm@freescale.com> wrote:
> On Fri, Sep 30, 2011 at 4:20 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> What image target are you building? I'm having trouble visualising an
>> image that doesn't include bash or busybox and if either of these are
>> present, that dependency should be met...
>>
>> If this is a toolchain/SDK, there were some recent tweaks which address
>> this problem.
>
> It was meta-toolchain-sdk, please drop this patch if that is the case.

FYI, I've been testing this on the 'edison' branch. Seems like this
should be addressed - assuming someone else can reproduce this
issue...

Any comments?

-M
Richard Purdie - Sept. 30, 2011, 10:25 p.m.
On Fri, 2011-09-30 at 16:30 +0000, McClintock Matthew-B29882 wrote:
> On Fri, Sep 30, 2011 at 10:47 AM, Matthew McClintock <msm@freescale.com> wrote:
> > On Fri, Sep 30, 2011 at 4:20 AM, Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> >> What image target are you building? I'm having trouble visualising an
> >> image that doesn't include bash or busybox and if either of these are
> >> present, that dependency should be met...
> >>
> >> If this is a toolchain/SDK, there were some recent tweaks which address
> >> this problem.
> >
> > It was meta-toolchain-sdk, please drop this patch if that is the case.
> 
> FYI, I've been testing this on the 'edison' branch. Seems like this
> should be addressed - assuming someone else can reproduce this
> issue...
> 
> Any comments?

I think we were missing a fix, I've sent out a patch which I think
should resolve this once and for all.

Cheers,

Richard

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer_0.10.32.bb b/meta/recipes-multimedia/gstreamer/gstreamer_0.10.32.bb
index 1713755..63ed7cb 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer_0.10.32.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer_0.10.32.bb
@@ -8,8 +8,9 @@  LICENSE = "LGPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605 \
                     file://gst/gst.h;beginline=1;endline=21;md5=8e5fe5e87d33a04479fde862e238eaa4"
 DEPENDS = "glib-2.0 libxml2 bison-native flex-native"
+RDEPENDS = "bash"
 
-PR = "r1"
+PR = "r2"
 
 SRC_URI = "http://gstreamer.freedesktop.org/src/gstreamer/gstreamer-${PV}.tar.bz2 \
            file://check_fix.patch \