Patchwork autotools: Remove help2man dependency

login
register
mail settings
Submitter Richard Purdie
Date Sept. 29, 2011, 2:52 p.m.
Message ID <1317307935.12332.89.camel@ted>
Download mbox | patch
Permalink /patch/12409/
State New, archived
Headers show

Comments

Richard Purdie - Sept. 29, 2011, 2:52 p.m.
The help2man script is pretty useless to us. It requires to run the target
binary to extract help information which is not possible for any of our
cross compiled target binaries.

We're not interested in man pages for -cross/-native tools.

It therefore makes no sense to have this as a core build dependency.

This patch removes the dependeny and replaces it with a script
returning false. This will trigger autotool's missing utility
to use the copy of the man page included with the sources which
is what would already happen when we tried to run cross compiled
binaries anyway.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Joshua Lock - Sept. 29, 2011, 6:07 p.m.
On Thu, 2011-09-29 at 15:52 +0100, Richard Purdie wrote:
> The help2man script is pretty useless to us. It requires to run the target
> binary to extract help information which is not possible for any of our
> cross compiled target binaries.
> 
> We're not interested in man pages for -cross/-native tools.
> 
> It therefore makes no sense to have this as a core build dependency.
> 
> This patch removes the dependeny and replaces it with a script
> returning false. This will trigger autotool's missing utility
> to use the copy of the man page included with the sources which
> is what would already happen when we tried to run cross compiled
> binaries anyway.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Joshua Lock <josh@linux.intel.com>

Great!

Joshua
> ---
> diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> index f213c18..c05ab4b 100644
> --- a/meta/classes/autotools.bbclass
> +++ b/meta/classes/autotools.bbclass
> @@ -7,7 +7,7 @@ def autotools_dep_prepend(d):
>  
>  	if pn in ['autoconf-native', 'automake-native', 'help2man-native']:
>  		return deps
> -	deps += 'autoconf-native automake-native help2man-native '
> +	deps += 'autoconf-native automake-native '
>  
>  	if not pn in ['libtool', 'libtool-native'] and not pn.endswith("libtool-cross"):
>  		deps += 'libtool-native '
> diff --git a/scripts/help2man b/scripts/help2man
> new file mode 100755
> index 0000000..2bb8d86
> --- a/dev/null
> +++ b/scripts/help2man
> @@ -0,0 +1,3 @@
> +#!/bin/sh
> +
> +exit 1
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Joshua Lock - Sept. 30, 2011, 6:19 p.m.
On Thu, 2011-09-29 at 11:07 -0700, Joshua Lock wrote:
> On Thu, 2011-09-29 at 15:52 +0100, Richard Purdie wrote:
> > The help2man script is pretty useless to us. It requires to run the target
> > binary to extract help information which is not possible for any of our
> > cross compiled target binaries.
> > 
> > We're not interested in man pages for -cross/-native tools.
> > 
> > It therefore makes no sense to have this as a core build dependency.
> > 
> > This patch removes the dependeny and replaces it with a script
> > returning false. This will trigger autotool's missing utility
> > to use the copy of the man page included with the sources which
> > is what would already happen when we tried to run cross compiled
> > binaries anyway.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> 
> Great!

By way of a follow on this patch "resolves" Yocto #1533 by no longer
calling help2man on the host.

http://bugzilla.yoctoproject.org/show_bug.cgi?id=1533

Cheers,
Joshua

Patch

diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index f213c18..c05ab4b 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -7,7 +7,7 @@  def autotools_dep_prepend(d):
 
 	if pn in ['autoconf-native', 'automake-native', 'help2man-native']:
 		return deps
-	deps += 'autoconf-native automake-native help2man-native '
+	deps += 'autoconf-native automake-native '
 
 	if not pn in ['libtool', 'libtool-native'] and not pn.endswith("libtool-cross"):
 		deps += 'libtool-native '
diff --git a/scripts/help2man b/scripts/help2man
new file mode 100755
index 0000000..2bb8d86
--- a/dev/null
+++ b/scripts/help2man
@@ -0,0 +1,3 @@ 
+#!/bin/sh
+
+exit 1