Patchwork [0/2] Fix TMPDIR usage in scripts

login
register
mail settings
Submitter Paul Eggleton
Date Sept. 28, 2011, 9:26 a.m.
Message ID <cover.1317201529.git.paul.eggleton@linux.intel.com>
Download mbox
Permalink /patch/12313/
State New, archived
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib paule/scripts-tmpdir

Comments

Paul Eggleton - Sept. 28, 2011, 9:26 a.m.
Fix TMPDIR external environment variable usage within our scripts which
is a problem on OpenSUSE within an X session (see Yocto bug #1530) by
using OE_TMPDIR from the external environment instead.

Note that this will require changes to autobuilder scripts that use a
TMPDIR environment variable when calling these scripts - they should now
set OE_TMPDIR instead (if versions with and without this change need to
be run on the same system, then setting both variables will cause no
harm).


The following changes since commit 684a4b517d13884c315688967fadd5e6a4845b71:

  libffi: really populate -dev package (2011-09-26 20:50:27 +0100)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib paule/scripts-tmpdir
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/scripts-tmpdir

Paul Eggleton (2):
  scripts: use OE_TMPDIR instead of TMPDIR external variable
  scripts/oe-setup-rpmrepo: use setup_tmpdir from runqemu

 scripts/oe-setup-rpmrepo |   35 +++++++++++++++++++++--------------
 scripts/runqemu          |    7 ++++++-
 2 files changed, 27 insertions(+), 15 deletions(-)
Richard Purdie - Sept. 28, 2011, 11:09 a.m.
On Wed, 2011-09-28 at 10:26 +0100, Paul Eggleton wrote:
> Fix TMPDIR external environment variable usage within our scripts which
> is a problem on OpenSUSE within an X session (see Yocto bug #1530) by
> using OE_TMPDIR from the external environment instead.
> 
> Note that this will require changes to autobuilder scripts that use a
> TMPDIR environment variable when calling these scripts - they should now
> set OE_TMPDIR instead (if versions with and without this change need to
> be run on the same system, then setting both variables will cause no
> harm).

At the very least we need to fix the references in
scripts/qemuimage-testlib so the automated image testing doesn't break.

Cheers,

Richard
Paul Eggleton - Sept. 28, 2011, 11:25 a.m.
On Wednesday 28 September 2011 12:09:57 Richard Purdie wrote:
> At the very least we need to fix the references in
> scripts/qemuimage-testlib so the automated image testing doesn't break.

OK, v2 on its way. The scripts that call qemuimage-testlib will still need to 
be updated to set OE_TMPDIR though.

Cheers,
Paul
Richard Purdie - Sept. 28, 2011, 11:38 a.m.
On Wed, 2011-09-28 at 12:25 +0100, Paul Eggleton wrote:
> On Wednesday 28 September 2011 12:09:57 Richard Purdie wrote:
> > At the very least we need to fix the references in
> > scripts/qemuimage-testlib so the automated image testing doesn't break.
> 
> OK, v2 on its way. The scripts that call qemuimage-testlib will still need to 
> be updated to set OE_TMPDIR though.

The "script" is "meta/classes/imagetest-qemu.bbclass" and you could even
test this by setting IMAGETEST = "qemu" in local.conf and then "bitbake
core-image-minimal" ;-).

Also, why can't scripts/qemuimage-testlib just do OE_TMPDIR=${TMPDIR} ?

Cheers,

Richard