Patchworkβ [oe] MokoTouch

login
register
about
Submitter David Lanzendörfer
Date 2009-11-05 22:16:19
Message ID <200911052316.23264.david.lanzendoerfer@o2s.ch>
Download mbox | patch
Permalink /patch/1228/
State Changes Requested
Headers show

Comments

David Lanzendörfer - 2009-11-05 22:16:19
> Dear David,
Hi Mickey

> let me encourage you to submit an updated patchset that takes into
> account the reviewer's comments.
Here is the corrected patch, which will bring the bitbake recipes for 
MokoTouch into OE.
I hope this will be somehow usefull for some of you.

> Cheers,
dito :)

> :M:
leviathan
Marcin Juszkiewicz - 2009-11-05 22:22:07
Dnia czwartek, 5 listopada 2009 o 23:16:19 David Lanzendörfer napisał(a):

> +++ b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
> @@ -0,0 +1,24 @@
> +require mokotouch.inc
> +
> +DEPENDS = "mokotouch-coreservices-mokotouch"
> +
> +do_configure(){
> +cd ${S}/MokoTouch/Apps/HelloWorld
> +rm UIKit.framework
> +ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
> +${OE_QMAKE_QMAKE} HelloWorld.pro
> +}
> +
> +do_compile(){
> +cd ${S}/MokoTouch/Apps/HelloWorld
> +oe_runmake
> +}
> +
> +do_install(){
> +install -d "${D}/${libdir}"
> +install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1.0.0" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1.0" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so" +}

My version of that recipe:

=============================
require mokotouch.inc

MTCOMPONENT = "HelloWorld"
=============================

Rest of code should be in mokotouch.inc as you only change component name in 
all recipes. Each and each repeats same errors:

- no setting of ${S} but use of "cd somewhere to make it build"
- big duplication of code
- no use of qmake* bbclasses which remove need of do_configure/do_compile in
  your recipes
- again waste of space by strange installation of libraries (fix loader to use
  *.so maybe and skip all *.so.1.0.0 stuff?)

Still nack from me.

Regards,
Stefan Schmidt - 2010-04-08 09:35:27
Hello.

On Thu, 2009-11-05 at 23:22, Marcin Juszkiewicz wrote:
> 
> My version of that recipe:
> 
> =============================
> require mokotouch.inc
> 
> MTCOMPONENT = "HelloWorld"
> =============================
> 
> Rest of code should be in mokotouch.inc as you only change component name in 
> all recipes. Each and each repeats same errors:
> 
> - no setting of ${S} but use of "cd somewhere to make it build"
> - big duplication of code
> - no use of qmake* bbclasses which remove need of do_configure/do_compile in
>   your recipes
> - again waste of space by strange installation of libraries (fix loader to use
>   *.so maybe and skip all *.so.1.0.0 stuff?)
> 
> Still nack from me.

I agree. David, would you make the changes Marcin pointed out?

regards
Stefan Schmidt

Patch

commit dff8d20ceb4c304ba3140deefb80310ee92219b1
Author: David Lanzendörfer <david.lanzendoerfer@o2s.ch>
Date:   Thu Nov 5 23:11:19 2009 +0100

    Added MokoTouch recipes (http://th30z.netsons.org/mokotouch/)

diff --git a/recipes/mokotouch/mokotouch-apps-customtableview_2.bb b/recipes/mokotouch/mokotouch-apps-customtableview_2.bb
new file mode 100644
index 0000000..da9ff61
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-customtableview_2.bb
@@ -0,0 +1,24 @@ 
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/CustomTableView
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} CustomTableView.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/CustomTableView
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/${libdir}/libCustomTableView.so.1.0.0"
+install "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/${libdir}/libCustomTableView.so.1.0"
+install "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/${libdir}/libCustomTableView.so.1"
+install "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/${libdir}/libCustomTableView.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-apps-helloworld_2.bb b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
new file mode 100644
index 0000000..0d42682
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
@@ -0,0 +1,24 @@ 
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/HelloWorld
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} HelloWorld.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/HelloWorld
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0" "${D}/${libdir}/libHelloWorld.so.1.0.0"
+install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0" "${D}/${libdir}/libHelloWorld.so.1.0"
+install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0" "${D}/${libdir}/libHelloWorld.so.1"
+install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0" "${D}/${libdir}/libHelloWorld.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-apps-homescreen_2.bb b/recipes/mokotouch/mokotouch-apps-homescreen_2.bb
new file mode 100644
index 0000000..b58f278
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-homescreen_2.bb
@@ -0,0 +1,23 @@ 
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/Homescreen
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} Homescreen.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/Homescreen
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0" "${D}/${libdir}/libHomescreen.so.1.0.0"
+install "${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0" "${D}/${libdir}/libHomescreen.so.1.0"
+install "${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0" "${D}/${libdir}/libHomescreen.so.1"
+install "${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0" "${D}/${libdir}/libHomescreen.so"
+}
diff --git a/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb b/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb
new file mode 100644
index 0000000..6b6fb25
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb
@@ -0,0 +1,24 @@ 
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/TestKeyboard
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} TestKeyboard.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/TestKeyboard
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0" "${D}/${libdir}/libTestKeyboard.so.1.0.0"
+install "${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0" "${D}/${libdir}/libTestKeyboard.so.1.0"
+install "${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0" "${D}/${libdir}/libTestKeyboard.so.1"
+install "${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0" "${D}/${libdir}/libTestKeyboard.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-apps-testtableview_2.bb b/recipes/mokotouch/mokotouch-apps-testtableview_2.bb
new file mode 100644
index 0000000..247b051
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-testtableview_2.bb
@@ -0,0 +1,24 @@ 
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/TestTableView
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} TestTableView.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/TestTableView
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0" "${D}/${libdir}/libTestTableView.so.1.0.0"
+install "${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0" "${D}/${libdir}/libTestTableView.so.1.0"
+install "${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0" "${D}/${libdir}/libTestTableView.so.1"
+install "${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0" "${D}/${libdir}/libTestTableView.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-apps-webmobile_2.bb b/recipes/mokotouch/mokotouch-apps-webmobile_2.bb
new file mode 100644
index 0000000..ec1b8f2
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-webmobile_2.bb
@@ -0,0 +1,24 @@ 
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/WebMobile
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} WebMobile.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/WebMobile
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0" "${D}/${libdir}/libWebMobile.so.1.0.0"
+install "${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0" "${D}/${libdir}/libWebMobile.so.1.0"
+install "${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0" "${D}/${libdir}/libWebMobile.so.1"
+install "${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0" "${D}/${libdir}/libWebMobile.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb b/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb
new file mode 100644
index 0000000..4796d25
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb
@@ -0,0 +1,25 @@ 
+require mokotouch.inc
+
+DEPENDS = "mokotouch-frameworks-uikit"
+
+do_configure(){
+cd ${S}/MokoTouch/CoreServices/MokoTouch
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} MokoTouch.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/CoreServices/MokoTouch
+oe_runmake
+}
+
+do_install(){
+install -d ${D}/${sysconfdir}
+install -d ${D}/${bindir}
+
+install qte.env ${D}/${sysconfdir}/mokotouch.env
+install "${S}/MokoTouch/CoreServices/MokoTouch/BUILD/Service/MokoTouch" "${D}/${bindir}/MokoTouch"
+}
+
+FILES_${PN} = "${bindir}/MokoTouch ${sysconfdir}/mokotouch.env"
diff --git a/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb b/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb
new file mode 100644
index 0000000..cbb3908
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb
@@ -0,0 +1,26 @@ 
+require mokotouch.inc
+
+do_configure(){
+cd ${S}/MokoTouch/Frameworks/UIKit/
+${OE_QMAKE_QMAKE} UIKit.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Frameworks/UIKit/
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/${libdir}/libUIKit.so.1.0.0"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/${libdir}/libUIKit.so.1.0"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/${libdir}/libUIKit.so.1"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/${libdir}/libUIKit.so"
+}
+
+do_stage() {
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${STAGING_LIBDIR}/libUIKit.so.1.0.0"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${STAGING_LIBDIR}/libUIKit.so.1.0"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${STAGING_LIBDIR}/libUIKit.so.1"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${STAGING_LIBDIR}/libUIKit.so"
+}
diff --git a/recipes/mokotouch/mokotouch.inc b/recipes/mokotouch/mokotouch.inc
new file mode 100644
index 0000000..95cb176
--- /dev/null
+++ b/recipes/mokotouch/mokotouch.inc
@@ -0,0 +1,16 @@ 
+DESCRIPTION = "MokoTouch a finger friendly QT4-based iphone like GUI for OpenMoko"
+HOMEPAGE = "http://th30z.netsons.org/mokotouch/"
+SECTION = "openmoko/applications"
+LICENSE = "GPL"
+DEPENDS = "gstreamer qt4-x11-free"
+
+PR = "r1"
+
+SRC_URI = "http://th30z.netsons.org/mokotouch/data/mokotouch-2-aug-2009.tar.bz2"
+
+S = "${WORKDIR}/MokoTouch-Project"
+D = "${WORKDIR}/image"
+
+EXTRA_QMAKEVARS_POST += "INCLUDEPATH+=${OE_QMAKE_INCDIR_QT}/Qt"
+
+inherit autotools qt4x11 distutils-base pkgconfig lib_package