Patchwork insane: Promote most warnings into QA errors by default

login
register
mail settings
Submitter Richard Purdie
Date Sept. 26, 2011, 8:24 p.m.
Message ID <1317068664.26109.95.camel@ted>
Download mbox | patch
Permalink /patch/12169/
State New, archived
Headers show

Comments

Richard Purdie - Sept. 26, 2011, 8:24 p.m.
We agreed a while back that we'd start ERRORing on QA issues, not just
WARNING about them. This patch changes the default QA levels to error
on everything except ldflag and useless rpath issues.

It also stops giving out QA warnings about desktop files since it
adds noise to the build and until someone plans to seriously tackle
that problem, its pointless.

We can promote the ldflag and rpath warnings too, when the issues
in OE-Core are resolved (they're mostly there now, jsut a few more
to go).

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Richard Purdie - Sept. 26, 2011, 9:51 p.m.
On Mon, 2011-09-26 at 21:24 +0100, Richard Purdie wrote:
> We agreed a while back that we'd start ERRORing on QA issues, not just
> WARNING about them. This patch changes the default QA levels to error
> on everything except ldflag and useless rpath issues.
> 
> It also stops giving out QA warnings about desktop files since it
> adds noise to the build and until someone plans to seriously tackle
> that problem, its pointless.
> 
> We can promote the ldflag and rpath warnings too, when the issues
> in OE-Core are resolved (they're mostly there now, jsut a few more
> to go).
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index addb9ac..62935c3 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
>         }
>  
> 
> -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
> -ERROR_QA ?= ""
> -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
> +# Currently not being used by default "desktop"
> +WARN_QA ?= "ldflags useless-rpaths"
> +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
>  

Further testing shows we may not be ready to move rpath to ERROR_QA
quite yet but the rest of the proposal still stands...

Cheers,

Richard
Saul Wold - Sept. 26, 2011, 11:08 p.m.
On 09/26/2011 02:51 PM, Richard Purdie wrote:
> On Mon, 2011-09-26 at 21:24 +0100, Richard Purdie wrote:
>> We agreed a while back that we'd start ERRORing on QA issues, not just
>> WARNING about them. This patch changes the default QA levels to error
>> on everything except ldflag and useless rpath issues.
>>
>> It also stops giving out QA warnings about desktop files since it
>> adds noise to the build and until someone plans to seriously tackle
>> that problem, its pointless.
>>
>> We can promote the ldflag and rpath warnings too, when the issues
>> in OE-Core are resolved (they're mostly there now, jsut a few more
>> to go).
>>
>> Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
>> ---
>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>> index addb9ac..62935c3 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
>>          }
>>
>>
>> -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
>> -ERROR_QA ?= ""
>> -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
>> +# Currently not being used by default "desktop"
>> +WARN_QA ?= "ldflags useless-rpaths"
>> +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
>>
>
> Further testing shows we may not be ready to move rpath to ERROR_QA
> quite yet but the rest of the proposal still stands...
>
How bad is the breakage in a world build?

I will probably attempt this later or tomorrow.

Sau!
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - Sept. 27, 2011, 10:02 a.m.
On Mon, 2011-09-26 at 16:08 -0700, Saul Wold wrote:
> On 09/26/2011 02:51 PM, Richard Purdie wrote:
> > On Mon, 2011-09-26 at 21:24 +0100, Richard Purdie wrote:
> >> We agreed a while back that we'd start ERRORing on QA issues, not just
> >> WARNING about them. This patch changes the default QA levels to error
> >> on everything except ldflag and useless rpath issues.
> >>
> >> It also stops giving out QA warnings about desktop files since it
> >> adds noise to the build and until someone plans to seriously tackle
> >> that problem, its pointless.
> >>
> >> We can promote the ldflag and rpath warnings too, when the issues
> >> in OE-Core are resolved (they're mostly there now, jsut a few more
> >> to go).
> >>
> >> Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
> >> ---
> >> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> >> index addb9ac..62935c3 100644
> >> --- a/meta/classes/insane.bbclass
> >> +++ b/meta/classes/insane.bbclass
> >> @@ -99,9 +99,9 @@ def package_qa_get_machine_dict():
> >>          }
> >>
> >>
> >> -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
> >> -ERROR_QA ?= ""
> >> -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
> >> +# Currently not being used by default "desktop"
> >> +WARN_QA ?= "ldflags useless-rpaths"
> >> +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
> >>
> >
> > Further testing shows we may not be ready to move rpath to ERROR_QA
> > quite yet but the rest of the proposal still stands...
> >
> How bad is the breakage in a world build?
> 
> I will probably attempt this later or tomorrow.

I tested world on qemux86 and qemuarm and fixed all the issues the above
change would error on ignoring rpath/ldflags/desktop. The list of issues
I posted earlier was against world for the other pieces, again ignoring
desktop.

So we shouldn't be too bad, otherwise I wouldn't be proposing this :)

Cheers,

Richard

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index addb9ac..62935c3 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -99,9 +99,9 @@  def package_qa_get_machine_dict():
        }
 
 
-WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths"
-ERROR_QA ?= ""
-#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms"
+# Currently not being used by default "desktop"
+WARN_QA ?= "ldflags useless-rpaths"
+ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
 
 def package_qa_clean_path(path,d):
     """ Remove the common prefix from the path. In this case it is the TMPDIR"""