Patchwork intltool: inherit gettext to add missing dependency on gettext

login
register
mail settings
Submitter Khem Raj
Date Sept. 25, 2011, 12:11 a.m.
Message ID <1316909477-31924-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/12085/
State New, archived
Headers show

Comments

Khem Raj - Sept. 25, 2011, 12:11 a.m.
Fixes the error like below

| configure: error: GNU gettext tools not found; required for intltool
| + bbfatal 'oe_runconf failed'
| + echo 'ERROR: oe_runconf failed'
| ERROR: oe_runconf failed

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/intltool/intltool.inc       |    2 +-
 meta/recipes-devtools/intltool/intltool_0.40.6.bb |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Richard Purdie - Sept. 25, 2011, 5:16 p.m.
On Sat, 2011-09-24 at 17:11 -0700, Khem Raj wrote:
> Fixes the error like below
> 
> | configure: error: GNU gettext tools not found; required for intltool
> | + bbfatal 'oe_runconf failed'
> | + echo 'ERROR: oe_runconf failed'
> | ERROR: oe_runconf failed
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/intltool/intltool.inc       |    2 +-
>  meta/recipes-devtools/intltool/intltool_0.40.6.bb |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/intltool/intltool.inc b/meta/recipes-devtools/intltool/intltool.inc
> index 23a1ee9..1e54feb 100644
> --- a/meta/recipes-devtools/intltool/intltool.inc
> +++ b/meta/recipes-devtools/intltool/intltool.inc
> @@ -12,7 +12,7 @@ DEPENDS_virtclass-native = "libxml-parser-perl-native"
>  RRECOMMENDS_${PN} = "perl-modules"
>  RRECOMMENDS_${PN}_virtclass-native = ""
>  
> -inherit autotools pkgconfig perlnative
> +inherit autotools pkgconfig perlnative gettext
>  
>  export PERL = "${bindir}/env perl"
>  PERL_virtclass-native = "/usr/bin/env nativeperl"
> diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
> index e9871fc..eae2b85 100644
> --- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
> +++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
> @@ -1,7 +1,7 @@
>  require intltool.inc
>  LICENSE="GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
> -PR = "r5"
> +PR = "r6"
>  
>  SRC_URI_append = " file://intltool-nowarn-0.40.0.patch \
>                     ${NATIVEPATCHES} \

I investigated this one and intltool requires gettext at runtime, not
build time. Which package did you see the above error from as I suspect
it wasn't intltool itself but something using it?

Cheers,

Richard
Khem Raj - Sept. 26, 2011, 12:22 a.m.
On Sun, Sep 25, 2011 at 10:16 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sat, 2011-09-24 at 17:11 -0700, Khem Raj wrote:
>> Fixes the error like below
>>
>> | configure: error: GNU gettext tools not found; required for intltool
>> | + bbfatal 'oe_runconf failed'
>> | + echo 'ERROR: oe_runconf failed'
>> | ERROR: oe_runconf failed
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  meta/recipes-devtools/intltool/intltool.inc       |    2 +-
>>  meta/recipes-devtools/intltool/intltool_0.40.6.bb |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/intltool/intltool.inc b/meta/recipes-devtools/intltool/intltool.inc
>> index 23a1ee9..1e54feb 100644
>> --- a/meta/recipes-devtools/intltool/intltool.inc
>> +++ b/meta/recipes-devtools/intltool/intltool.inc
>> @@ -12,7 +12,7 @@ DEPENDS_virtclass-native = "libxml-parser-perl-native"
>>  RRECOMMENDS_${PN} = "perl-modules"
>>  RRECOMMENDS_${PN}_virtclass-native = ""
>>
>> -inherit autotools pkgconfig perlnative
>> +inherit autotools pkgconfig perlnative gettext
>>
>>  export PERL = "${bindir}/env perl"
>>  PERL_virtclass-native = "/usr/bin/env nativeperl"
>> diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>> index e9871fc..eae2b85 100644
>> --- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>> +++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>> @@ -1,7 +1,7 @@
>>  require intltool.inc
>>  LICENSE="GPLv2"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>> -PR = "r5"
>> +PR = "r6"
>>
>>  SRC_URI_append = " file://intltool-nowarn-0.40.0.patch \
>>                     ${NATIVEPATCHES} \
>
> I investigated this one and intltool requires gettext at runtime, not
> build time. Which package did you see the above error from as I suspect
> it wasn't intltool itself but something using it?

It was intltool itself. The situation happens during rebuild when
intltool and gettext-native both are to be rebuilt
and other deps are already there. it doesnt usually happen since we
build gettext-native pretty early.
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Saul Wold - Sept. 28, 2011, 5:17 p.m.
On 09/25/2011 05:22 PM, Khem Raj wrote:
> On Sun, Sep 25, 2011 at 10:16 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org>  wrote:
>> On Sat, 2011-09-24 at 17:11 -0700, Khem Raj wrote:
>>> Fixes the error like below
>>>
>>> | configure: error: GNU gettext tools not found; required for intltool
>>> | + bbfatal 'oe_runconf failed'
>>> | + echo 'ERROR: oe_runconf failed'
>>> | ERROR: oe_runconf failed
>>>
>>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>> ---
>>>   meta/recipes-devtools/intltool/intltool.inc       |    2 +-
>>>   meta/recipes-devtools/intltool/intltool_0.40.6.bb |    2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-devtools/intltool/intltool.inc b/meta/recipes-devtools/intltool/intltool.inc
>>> index 23a1ee9..1e54feb 100644
>>> --- a/meta/recipes-devtools/intltool/intltool.inc
>>> +++ b/meta/recipes-devtools/intltool/intltool.inc
>>> @@ -12,7 +12,7 @@ DEPENDS_virtclass-native = "libxml-parser-perl-native"
>>>   RRECOMMENDS_${PN} = "perl-modules"
>>>   RRECOMMENDS_${PN}_virtclass-native = ""
>>>
>>> -inherit autotools pkgconfig perlnative
>>> +inherit autotools pkgconfig perlnative gettext
>>>
>>>   export PERL = "${bindir}/env perl"
>>>   PERL_virtclass-native = "/usr/bin/env nativeperl"
>>> diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>> index e9871fc..eae2b85 100644
>>> --- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>> +++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>> @@ -1,7 +1,7 @@
>>>   require intltool.inc
>>>   LICENSE="GPLv2"
>>>   LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>> -PR = "r5"
>>> +PR = "r6"
>>>
>>>   SRC_URI_append = " file://intltool-nowarn-0.40.0.patch \
>>>                      ${NATIVEPATCHES} \
>>
>> I investigated this one and intltool requires gettext at runtime, not
>> build time. Which package did you see the above error from as I suspect
>> it wasn't intltool itself but something using it?
>
> It was intltool itself. The situation happens during rebuild when
> intltool and gettext-native both are to be rebuilt
> and other deps are already there. it doesnt usually happen since we
> build gettext-native pretty early.

Khem,

I verified this, and I also noted that if I did a cleansstate on 
intltool and gettext-native, that gettext-native would be rebuilt, but I 
also checked bitbake -b intltool and it completed successfully with no 
errors, so the dependency is buried in one of intltool's dependencies, 
thus getting built.

So there is no direct dependency on gettext-native by intltool.


Sau!

>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - Sept. 28, 2011, 5:29 p.m.
On 9/28/2011 10:17 AM, Saul Wold wrote:
> On 09/25/2011 05:22 PM, Khem Raj wrote:
>> On Sun, Sep 25, 2011 at 10:16 AM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>>> On Sat, 2011-09-24 at 17:11 -0700, Khem Raj wrote:
>>>> Fixes the error like below
>>>>
>>>> | configure: error: GNU gettext tools not found; required for intltool
>>>> | + bbfatal 'oe_runconf failed'
>>>> | + echo 'ERROR: oe_runconf failed'
>>>> | ERROR: oe_runconf failed
>>>>
>>>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>>> ---
>>>> meta/recipes-devtools/intltool/intltool.inc | 2 +-
>>>> meta/recipes-devtools/intltool/intltool_0.40.6.bb | 2 +-
>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-devtools/intltool/intltool.inc
>>>> b/meta/recipes-devtools/intltool/intltool.inc
>>>> index 23a1ee9..1e54feb 100644
>>>> --- a/meta/recipes-devtools/intltool/intltool.inc
>>>> +++ b/meta/recipes-devtools/intltool/intltool.inc
>>>> @@ -12,7 +12,7 @@ DEPENDS_virtclass-native =
>>>> "libxml-parser-perl-native"
>>>> RRECOMMENDS_${PN} = "perl-modules"
>>>> RRECOMMENDS_${PN}_virtclass-native = ""
>>>>
>>>> -inherit autotools pkgconfig perlnative
>>>> +inherit autotools pkgconfig perlnative gettext
>>>>
>>>> export PERL = "${bindir}/env perl"
>>>> PERL_virtclass-native = "/usr/bin/env nativeperl"
>>>> diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>>> b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>>> index e9871fc..eae2b85 100644
>>>> --- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>>> +++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>>> @@ -1,7 +1,7 @@
>>>> require intltool.inc
>>>> LICENSE="GPLv2"
>>>> LIC_FILES_CHKSUM =
>>>> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>>> -PR = "r5"
>>>> +PR = "r6"
>>>>
>>>> SRC_URI_append = " file://intltool-nowarn-0.40.0.patch \
>>>> ${NATIVEPATCHES} \
>>>
>>> I investigated this one and intltool requires gettext at runtime, not
>>> build time. Which package did you see the above error from as I suspect
>>> it wasn't intltool itself but something using it?
>>
>> It was intltool itself. The situation happens during rebuild when
>> intltool and gettext-native both are to be rebuilt
>> and other deps are already there. it doesnt usually happen since we
>> build gettext-native pretty early.
>
> Khem,
>
> I verified this, and I also noted that if I did a cleansstate on
> intltool and gettext-native, that gettext-native would be rebuilt, but I
> also checked bitbake -b intltool and it completed successfully with no
> errors, so the dependency is buried in one of intltool's dependencies,
> thus getting built.
>
> So there is no direct dependency on gettext-native by intltool.

yes intltool has runtime dependency on gettext-native but not buildtime
AFAICT. I dont have those logs any more so cant go back and check.

Hold on to this patch for now. i will remove it locally and do a rebuild
and see if I hit it again

>
>
> Sau!
>
>>>
>>> Cheers,
>>>
>>> Richard
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Saul Wold - Sept. 28, 2011, 5:35 p.m.
On 09/28/2011 10:29 AM, Khem Raj wrote:
> On 9/28/2011 10:17 AM, Saul Wold wrote:
>> On 09/25/2011 05:22 PM, Khem Raj wrote:
>>> On Sun, Sep 25, 2011 at 10:16 AM, Richard Purdie
>>> <richard.purdie@linuxfoundation.org> wrote:
>>>> On Sat, 2011-09-24 at 17:11 -0700, Khem Raj wrote:
>>>>> Fixes the error like below
>>>>>
>>>>> | configure: error: GNU gettext tools not found; required for intltool
>>>>> | + bbfatal 'oe_runconf failed'
>>>>> | + echo 'ERROR: oe_runconf failed'
>>>>> | ERROR: oe_runconf failed
>>>>>
>>>>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>>>> ---
>>>>> meta/recipes-devtools/intltool/intltool.inc | 2 +-
>>>>> meta/recipes-devtools/intltool/intltool_0.40.6.bb | 2 +-
>>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/meta/recipes-devtools/intltool/intltool.inc
>>>>> b/meta/recipes-devtools/intltool/intltool.inc
>>>>> index 23a1ee9..1e54feb 100644
>>>>> --- a/meta/recipes-devtools/intltool/intltool.inc
>>>>> +++ b/meta/recipes-devtools/intltool/intltool.inc
>>>>> @@ -12,7 +12,7 @@ DEPENDS_virtclass-native =
>>>>> "libxml-parser-perl-native"
>>>>> RRECOMMENDS_${PN} = "perl-modules"
>>>>> RRECOMMENDS_${PN}_virtclass-native = ""
>>>>>
>>>>> -inherit autotools pkgconfig perlnative
>>>>> +inherit autotools pkgconfig perlnative gettext
>>>>>
>>>>> export PERL = "${bindir}/env perl"
>>>>> PERL_virtclass-native = "/usr/bin/env nativeperl"
>>>>> diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>>>> b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>>>> index e9871fc..eae2b85 100644
>>>>> --- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>>>> +++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>>>> @@ -1,7 +1,7 @@
>>>>> require intltool.inc
>>>>> LICENSE="GPLv2"
>>>>> LIC_FILES_CHKSUM =
>>>>> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>>>> -PR = "r5"
>>>>> +PR = "r6"
>>>>>
>>>>> SRC_URI_append = " file://intltool-nowarn-0.40.0.patch \
>>>>> ${NATIVEPATCHES} \
>>>>
>>>> I investigated this one and intltool requires gettext at runtime, not
>>>> build time. Which package did you see the above error from as I suspect
>>>> it wasn't intltool itself but something using it?
>>>
>>> It was intltool itself. The situation happens during rebuild when
>>> intltool and gettext-native both are to be rebuilt
>>> and other deps are already there. it doesnt usually happen since we
>>> build gettext-native pretty early.
>>
>> Khem,
>>
>> I verified this, and I also noted that if I did a cleansstate on
>> intltool and gettext-native, that gettext-native would be rebuilt, but I
>> also checked bitbake -b intltool and it completed successfully with no
>> errors, so the dependency is buried in one of intltool's dependencies,
>> thus getting built.
>>
>> So there is no direct dependency on gettext-native by intltool.
>
> yes intltool has runtime dependency on gettext-native but not buildtime
> AFAICT. I dont have those logs any more so cant go back and check.
>
Sorry, I meant no direct buildtime above

> Hold on to this patch for now. i will remove it locally and do a rebuild
> and see if I hit it again
>
OK will hold it.

Sau!


>>
>>
>> Sau!
>>
>>>>
>>>> Cheers,
>>>>
>>>> Richard
>>>>
>>>>
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-devtools/intltool/intltool.inc b/meta/recipes-devtools/intltool/intltool.inc
index 23a1ee9..1e54feb 100644
--- a/meta/recipes-devtools/intltool/intltool.inc
+++ b/meta/recipes-devtools/intltool/intltool.inc
@@ -12,7 +12,7 @@  DEPENDS_virtclass-native = "libxml-parser-perl-native"
 RRECOMMENDS_${PN} = "perl-modules"
 RRECOMMENDS_${PN}_virtclass-native = ""
 
-inherit autotools pkgconfig perlnative
+inherit autotools pkgconfig perlnative gettext
 
 export PERL = "${bindir}/env perl"
 PERL_virtclass-native = "/usr/bin/env nativeperl"
diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
index e9871fc..eae2b85 100644
--- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
+++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
@@ -1,7 +1,7 @@ 
 require intltool.inc
 LICENSE="GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
-PR = "r5"
+PR = "r6"
 
 SRC_URI_append = " file://intltool-nowarn-0.40.0.patch \
                    ${NATIVEPATCHES} \