Patchwork [04/10] dbus-glib: include bash-completion stuff

login
register
mail settings
Submitter lumag
Date Sept. 23, 2011, 7:46 p.m.
Message ID <1316807201-22623-4-git-send-email-dbaryshkov@gmail.com>
Download mbox | patch
Permalink /patch/12051/
State New, archived
Headers show

Comments

lumag - Sept. 23, 2011, 7:46 p.m.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 meta/recipes-core/dbus/dbus-glib.inc     |    4 +++-
 meta/recipes-core/dbus/dbus-glib_0.92.bb |    2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
Otavio Salvador - Sept. 23, 2011, 8:09 p.m.
On Fri, Sep 23, 2011 at 16:46, Dmitry Eremin-Solenikov
<dbaryshkov@gmail.com> wrote:
...
> +FILES_${PN} = "${libdir}/lib*.so.* \
> +               ${sysconfdir}/bash_completion.d/dbus-bash-completion.sh \
> +              ${libexecdir}/dbus-bash-completion-helper"
...

I'd prefer to have this in another package.
Richard Purdie - Sept. 25, 2011, 5:20 p.m.
On Fri, 2011-09-23 at 17:09 -0300, Otavio Salvador wrote:
> On Fri, Sep 23, 2011 at 16:46, Dmitry Eremin-Solenikov
> <dbaryshkov@gmail.com> wrote:
> ...
> > +FILES_${PN} = "${libdir}/lib*.so.* \
> > +               ${sysconfdir}/bash_completion.d/dbus-bash-completion.sh \
> > +              ${libexecdir}/dbus-bash-completion-helper"
> ...
> 
> I'd prefer to have this in another package.

Me too, I think this should be packaged separately (with a RRECOMMENDS
on bash-completion for good measure).

Cheers,

Richard
Otavio Salvador - Sept. 25, 2011, 5:34 p.m.
On Sun, Sep 25, 2011 at 14:20, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2011-09-23 at 17:09 -0300, Otavio Salvador wrote:
>> On Fri, Sep 23, 2011 at 16:46, Dmitry Eremin-Solenikov
>> <dbaryshkov@gmail.com> wrote:
>> ...
>> > +FILES_${PN} = "${libdir}/lib*.so.* \
>> > +               ${sysconfdir}/bash_completion.d/dbus-bash-completion.sh \
>> > +              ${libexecdir}/dbus-bash-completion-helper"
>> ...
>>
>> I'd prefer to have this in another package.
>
> Me too, I think this should be packaged separately (with a RRECOMMENDS
> on bash-completion for good measure).

I don't think RRECOMMENDS are good in this case; people were using it
without this for long time and noone has noticed yet so it seems not
that required.
Richard Purdie - Sept. 25, 2011, 5:44 p.m.
On Sun, 2011-09-25 at 14:34 -0300, Otavio Salvador wrote:
> On Sun, Sep 25, 2011 at 14:20, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2011-09-23 at 17:09 -0300, Otavio Salvador wrote:
> >> On Fri, Sep 23, 2011 at 16:46, Dmitry Eremin-Solenikov
> >> <dbaryshkov@gmail.com> wrote:
> >> ...
> >> > +FILES_${PN} = "${libdir}/lib*.so.* \
> >> > +               ${sysconfdir}/bash_completion.d/dbus-bash-completion.sh \
> >> > +              ${libexecdir}/dbus-bash-completion-helper"
> >> ...
> >>
> >> I'd prefer to have this in another package.
> >
> > Me too, I think this should be packaged separately (with a RRECOMMENDS
> > on bash-completion for good measure).
> 
> I don't think RRECOMMENDS are good in this case; people were using it
> without this for long time and noone has noticed yet so it seems not
> that required.

I mean having dbus-glib-bash-completion RRECOMMENDS bash-completion.

Cheers,

Richard
Anders Darander - Sept. 25, 2011, 5:48 p.m.
* Otavio Salvador <otavio@ossystems.com.br> [110925 19:34]:
> On Sun, Sep 25, 2011 at 14:20, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2011-09-23 at 17:09 -0300, Otavio Salvador wrote:
> >> On Fri, Sep 23, 2011 at 16:46, Dmitry Eremin-Solenikov
> >> <dbaryshkov@gmail.com> wrote:
> >> ...
> >> > +FILES_${PN} = "${libdir}/lib*.so.* \
> >> > +               ${sysconfdir}/bash_completion.d/dbus-bash-completion.sh \
> >> > +              ${libexecdir}/dbus-bash-completion-helper"
> >> ...

> >> I'd prefer to have this in another package.

> > Me too, I think this should be packaged separately (with a RRECOMMENDS
> > on bash-completion for good measure).

> I don't think RRECOMMENDS are good in this case; people were using it
> without this for long time and noone has noticed yet so it seems not
> that required.

I think Richard meant that the new dbus-glib-bash-completion(?) package
should have a RRECOMMENDS on bash-completion (as it will be pretty
useless on a system without bash-completion).

Dbus-glib should definitely not start to RRECOMMEND bash-completion, as
noone has requested that for a long time.

Cheers,
Anders

Patch

diff --git a/meta/recipes-core/dbus/dbus-glib.inc b/meta/recipes-core/dbus/dbus-glib.inc
index 704dc04..7688a0f 100644
--- a/meta/recipes-core/dbus/dbus-glib.inc
+++ b/meta/recipes-core/dbus/dbus-glib.inc
@@ -19,7 +19,9 @@  EXTRA_OECONF = "--with-introspect-xml=${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-in
                 --with-dbus-binding-tool=${STAGING_BINDIR_NATIVE}/dbus-binding-tool"
 EXTRA_OECONF_virtclass-native = "--with-introspect-xml=${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml"
 
-FILES_${PN} = "${libdir}/lib*.so.*"
+FILES_${PN} = "${libdir}/lib*.so.* \
+               ${sysconfdir}/bash_completion.d/dbus-bash-completion.sh \
+	       ${libexecdir}/dbus-bash-completion-helper"
 FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-glib-tool"
 FILES_${PN}-dev += "${bindir}/dbus-binding-tool"
 
diff --git a/meta/recipes-core/dbus/dbus-glib_0.92.bb b/meta/recipes-core/dbus/dbus-glib_0.92.bb
index 72bea89..c7266d4 100644
--- a/meta/recipes-core/dbus/dbus-glib_0.92.bb
+++ b/meta/recipes-core/dbus/dbus-glib_0.92.bb
@@ -1,6 +1,6 @@ 
 require dbus-glib.inc
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI[md5sum] = "b595b36890c4f9f8f5d5dec131c495f8"
 SRC_URI[sha256sum] = "5a7fd4cf937cdcb7f2eed61341b70ee0f2607450a50db381618598adf60dd40e"