Patchworkβ [oe] suite of utilities for programming Xilinx FPGAs, CPLDs, and EEPROMs

login
register
about
Submitter Jaap de Jong
Date 2009-11-03 13:35:45
Message ID <1257255345.13860.0.camel@nvc0624>
Download mbox | patch
Permalink /patch/1202/
State Changes Requested
Headers show

Comments

Jaap de Jong - 2009-11-03 13:35:45
Updated.
Much simpeler now...

On Tue, 2009-11-03 at 13:30 +0100, Koen Kooi wrote:
> On 03-11-09 13:10, Jaap de Jong wrote:
> > Hi there,
> >
> > attached a proposal for a recipe for building a jtag tool for programming xilinx cpld's, fpga's and eeprom's.
> > Disclaimer: this is my first recipe; possibly not optimal...
> 
> Please use something like
> 
> SRC_URI = 
> "svn://xc3sprog.svn.sourceforge.net/svnroot/xc3sprog;proto=https;module=trunk" 
> 
> 
> and set SRCREV accordingly instead of overriding do_fetch.
> 
> regards,
> 
> Koen
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Stefan Schmidt - 2010-02-16 11:39:34
Hello.

Sorry for the delay. Just found that one in patchwork.

On Tue, 2009-11-03 at 14:35, Jaap de Jong wrote:
> Updated.
> Much simpeler now...

Nearly there.

> Suite of utilities for programming Xilinx FPGAs, CPLDs, and EEPROMs

Please prefix the message with the recipe name. Makes it easier to read commit
logs and understand about which recipe they are. Like:

xc3sprog: Add suite of ...

> ---
>  recipes/xc3sprog/xc3sprog_411.bb |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/xc3sprog/xc3sprog_411.bb
> 
> diff --git a/recipes/xc3sprog/xc3sprog_411.bb b/recipes/xc3sprog/xc3sprog_411.bb
> new file mode 100644
> index 0000000..0ffc4dc
> --- /dev/null
> +++ b/recipes/xc3sprog/xc3sprog_411.bb
> @@ -0,0 +1,15 @@
> +# xc3sprog build file
> +LICENSE="GPL"
> +DESCRIPTION="suite of utilities for programming Xilinx FPGAs, CPLDs, and EEPROMs"

Nitpick. Please start with uppercase.

> +HOMEPAGE="http://sourceforge.net/projects/xc3sprog"
> +
> +DEPENDS += "libftdi"
> +
> +SRC_URI = "svn://xc3sprog.svn.sourceforge.net/svnroot/xc3sprog;proto=https;module=trunk" 
> +SRCREV = ${PV}
> +
> +S="${WORKDIR}/trunk"
> +PR = "r0"
> +
> +inherit cmake

To sort the the lines in the recipe to look more like others in the repo you can
run it through contrib/oe-stylize.py

If you care to resend the updated patch I'm going to test and apply it.

regards
Stefan Schmidt

Patch


Suite of utilities for programming Xilinx FPGAs, CPLDs, and EEPROMs

---
 recipes/xc3sprog/xc3sprog_411.bb |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
 create mode 100644 recipes/xc3sprog/xc3sprog_411.bb

diff --git a/recipes/xc3sprog/xc3sprog_411.bb b/recipes/xc3sprog/xc3sprog_411.bb
new file mode 100644
index 0000000..0ffc4dc
--- /dev/null
+++ b/recipes/xc3sprog/xc3sprog_411.bb
@@ -0,0 +1,15 @@ 
+# xc3sprog build file
+LICENSE="GPL"
+DESCRIPTION="suite of utilities for programming Xilinx FPGAs, CPLDs, and EEPROMs"
+HOMEPAGE="http://sourceforge.net/projects/xc3sprog"
+
+DEPENDS += "libftdi"
+
+SRC_URI = "svn://xc3sprog.svn.sourceforge.net/svnroot/xc3sprog;proto=https;module=trunk" 
+SRCREV = ${PV}
+
+S="${WORKDIR}/trunk"
+PR = "r0"
+
+inherit cmake
+
-- 
1.6.3.3