Patchwork [1/1] shared-mime-info: add libxml-parser-perl to DEPENDS

login
register
mail settings
Submitter Darren Hart
Date Sept. 22, 2011, 6:49 p.m.
Message ID <4b97e6b25906806eef1131e851abc9526d81d0db.1316717234.git.dvhart@linux.intel.com>
Download mbox | patch
Permalink /patch/12011/
State New, archived
Headers show

Comments

Darren Hart - Sept. 22, 2011, 6:49 p.m.
Fixes [YOCTO #1514]

Building core-image-minimal on qemuppc (and likely others) can fail in
the shared-mime-info configure step with the following error:

checking for XML::Parser... configure: error: XML::Parser perl module is
required for intltool

Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
successfully.

Testing: build tested the native version on qemuppc. I run into tool chain
build failures before I can get to building the target version.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Joshua Lock <josh@linux.intel.com>
---
 .../shared-mime-info/shared-mime-info.inc          |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Richard Purdie - Sept. 22, 2011, 7:58 p.m.
On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
> Fixes [YOCTO #1514]
> 
> Building core-image-minimal on qemuppc (and likely others) can fail in
> the shared-mime-info configure step with the following error:
> 
> checking for XML::Parser... configure: error: XML::Parser perl module is
> required for intltool
> 
> Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
> successfully.
> 
> Testing: build tested the native version on qemuppc. I run into tool chain
> build failures before I can get to building the target version.
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Joshua Lock <josh@linux.intel.com>
> ---
>  .../shared-mime-info/shared-mime-info.inc          |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> index 64eef9d..e206305 100644
> --- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> +++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> @@ -5,8 +5,8 @@ SECTION = "base"
>  LICENSE = "GPLv2+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>  
> -DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
> -DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
> +DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
> +DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
>  
>  SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"


There must be some underlying problem here. intltool-native should
depend on libxml-parser-perl-native so it should already be built. We
need to fix the underlying issue, not the symptom :/

Cheers,

Richard
Saul Wold - Sept. 22, 2011, 8:03 p.m.
On 09/22/2011 12:58 PM, Richard Purdie wrote:
> On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
>> Fixes [YOCTO #1514]
>>
>> Building core-image-minimal on qemuppc (and likely others) can fail in
>> the shared-mime-info configure step with the following error:
>>
I was thinking about this and went "why is shared-mime-info even in 
core-image-minimal", are you sure that was the image you were building. 
This might point to some other problem also.

Sau!

>> checking for XML::Parser... configure: error: XML::Parser perl module is
>> required for intltool
>>
>> Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
>> successfully.
>>
>> Testing: build tested the native version on qemuppc. I run into tool chain
>> build failures before I can get to building the target version.
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> CC: Joshua Lock<josh@linux.intel.com>
>> ---
>>   .../shared-mime-info/shared-mime-info.inc          |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> index 64eef9d..e206305 100644
>> --- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> +++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> @@ -5,8 +5,8 @@ SECTION = "base"
>>   LICENSE = "GPLv2+"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>>
>> -DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
>> -DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
>> +DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
>> +DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
>>
>>   SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
>
>
> There must be some underlying problem here. intltool-native should
> depend on libxml-parser-perl-native so it should already be built. We
> need to fix the underlying issue, not the symptom :/
>
> Cheers,
>
> Richard
>
>
Darren Hart - Sept. 22, 2011, 8:19 p.m.
On 09/22/2011 01:03 PM, Saul Wold wrote:
> On 09/22/2011 12:58 PM, Richard Purdie wrote:
>> On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
>>> Fixes [YOCTO #1514]
>>>
>>> Building core-image-minimal on qemuppc (and likely others) can fail in
>>> the shared-mime-info configure step with the following error:
>>>
> I was thinking about this and went "why is shared-mime-info even in 
> core-image-minimal", are you sure that was the image you were building. 
> This might point to some other problem also.

Yes, core-image-minimal. It also would fail if I just tried to build
shared-mime-info-native.

--
Darren

> 
> Sau!
> 
>>> checking for XML::Parser... configure: error: XML::Parser perl module is
>>> required for intltool
>>>
>>> Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
>>> successfully.
>>>
>>> Testing: build tested the native version on qemuppc. I run into tool chain
>>> build failures before I can get to building the target version.
>>>
>>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>>> CC: Joshua Lock<josh@linux.intel.com>
>>> ---
>>>   .../shared-mime-info/shared-mime-info.inc          |    4 ++--
>>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> index 64eef9d..e206305 100644
>>> --- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> +++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> @@ -5,8 +5,8 @@ SECTION = "base"
>>>   LICENSE = "GPLv2+"
>>>   LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>>>
>>> -DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
>>> -DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
>>> +DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
>>> +DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
>>>
>>>   SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
>>
>>
>> There must be some underlying problem here. intltool-native should
>> depend on libxml-parser-perl-native so it should already be built. We
>> need to fix the underlying issue, not the symptom :/
>>
>> Cheers,
>>
>> Richard
>>
>>
Darren Hart - Sept. 22, 2011, 8:27 p.m.
On 09/22/2011 12:58 PM, Richard Purdie wrote:
> On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
>> Fixes [YOCTO #1514]
>>
>> Building core-image-minimal on qemuppc (and likely others) can fail in
>> the shared-mime-info configure step with the following error:
>>
>> checking for XML::Parser... configure: error: XML::Parser perl module is
>> required for intltool
>>
>> Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
>> successfully.
>>
>> Testing: build tested the native version on qemuppc. I run into tool chain
>> build failures before I can get to building the target version.
>>
>> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
>> CC: Joshua Lock <josh@linux.intel.com>
>> ---
>>  .../shared-mime-info/shared-mime-info.inc          |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> index 64eef9d..e206305 100644
>> --- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> +++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> @@ -5,8 +5,8 @@ SECTION = "base"
>>  LICENSE = "GPLv2+"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>>  
>> -DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
>> -DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
>> +DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
>> +DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
>>  
>>  SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
> 
> 
> There must be some underlying problem here. intltool-native should
> depend on libxml-parser-perl-native so it should already be built. We
> need to fix the underlying issue, not the symptom :/

So intltool.inc:

DEPENDS = "libxml-parser-perl-native"
#RDEPENDS_${PN} = "libxml-parser-perl"
RRECOMMENDS_${PN} = "perl-modules"
RRECOMMENDS_${PN}_virtclass-native = ""

Shouldn't this instead look like:

DEPENDS = "libxml-parser-perl"
DEPENDS_virtclass-native = "libxml-parser-perl-native"

Dropping my change above and using this fix instead allows the build to
complete. Does look like the right fix to you? Shall I send this as a
patch?

Thanks,
Darren Hart - Sept. 22, 2011, 8:32 p.m.
On 09/22/2011 01:03 PM, Saul Wold wrote:
> On 09/22/2011 12:58 PM, Richard Purdie wrote:
>> On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
>>> Fixes [YOCTO #1514]
>>>
>>> Building core-image-minimal on qemuppc (and likely others) can fail in
>>> the shared-mime-info configure step with the following error:
>>>
> I was thinking about this and went "why is shared-mime-info even in 
> core-image-minimal", are you sure that was the image you were building. 
> This might point to some other problem also.

Perhaps these are pulled in from:

EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps
debug-tweaks"

Removing this does remove shared-mime-info from the package list (per
depexp). They do not get built during a subsequent core-image-minimal
build either.

--
Darren

> 
> Sau!
> 
>>> checking for XML::Parser... configure: error: XML::Parser perl module is
>>> required for intltool
>>>
>>> Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
>>> successfully.
>>>
>>> Testing: build tested the native version on qemuppc. I run into tool chain
>>> build failures before I can get to building the target version.
>>>
>>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>>> CC: Joshua Lock<josh@linux.intel.com>
>>> ---
>>>   .../shared-mime-info/shared-mime-info.inc          |    4 ++--
>>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> index 64eef9d..e206305 100644
>>> --- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> +++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> @@ -5,8 +5,8 @@ SECTION = "base"
>>>   LICENSE = "GPLv2+"
>>>   LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>>>
>>> -DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
>>> -DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
>>> +DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
>>> +DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
>>>
>>>   SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
>>
>>
>> There must be some underlying problem here. intltool-native should
>> depend on libxml-parser-perl-native so it should already be built. We
>> need to fix the underlying issue, not the symptom :/
>>
>> Cheers,
>>
>> Richard
>>
>>
Koen Kooi - Sept. 22, 2011, 8:34 p.m.
Op 22 sep. 2011, om 22:27 heeft Darren Hart het volgende geschreven:

> 
> 
> On 09/22/2011 12:58 PM, Richard Purdie wrote:
>> On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
>>> Fixes [YOCTO #1514]
>>> 
>>> Building core-image-minimal on qemuppc (and likely others) can fail in
>>> the shared-mime-info configure step with the following error:
>>> 
>>> checking for XML::Parser... configure: error: XML::Parser perl module is
>>> required for intltool
>>> 
>>> Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
>>> successfully.
>>> 
>>> Testing: build tested the native version on qemuppc. I run into tool chain
>>> build failures before I can get to building the target version.
>>> 
>>> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
>>> CC: Joshua Lock <josh@linux.intel.com>
>>> ---
>>> .../shared-mime-info/shared-mime-info.inc          |    4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> index 64eef9d..e206305 100644
>>> --- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> +++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>>> @@ -5,8 +5,8 @@ SECTION = "base"
>>> LICENSE = "GPLv2+"
>>> LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>>> 
>>> -DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
>>> -DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
>>> +DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
>>> +DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
>>> 
>>> SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
>> 
>> 
>> There must be some underlying problem here. intltool-native should
>> depend on libxml-parser-perl-native so it should already be built. We
>> need to fix the underlying issue, not the symptom :/
> 
> So intltool.inc:
> 
> DEPENDS = "libxml-parser-perl-native"
> #RDEPENDS_${PN} = "libxml-parser-perl"
> RRECOMMENDS_${PN} = "perl-modules"
> RRECOMMENDS_${PN}_virtclass-native = ""
> 
> Shouldn't this instead look like:
> 
> DEPENDS = "libxml-parser-perl"
> DEPENDS_virtclass-native = "libxml-parser-perl-native"

It needs -native for both, sadly
Richard Purdie - Sept. 22, 2011, 8:52 p.m.
On Thu, 2011-09-22 at 13:27 -0700, Darren Hart wrote:
> 
> On 09/22/2011 12:58 PM, Richard Purdie wrote:
> > On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
> >> Fixes [YOCTO #1514]
> >>
> >> Building core-image-minimal on qemuppc (and likely others) can fail in
> >> the shared-mime-info configure step with the following error:
> >>
> >> checking for XML::Parser... configure: error: XML::Parser perl module is
> >> required for intltool
> >>
> >> Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
> >> successfully.
> >>
> >> Testing: build tested the native version on qemuppc. I run into tool chain
> >> build failures before I can get to building the target version.
> >>
> >> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> >> CC: Joshua Lock <josh@linux.intel.com>
> >> ---
> >>  .../shared-mime-info/shared-mime-info.inc          |    4 ++--
> >>  1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> >> index 64eef9d..e206305 100644
> >> --- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> >> +++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> >> @@ -5,8 +5,8 @@ SECTION = "base"
> >>  LICENSE = "GPLv2+"
> >>  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
> >>  
> >> -DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
> >> -DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
> >> +DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
> >> +DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
> >>  
> >>  SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
> > 
> > 
> > There must be some underlying problem here. intltool-native should
> > depend on libxml-parser-perl-native so it should already be built. We
> > need to fix the underlying issue, not the symptom :/
> 
> So intltool.inc:
> 
> DEPENDS = "libxml-parser-perl-native"
> #RDEPENDS_${PN} = "libxml-parser-perl"
> RRECOMMENDS_${PN} = "perl-modules"
> RRECOMMENDS_${PN}_virtclass-native = ""
> 
> Shouldn't this instead look like:
> 
> DEPENDS = "libxml-parser-perl"
> DEPENDS_virtclass-native = "libxml-parser-perl-native"
> 
> Dropping my change above and using this fix instead allows the build to
> complete. Does look like the right fix to you? Shall I send this as a
> patch?

That certainly sounds like the more correct solution, yes.

Cheers,

Richard
Richard Purdie - Sept. 22, 2011, 8:53 p.m.
On Thu, 2011-09-22 at 13:19 -0700, Darren Hart wrote:
> On 09/22/2011 01:03 PM, Saul Wold wrote:
> > On 09/22/2011 12:58 PM, Richard Purdie wrote:
> >> On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
> >>> Fixes [YOCTO #1514]
> >>>
> >>> Building core-image-minimal on qemuppc (and likely others) can fail in
> >>> the shared-mime-info configure step with the following error:
> >>>
> > I was thinking about this and went "why is shared-mime-info even in 
> > core-image-minimal", are you sure that was the image you were building. 
> > This might point to some other problem also.
> 
> Yes, core-image-minimal. It also would fail if I just tried to build
> shared-mime-info-native.

Right, its a native dependency being pulled in by one of the tools, not
the image itself...

Cheers,

Richard

Patch

diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
index 64eef9d..e206305 100644
--- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
+++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
@@ -5,8 +5,8 @@  SECTION = "base"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
-DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
+DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
+DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
 
 SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"