Patchwork [meta-oe,v3,0/2] pull request for twm and xclock recipes

login
register
mail settings
Submitter Imran Mehmood
Date Sept. 22, 2011, 6:31 a.m.
Message ID <cover.1316616945.git.Imran_Mehmood@mentor.com>
Download mbox
Permalink /patch/11963/
State New, archived
Headers show

Pull-request

git://github.com/lawwama/meta-oe master

Comments

Imran Mehmood - Sept. 22, 2011, 6:31 a.m.
From: Imran Mehmood <Imran_Mehmood@mentor.com>

The following changes since commit 94a25d92b4d0e9379caaab127ccac1a94e9e4d28:
  Imran Mehmood (1):
        cramfs: Adds cvs version recipe (initial recipe)

are available in the git repository at:

  git://github.com/lawwama/meta-oe master
  https://github.com/lawwama/meta-oe/tree/master

Imran Mehmood (2):
  xclock: Add version 1.0.5 (initial recipe)
  twm: Add version 1.0.6 (initial recipe)

 meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb    |   16 ++++++++++++++++
 meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb |   10 ++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-graphics/xorg-app/twm_1.0.6.bb
 create mode 100644 meta-oe/recipes-graphics/xorg-app/xclock_1.0.5.bb
Koen Kooi - Sept. 22, 2011, 6:57 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 22-09-11 08:31, Mehmood, Imran schreef:
> From: Imran Mehmood <Imran_Mehmood@mentor.com>
> 
> The following changes since commit
> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: Adds
> cvs version recipe (initial recipe)

That isn't in meta-oe, so I can't pull your git tree. I'll grab the patches
from patchwork for now, but in the future please use a clean tree for pull
requests


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOetxvMkyGM64RGpERAr4DAJ9WbrqTfvlucjBccQm3UYebbaRS0wCeK9Tp
heTJQrpQAIhKyhzR2IF6yww=
=c2iD
-----END PGP SIGNATURE-----
Imran Mehmood - Oct. 3, 2011, 12:48 p.m.
hi koen,

On 09/22/2011 11:57 AM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 22-09-11 08:31, Mehmood, Imran schreef:
>> From: Imran Mehmood<Imran_Mehmood@mentor.com>
>>
>> The following changes since commit
>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: Adds
>> cvs version recipe (initial recipe)
> That isn't in meta-oe, so I can't pull your git tree. I'll grab the patches
> from patchwork for now, but in the future please use a clean tree for pull
> requests
>
>
Sorry for much delayed response I was busy with some other issues. I fixed the warning messages with xclock but before sending the patch again just wanted to clear a confusion regarding your response below.

I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to create-pull-request script with -r because I wanted to create pull request for all commits on my branch, made after this one. If its wrong whats the right way or thing to do? I mean

  what commit id should I pass to the script? Please explain a bit more in detail so that I can prepare next patch as per requirements.

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFOetxvMkyGM64RGpERAr4DAJ9WbrqTfvlucjBccQm3UYebbaRS0wCeK9Tp
> heTJQrpQAIhKyhzR2IF6yww=
> =c2iD
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Thanks and Regards,
Imran Mehmood
Imran Mehmood - Oct. 7, 2011, 2:15 p.m.
hi koen,
     I will be thankful if you can kindly comment.

On 10/03/2011 05:48 PM, Imran Mehmood wrote:
> hi koen,
>
> On 09/22/2011 11:57 AM, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Op 22-09-11 08:31, Mehmood, Imran schreef:
>>> From: Imran Mehmood<Imran_Mehmood@mentor.com>
>>>
>>> The following changes since commit
>>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: 
>>> Adds
>>> cvs version recipe (initial recipe)
>> That isn't in meta-oe, so I can't pull your git tree. I'll grab the 
>> patches
>> from patchwork for now, but in the future please use a clean tree for 
>> pull
>> requests
>>
>>
> Sorry for much delayed response I was busy with some other issues. I 
> fixed the warning messages with xclock but before sending the patch 
> again just wanted to clear a confusion regarding your response below.
>
> I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to 
> create-pull-request script with -r because I wanted to create pull 
> request for all commits on my branch, made after this one. If its 
> wrong whats the right way or thing to do? I mean
>
>  what commit id should I pass to the script? Please explain a bit more 
> in detail so that I can prepare next patch as per requirements.
>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.5 (Darwin)
>>
>> iD8DBQFOetxvMkyGM64RGpERAr4DAJ9WbrqTfvlucjBccQm3UYebbaRS0wCeK9Tp
>> heTJQrpQAIhKyhzR2IF6yww=
>> =c2iD
>> -----END PGP SIGNATURE-----
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
> Thanks and Regards,
> Imran Mehmood
>
Thanks and Regards,
Imran Mehmood
Koen Kooi - Oct. 7, 2011, 2:28 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 07-10-11 16:15, Imran Mehmood schreef:
> hi koen, I will be thankful if you can kindly comment.

Please submit a new pull request, based on meta-oe with all the pending
mentor patches

> 
> On 10/03/2011 05:48 PM, Imran Mehmood wrote:
>> hi koen,
>> 
>> On 09/22/2011 11:57 AM, Koen Kooi wrote:
> Op 22-09-11 08:31, Mehmood, Imran schreef:
>>>>> From: Imran Mehmood<Imran_Mehmood@mentor.com>
>>>>> 
>>>>> The following changes since commit 
>>>>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1):
>>>>> cramfs: Adds cvs version recipe (initial recipe)
> That isn't in meta-oe, so I can't pull your git tree. I'll grab the
> patches from patchwork for now, but in the future please use a clean tree
> for pull requests
> 
> 
>>> Sorry for much delayed response I was busy with some other issues. I
>>> fixed the warning messages with xclock but before sending the patch
>>> again just wanted to clear a confusion regarding your response
>>> below.
>>> 
>>> I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to
>>> create-pull-request script with -r because I wanted to create pull
>>> request for all commits on my branch, made after this one. If its
>>> wrong whats the right way or thing to do? I mean
>>> 
>>> what commit id should I pass to the script? Please explain a bit more
>>> in detail so that I can prepare next patch as per requirements.
>>> 
>>> 
>>> 
>>> _______________________________________________ Openembedded-devel
>>> mailing list Openembedded-devel@lists.openembedded.org 
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>>
>>
>>> 
Thanks and Regards,
>> Imran Mehmood
>> 
> Thanks and Regards, Imran Mehmood

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOjwyEMkyGM64RGpERAo3SAJ0aha3/uqMgThPCNXGrQg0LKhrjMgCeOyKu
ygNNpWq6Uc2WOn/yf03POok=
=+t4w
-----END PGP SIGNATURE-----
Anders Darander - Oct. 7, 2011, 2:30 p.m.
* Imran Mehmood <imran_mehmood@mentor.com> [111007 16:15]:
> On 10/03/2011 05:48 PM, Imran Mehmood wrote:
> > hi koen,

> > On 09/22/2011 11:57 AM, Koen Kooi wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1

> >> Op 22-09-11 08:31, Mehmood, Imran schreef:
> >>> From: Imran Mehmood<Imran_Mehmood@mentor.com>

> >>> The following changes since commit
> >>> 94a25d92b4d0e9379caaab127ccac1a94e9e4d28: Imran Mehmood (1): cramfs: 
> >>> Adds
> >>> cvs version recipe (initial recipe)
> >> That isn't in meta-oe, so I can't pull your git tree. I'll grab the 
> >> patches
> >> from patchwork for now, but in the future please use a clean tree for 
> >> pull
> >> requests

> > Sorry for much delayed response I was busy with some other issues. I 
> > fixed the warning messages with xclock but before sending the patch 
> > again just wanted to clear a confusion regarding your response below.

> > I passed 94a25d92b4d0e9379caaab127ccac1a94e9e4d28 to 
> > create-pull-request script with -r because I wanted to create pull 
> > request for all commits on my branch, made after this one. If its 
> > wrong whats the right way or thing to do? I mean

In order to make it easy for everyone to pull from your git tree, the
pull request should be based on a commit that is in the upstream git
tree.

In other words, the error/problem with your pull request was that you
had created a branch, then commit X-number of patches to that branch.
However, you only used the latest Y-patches (with Y being less than X)
in your pull-request.

A better approach would have been to create a new branch, cherry-pick
the Y-patches that you wanted to upstream into this new branch. And
finally, create a pull request for this new branch.

Cheers,
Anders

> >  what commit id should I pass to the script? Please explain a bit more 
> > in detail so that I can prepare next patch as per requirements.