Patchwork [v2] gupnp_0.13.4/gupnp-av_0.5.9: disable introspection

login
register
mail settings
Submitter Steffen Sledz
Date March 7, 2011, 4:43 p.m.
Message ID <1299516187-27151-1-git-send-email-sledz@dresearch.de>
Download mbox | patch
Permalink /patch/1193/
State Superseded
Headers show

Comments

Steffen Sledz - March 7, 2011, 4:43 p.m.
Introspection uses host tools within compile stage. Missing tools or
tools of wrong version result in errors like

|   GEN    GUPnP-1.0.gir
| Couldn't find include 'Soup-2.4.gir' (search path: ...)

or

|   GEN    GUPnP-1.0.gir
| /usr/share/gir-1.0/Soup-2.4.gir: Incompatible version 1.0 (supported: 1.2)

Signed-off-by: Steffen Sledz <sledz@dresearch.de>
---
 recipes/upnp/gupnp-av_0.5.9.bb |    3 +++
 recipes/upnp/gupnp_0.13.4.bb   |    3 ++-
 2 files changed, 5 insertions(+), 1 deletions(-)
Phil Blundell - March 7, 2011, 4:57 p.m.
On Mon, 2011-03-07 at 17:43 +0100, Steffen Sledz wrote:
> --- a/recipes/upnp/gupnp_0.13.4.bb
> +++ b/recipes/upnp/gupnp_0.13.4.bb
> @@ -2,13 +2,14 @@ LICENSE = "LGPL"
>  DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gtk-doc-native libgee"
>  
>  require gupnp.inc
> +PR = "1"
>  
>  SRC_URI[md5sum] = "0d562f5f02534c70c3743b2c514db8ba"
>  SRC_URI[sha256sum] = "7974953f38a41236c875c3df509abc43e8218b5925fdc18212a73b1ae0d0e7e8"
>  
>  inherit autotools pkgconfig
>  
> -EXTRA_OECONF = "--disable-gtk-doc"
> +EXTRA_OECONF = "--disable-gtk-doc --enable-introspection=no"

I can't help thinking that there must be a better place to put this,
maybe even autotools.bbclass.  We basically want those options for all
packages that will take them, right?

p.
Tom Rini - March 7, 2011, 5:59 p.m.
On 03/07/2011 09:57 AM, Phil Blundell wrote:
> On Mon, 2011-03-07 at 17:43 +0100, Steffen Sledz wrote:
>> --- a/recipes/upnp/gupnp_0.13.4.bb
>> +++ b/recipes/upnp/gupnp_0.13.4.bb
>> @@ -2,13 +2,14 @@ LICENSE = "LGPL"
>>   DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gtk-doc-native libgee"
>>
>>   require gupnp.inc
>> +PR = "1"

"r1"

>>
>>   SRC_URI[md5sum] = "0d562f5f02534c70c3743b2c514db8ba"
>>   SRC_URI[sha256sum] = "7974953f38a41236c875c3df509abc43e8218b5925fdc18212a73b1ae0d0e7e8"
>>
>>   inherit autotools pkgconfig
>>
>> -EXTRA_OECONF = "--disable-gtk-doc"
>> +EXTRA_OECONF = "--disable-gtk-doc --enable-introspection=no"
>
> I can't help thinking that there must be a better place to put this,
> maybe even autotools.bbclass.  We basically want those options for all
> packages that will take them, right?

Usually this is just in "gnome" stuff and gnome or gnomebase does handle 
this.  But indeed, perhaps this is something that should be more widely 
passed in to avoid semi-random breakage.
Koen Kooi - March 8, 2011, 12:12 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08-03-11 12:49, Steffen Sledz wrote:
> Am 07.03.2011 18:59, schrieb Tom Rini:
>> On 03/07/2011 09:57 AM, Phil Blundell wrote:
>>> On Mon, 2011-03-07 at 17:43 +0100, Steffen Sledz wrote:
>>>> --- a/recipes/upnp/gupnp_0.13.4.bb
>>>> +++ b/recipes/upnp/gupnp_0.13.4.bb
>>>> @@ -2,13 +2,14 @@ LICENSE = "LGPL"
>>>>   DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gtk-doc-native libgee"
>>>>
>>>>   require gupnp.inc
>>>> +PR = "1"
>>
>> "r1"
>>
>>>>
>>>>   SRC_URI[md5sum] = "0d562f5f02534c70c3743b2c514db8ba"
>>>>   SRC_URI[sha256sum] = "7974953f38a41236c875c3df509abc43e8218b5925fdc18212a73b1ae0d0e7e8"
>>>>
>>>>   inherit autotools pkgconfig
>>>>
>>>> -EXTRA_OECONF = "--disable-gtk-doc"
>>>> +EXTRA_OECONF = "--disable-gtk-doc --enable-introspection=no"
>>>
>>> I can't help thinking that there must be a better place to put this,
>>> maybe even autotools.bbclass.  We basically want those options for all
>>> packages that will take them, right?
>>
>> Usually this is just in "gnome" stuff and gnome or gnomebase does handle this.  But indeed, perhaps this is something that should be more widely passed in to avoid semi-random breakage.
> 
> Can i get some acks for my patch at least as an interim solution? Currently the build is broken! This really is a blocker. :(

NAK, fix the PRs first
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNdh0YMkyGM64RGpERArXvAJ4yt7VoI/RK4hA6cvmx5ReKJY9HdgCfTcEv
iTy/5tw2fyZNUrND8EU0U8Y=
=JAUx
-----END PGP SIGNATURE-----

Patch

diff --git a/recipes/upnp/gupnp-av_0.5.9.bb b/recipes/upnp/gupnp-av_0.5.9.bb
index 0370e91..4360cc1 100644
--- a/recipes/upnp/gupnp-av_0.5.9.bb
+++ b/recipes/upnp/gupnp-av_0.5.9.bb
@@ -2,8 +2,11 @@  LICENSE = "LGPL"
 DEPENDS = "gupnp"
 
 require gupnp.inc
+PR = "1"
 
 SRC_URI[md5sum] = "5940df3c1152894685c3fc38ee95fd78"
 SRC_URI[sha256sum] = "a909129997f79dcb6d35221ce205854d64c47a7390843e420cfba753485087bd"
 
 inherit autotools pkgconfig
+
+EXTRA_OECONF = "--enable-introspection=no"
diff --git a/recipes/upnp/gupnp_0.13.4.bb b/recipes/upnp/gupnp_0.13.4.bb
index 07266a1..4327662 100644
--- a/recipes/upnp/gupnp_0.13.4.bb
+++ b/recipes/upnp/gupnp_0.13.4.bb
@@ -2,13 +2,14 @@  LICENSE = "LGPL"
 DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gtk-doc-native libgee"
 
 require gupnp.inc
+PR = "1"
 
 SRC_URI[md5sum] = "0d562f5f02534c70c3743b2c514db8ba"
 SRC_URI[sha256sum] = "7974953f38a41236c875c3df509abc43e8218b5925fdc18212a73b1ae0d0e7e8"
 
 inherit autotools pkgconfig
 
-EXTRA_OECONF = "--disable-gtk-doc"
+EXTRA_OECONF = "--disable-gtk-doc --enable-introspection=no"
 
 do_configure() {
 	libtoolize --force