Patchwork [09/17] dbus-glib: disable bash-completion

login
register
mail settings
Submitter lumag
Date Sept. 21, 2011, 6:39 p.m.
Message ID <1316630404-10336-9-git-send-email-dbaryshkov@gmail.com>
Download mbox | patch
Permalink /patch/11895/
State New, archived
Headers show

Comments

lumag - Sept. 21, 2011, 6:39 p.m.
Bash completion stuff isn't packaged and used. Stop building it by
passing --disable-bash-completion to configure

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 meta/recipes-core/dbus/dbus-glib.inc     |    3 ++-
 meta/recipes-core/dbus/dbus-glib_0.92.bb |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
Koen Kooi - Sept. 21, 2011, 7:19 p.m.
Op 21 sep. 2011, om 20:39 heeft Dmitry Eremin-Solenikov het volgende geschreven:

> Bash completion stuff isn't packaged and used. Stop building it by
> passing --disable-bash-completion to configure

A better idea would be to package it
lumag - Sept. 21, 2011, 7:57 p.m.
On 9/21/11, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Op 21 sep. 2011, om 20:39 heeft Dmitry Eremin-Solenikov het volgende
> geschreven:
>
>> Bash completion stuff isn't packaged and used. Stop building it by
>> passing --disable-bash-completion to configure
>
> A better idea would be to package it

Then we need bash-completion. Would you like it in meta-oe/recipes-extended?
meta-oe/recipes-support? meta-oe/recipes-whatever?
Koen Kooi - Sept. 21, 2011, 8 p.m.
Op 21 sep. 2011, om 21:57 heeft Dmitry Eremin-Solenikov het volgende geschreven:

> On 9/21/11, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> 
>> Op 21 sep. 2011, om 20:39 heeft Dmitry Eremin-Solenikov het volgende
>> geschreven:
>> 
>>> Bash completion stuff isn't packaged and used. Stop building it by
>>> passing --disable-bash-completion to configure
>> 
>> A better idea would be to package it
> 
> Then we need bash-completion. Would you like it in meta-oe/recipes-extended?
> meta-oe/recipes-support? meta-oe/recipes-whatever?

Bash itself is in oe-core, so let's keep it in oe-core.

Patch

diff --git a/meta/recipes-core/dbus/dbus-glib.inc b/meta/recipes-core/dbus/dbus-glib.inc
index 704dc04..959fa64 100644
--- a/meta/recipes-core/dbus/dbus-glib.inc
+++ b/meta/recipes-core/dbus/dbus-glib.inc
@@ -16,7 +16,8 @@  SRC_URI = "http://dbus.freedesktop.org/releases/dbus-glib/dbus-glib-${PV}.tar.gz
 inherit autotools pkgconfig gettext
 
 EXTRA_OECONF = "--with-introspect-xml=${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml \
-                --with-dbus-binding-tool=${STAGING_BINDIR_NATIVE}/dbus-binding-tool"
+                --with-dbus-binding-tool=${STAGING_BINDIR_NATIVE}/dbus-binding-tool \
+                --disable-bash-completion"
 EXTRA_OECONF_virtclass-native = "--with-introspect-xml=${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml"
 
 FILES_${PN} = "${libdir}/lib*.so.*"
diff --git a/meta/recipes-core/dbus/dbus-glib_0.92.bb b/meta/recipes-core/dbus/dbus-glib_0.92.bb
index 72bea89..c7266d4 100644
--- a/meta/recipes-core/dbus/dbus-glib_0.92.bb
+++ b/meta/recipes-core/dbus/dbus-glib_0.92.bb
@@ -1,6 +1,6 @@ 
 require dbus-glib.inc
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI[md5sum] = "b595b36890c4f9f8f5d5dec131c495f8"
 SRC_URI[sha256sum] = "5a7fd4cf937cdcb7f2eed61341b70ee0f2607450a50db381618598adf60dd40e"