Patchwork [v3] libroxml: Add version 2.1.1

login
register
mail settings
Submitter blunderer
Date Sept. 21, 2011, 12:40 p.m.
Message ID <1316608829-30502-1-git-send-email-tristan.lelong@blunderer.org>
Download mbox | patch
Permalink /patch/11879/
State Superseded, archived
Headers show

Comments

blunderer - Sept. 21, 2011, 12:40 p.m.
libroxml is a small fast and powerful xml library
build successfully using org.openembedded.dev with DISTRO=minimal and MACHINE = "i686-generic"
build successfully using org.openembedded.dev with DISTRO=minimal and MACHINE = "ppce500v2"
tested using projects unit tests on powerpc binaries

Signed-off-by: Tristan Lelong <tristan.lelong@blunderer.org>
---
 recipes/libroxml/libroxml.inc      |   21 +++++++++++++++++++++
 recipes/libroxml/libroxml_2.1.1.bb |    5 +++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 recipes/libroxml/libroxml.inc
 create mode 100644 recipes/libroxml/libroxml_2.1.1.bb
Paul Menzel - Sept. 21, 2011, 2:40 p.m.
Dear Tristan,


thank you for your patience.

Am Mittwoch, den 21.09.2011, 14:40 +0200 schrieb Tristan Lelong:
> libroxml is a small fast and powerful xml library
> build successfully using org.openembedded.dev with DISTRO=minimal and MACHINE = "i686-generic"
> build successfully using org.openembedded.dev with DISTRO=minimal and MACHINE = "ppce500v2"
> tested using projects unit tests on powerpc binaries
> 
> Signed-off-by: Tristan Lelong <tristan.lelong@blunderer.org>
> ---
>  recipes/libroxml/libroxml.inc      |   21 +++++++++++++++++++++
>  recipes/libroxml/libroxml_2.1.1.bb |    5 +++++
>  2 files changed, 26 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/libroxml/libroxml.inc
>  create mode 100644 recipes/libroxml/libroxml_2.1.1.bb
> 
> diff --git a/recipes/libroxml/libroxml.inc b/recipes/libroxml/libroxml.inc
> new file mode 100644
> index 0000000..eed21d1
> --- /dev/null
> +++ b/recipes/libroxml/libroxml.inc
> @@ -0,0 +1,21 @@
> +DESCRIPTION = "Small, fast and powerful xml library"
> +AUTHOR = "Tristan Lelong <tristan.lelong@libroxml.net>"
> +HOMEPAGE = "http://www.libroxml.net"
> +SECTION = "libs"
> +PRIORITY = "optional"
> +LICENSE = "LGPL"

I checked again. This should be `LGPLv2.1+`, I think.

> +INC_PR = "r1"

Please start with `r0` when submitting recipes.

> +
> +SRC_URI = "http://libroxml.googlecode.com/files/${P}.tar.gz"
> +
> +do_install() {
> +	install -D -m 755 ${S}/roxml ${D}/${bindir}/roxml
> +	install -D -m 755 ${S}/libroxml.so.0 ${D}/${libdir}/libroxml.so.0
> +	install -D -m 644 ${S}/inc/roxml.h ${D}/${includedir}/roxml.h
> +	ln -s /usr/lib/libroxml.so.0 ${D}/${libdir}/libroxml.so
> +}
> +
> +PACKAGES = ${PN} ${PN}-dev roxml

Is that intended? Using `=` you override the variable and for example no
debug package is created and the following files are not packaged.

        WARNING: the following files were installed but not shipped in any package:
        WARNING:   /usr/lib/.debug/libroxml.so.0
        WARNING:   /usr/bin/.debug/roxml

> +FILES_${PN} = ${libdir}/libroxml.so.0
> +FILES_${PN}-dev = ${libdir}/libroxml.so ${includedir}/roxml.h
> +FILES_roxml = ${bindir}/roxml

Does

PACKAGES += "roxml"
FILES_roxml = ${bindir}/roxml

work for? I do not know if it is done automatically. Maybe you also have
to add `roxml-dbg` then. I am not sure.

> diff --git a/recipes/libroxml/libroxml_2.1.1.bb b/recipes/libroxml/libroxml_2.1.1.bb
> new file mode 100644
> index 0000000..0852930
> --- /dev/null
> +++ b/recipes/libroxml/libroxml_2.1.1.bb
> @@ -0,0 +1,5 @@
> +require libroxml.inc
> +PR = "${INC_PR}.1"

Please also start with 0.

> +
> +SRC_URI[md5sum] = "dc8342d0490bff5a507dbf1de3426102"
> +SRC_URI[sha256sum] = "e4e91b610614d6cb1204ac9abbb417368fe84654c7de58134b436cfd00f1a244"

Thank you! I guess the next iteration will be ready to be committed.


Thanks,

Paul
blunderer - Sept. 21, 2011, 3:09 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Hi,

I will correct those last problems, test it again, and I'll resbumit the
patch.

Le 21/09/2011 16:40, Paul Menzel a écrit :
> Dear Tristan,
>
>
> thank you for your patience.
it should be me thanking you for your patience


- -- 
618FE3EF
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk55/g8ACgkQFj9oxGGP4+/qrgCguZ6EfFmpZbXTe1QcANI90iro
w2cAnRB31yw+oUFG+uxp3BUxgCz+Q1Wp
=veWg
-----END PGP SIGNATURE-----

Patch

diff --git a/recipes/libroxml/libroxml.inc b/recipes/libroxml/libroxml.inc
new file mode 100644
index 0000000..eed21d1
--- /dev/null
+++ b/recipes/libroxml/libroxml.inc
@@ -0,0 +1,21 @@ 
+DESCRIPTION = "Small, fast and powerful xml library"
+AUTHOR = "Tristan Lelong <tristan.lelong@libroxml.net>"
+HOMEPAGE = "http://www.libroxml.net"
+SECTION = "libs"
+PRIORITY = "optional"
+LICENSE = "LGPL"
+INC_PR = "r1"
+
+SRC_URI = "http://libroxml.googlecode.com/files/${P}.tar.gz"
+
+do_install() {
+	install -D -m 755 ${S}/roxml ${D}/${bindir}/roxml
+	install -D -m 755 ${S}/libroxml.so.0 ${D}/${libdir}/libroxml.so.0
+	install -D -m 644 ${S}/inc/roxml.h ${D}/${includedir}/roxml.h
+	ln -s /usr/lib/libroxml.so.0 ${D}/${libdir}/libroxml.so
+}
+
+PACKAGES = ${PN} ${PN}-dev roxml
+FILES_${PN} = ${libdir}/libroxml.so.0
+FILES_${PN}-dev = ${libdir}/libroxml.so ${includedir}/roxml.h
+FILES_roxml = ${bindir}/roxml
diff --git a/recipes/libroxml/libroxml_2.1.1.bb b/recipes/libroxml/libroxml_2.1.1.bb
new file mode 100644
index 0000000..0852930
--- /dev/null
+++ b/recipes/libroxml/libroxml_2.1.1.bb
@@ -0,0 +1,5 @@ 
+require libroxml.inc
+PR = "${INC_PR}.1"
+
+SRC_URI[md5sum] = "dc8342d0490bff5a507dbf1de3426102"
+SRC_URI[sha256sum] = "e4e91b610614d6cb1204ac9abbb417368fe84654c7de58134b436cfd00f1a244"