Patchwork bitbake wrapper: Make sure grep runs without colorized output

login
register
mail settings
Submitter Koen Kooi
Date Sept. 21, 2011, 10:31 a.m.
Message ID <1316601066-1445-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/11873/
State New, archived
Headers show

Comments

Koen Kooi - Sept. 21, 2011, 10:31 a.m.
From: Tasslehoff Kjappfot <tasskjapp@gmail.com>

My .bashrc contained "export GREP_OPTIONS='--color=always'", and that caused the path in my pseudodone file to  be prefixed by "^[[m^[[K". Override by calling grep with --color=never.

Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 scripts/bitbake |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Phil Blundell - Sept. 21, 2011, 10:34 a.m.
On Wed, 2011-09-21 at 12:31 +0200, Koen Kooi wrote:
> -    PSEUDOBINDIR=`bitbake -e | grep STAGING_BINDIR_NATIVE=\" | cut -d '=' -f2 | cut -d '"' -f2`
> +    PSEUDOBINDIR=`bitbake -e | grep --color=never STAGING_BINDIR_NATIVE=\" | cut -d '=' -f2 | cut -d '"' -f2`
>      ret=$?

That's a GNU extension and won't work on all greps.  How about just
unsetting GREP_OPTIONS, or alternatively replacing that whole pipeline
with awk?

p.

Patch

diff --git a/scripts/bitbake b/scripts/bitbake
index 587428c..9330d71 100755
--- a/scripts/bitbake
+++ b/scripts/bitbake
@@ -65,7 +65,7 @@  if [ $buildpseudo = "1" ]; then
     if [ "$ret" != "0" ]; then
         exit 1
     fi
-    PSEUDOBINDIR=`bitbake -e | grep STAGING_BINDIR_NATIVE=\" | cut -d '=' -f2 | cut -d '"' -f2`
+    PSEUDOBINDIR=`bitbake -e | grep --color=never STAGING_BINDIR_NATIVE=\" | cut -d '=' -f2 | cut -d '"' -f2`
     ret=$?
     if [ "$ret" != "0" ]; then
         exit 1