Patchwork [1/2] gst-plugins: Added hal to DEPENDS

login
register
mail settings
Submitter Saul Wold
Date March 6, 2011, 5:19 p.m.
Message ID <c6b0c5720fa0fc2ba7a6792b7f52faad38dd47dc.1299431945.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/1179/
State New, archived
Headers show

Comments

Saul Wold - March 6, 2011, 5:19 p.m.
From: Saul Wold <sgw@linux.intel.com>

Fixes [YOCTO #810]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-multimedia/gstreamer/gst-plugins.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Koen Kooi - March 6, 2011, 6:34 p.m.
Op 6 mrt 2011, om 18:19 heeft Saul Wold het volgende geschreven:

> From: Saul Wold <sgw@linux.intel.com>
> 
> Fixes [YOCTO #810]
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/recipes-multimedia/gstreamer/gst-plugins.inc |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins.inc b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
> index 4edca95..d1abd36 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-plugins.inc
> +++ b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
> @@ -3,7 +3,7 @@ HOMEPAGE = "http://gstreamer.freedesktop.org/"
> BUGTRACKER = "https://bugzilla.gnome.org/enter_bug.cgi?product=Gstreamer"
> SECTION = "multimedia"
> PRIORITY = "optional"
> -DEPENDS = "gstreamer"
> +DEPENDS = "gstreamer hal"

Since hal is being deprecated in favour of udev, do we really want to introduce it as a dependency instead of disabled it?

regards,

Koen
Tom Rini - March 7, 2011, 12:47 a.m.
On 03/06/2011 11:34 AM, Koen Kooi wrote:
>
> Op 6 mrt 2011, om 18:19 heeft Saul Wold het volgende geschreven:
>
>> From: Saul Wold<sgw@linux.intel.com>
>>
>> Fixes [YOCTO #810]
>>
>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>> ---
>> meta/recipes-multimedia/gstreamer/gst-plugins.inc |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins.inc b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
>> index 4edca95..d1abd36 100644
>> --- a/meta/recipes-multimedia/gstreamer/gst-plugins.inc
>> +++ b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
>> @@ -3,7 +3,7 @@ HOMEPAGE = "http://gstreamer.freedesktop.org/"
>> BUGTRACKER = "https://bugzilla.gnome.org/enter_bug.cgi?product=Gstreamer"
>> SECTION = "multimedia"
>> PRIORITY = "optional"
>> -DEPENDS = "gstreamer"
>> +DEPENDS = "gstreamer hal"
>
> Since hal is being deprecated in favour of udev, do we really want to introduce it as a dependency instead of disabled it?

... and making sure the new set of magic works right.
Richard Purdie - March 8, 2011, 6:42 p.m.
On Sun, 2011-03-06 at 17:47 -0700, Tom Rini wrote:
> On 03/06/2011 11:34 AM, Koen Kooi wrote:
> >
> > Op 6 mrt 2011, om 18:19 heeft Saul Wold het volgende geschreven:
> >
> >> From: Saul Wold<sgw@linux.intel.com>
> >>
> >> Fixes [YOCTO #810]
> >>
> >> Signed-off-by: Saul Wold<sgw@linux.intel.com>
> >> ---
> >> meta/recipes-multimedia/gstreamer/gst-plugins.inc |    2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins.inc b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
> >> index 4edca95..d1abd36 100644
> >> --- a/meta/recipes-multimedia/gstreamer/gst-plugins.inc
> >> +++ b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
> >> @@ -3,7 +3,7 @@ HOMEPAGE = "http://gstreamer.freedesktop.org/"
> >> BUGTRACKER = "https://bugzilla.gnome.org/enter_bug.cgi?product=Gstreamer"
> >> SECTION = "multimedia"
> >> PRIORITY = "optional"
> >> -DEPENDS = "gstreamer"
> >> +DEPENDS = "gstreamer hal"
> >
> > Since hal is being deprecated in favour of udev, do we really want to introduce it as a dependency instead of disabled it?
> 
> ... and making sure the new set of magic works right.

I'm going to merge Saul's patch. I'd take a patch to remove the
dependency if someone can write one and confirm it works though.

Cheers,

Richard

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins.inc b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
index 4edca95..d1abd36 100644
--- a/meta/recipes-multimedia/gstreamer/gst-plugins.inc
+++ b/meta/recipes-multimedia/gstreamer/gst-plugins.inc
@@ -3,7 +3,7 @@  HOMEPAGE = "http://gstreamer.freedesktop.org/"
 BUGTRACKER = "https://bugzilla.gnome.org/enter_bug.cgi?product=Gstreamer"
 SECTION = "multimedia"
 PRIORITY = "optional"
-DEPENDS = "gstreamer"
+DEPENDS = "gstreamer hal"
 
 inherit autotools pkgconfig