Patchwork [5/5] kernel.bbclass: remove unshipped files in do_install

login
register
mail settings
Submitter lumag
Date Sept. 17, 2011, 10:18 p.m.
Message ID <1316297897-698-5-git-send-email-dbaryshkov@gmail.com>
Download mbox | patch
Permalink /patch/11623/
State New, archived
Headers show

Comments

lumag - Sept. 17, 2011, 10:18 p.m.
Drop two unsed files (modules.order and modules.builtin) in do_install
to stop the "unshipped files" warning.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 meta/classes/kernel.bbclass |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Bruce Ashfield - Sept. 27, 2011, 1:41 p.m.
On Sat, Sep 17, 2011 at 6:18 PM, Dmitry Eremin-Solenikov
<dbaryshkov@gmail.com> wrote:
> Drop two unsed files (modules.order and modules.builtin) in do_install
> to stop the "unshipped files" warning.

One less warning is a good thing!

Looks good to me,  I can add my vote to this one.

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  meta/classes/kernel.bbclass |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 59d3b89..6b2e603 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -108,6 +108,8 @@ kernel_do_install() {
>        unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
>        if (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
>                oe_runmake DEPMOD=echo INSTALL_MOD_PATH="${D}" modules_install
> +               rm -f "${D}/lib/modules/${KERNEL_VERSION}/modules.order"
> +               rm -f "${D}/lib/modules/${KERNEL_VERSION}/modules.builtin"
>        else
>                bbnote "no modules to install"
>        fi
> --
> 1.7.2.5
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - Sept. 28, 2011, 2:50 p.m.
On Sun, 2011-09-18 at 02:18 +0400, Dmitry Eremin-Solenikov wrote:
> Drop two unsed files (modules.order and modules.builtin) in do_install
> to stop the "unshipped files" warning.
> 
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  meta/classes/kernel.bbclass |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 59d3b89..6b2e603 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -108,6 +108,8 @@ kernel_do_install() {
>  	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
>  	if (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
>  		oe_runmake DEPMOD=echo INSTALL_MOD_PATH="${D}" modules_install
> +		rm -f "${D}/lib/modules/${KERNEL_VERSION}/modules.order"
> +		rm -f "${D}/lib/modules/${KERNEL_VERSION}/modules.builtin"
>  	else
>  		bbnote "no modules to install"
>  	fi

Merged to master, thanks.

Richard

Patch

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 59d3b89..6b2e603 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -108,6 +108,8 @@  kernel_do_install() {
 	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
 	if (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
 		oe_runmake DEPMOD=echo INSTALL_MOD_PATH="${D}" modules_install
+		rm -f "${D}/lib/modules/${KERNEL_VERSION}/modules.order"
+		rm -f "${D}/lib/modules/${KERNEL_VERSION}/modules.builtin"
 	else
 		bbnote "no modules to install"
 	fi