Patchwork [2/2] qt4(embedded and x11): disable neon for armv6-vfp

login
register
mail settings
Submitter Denis Carikli
Date Sept. 15, 2011, 9:26 a.m.
Message ID <1316078776-19890-3-git-send-email-denis@eukrea.com>
Download mbox | patch
Permalink /patch/11461/
State New, archived
Headers show

Comments

Denis Carikli - Sept. 15, 2011, 9:26 a.m.
without the -no-neon flag, neon is "autodetected"
  by looking if the compiler is capable of compiling
  a neon test, and succeed, and neon is then enabled
  during the compilation.

Signed-off-by: Denis Carikli <denis@eukrea.com>
---
 meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb |    3 ++-
 meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
Marc Reilly - Sept. 16, 2011, 1:31 a.m.
On Thursday, September 15, 2011 07:26:16 PM Denis Carikli wrote:
> without the -no-neon flag, neon is "autodetected"
>   by looking if the compiler is capable of compiling
>   a neon test, and succeed, and neon is then enabled
>   during the compilation.
> 
> Signed-off-by: Denis Carikli <denis@eukrea.com>


>  QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
> +QT_CONFIG_FLAGS_append_armv6-vfp = " -no-neon "

I also ran into this problem, with the same fix.


There are a couple of other places with armv6 overrides that could misbehave, 
notably:
TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__"
(python_2.6.6.bb)
QEMU_OPTIONS_armv6   = "-cpu arm1136"
(bitbake.conf)

Is there a way to do this more generically?, something like:
QT_CONFIG_FLAGS_append_armv6* = " ... "

Cheers
Marc

Patch

diff --git a/meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb b/meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb
index c3f6713..61c679e 100644
--- a/meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb
+++ b/meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb
@@ -1,9 +1,10 @@ 
 require qt-${PV}.inc
 require qt4-embedded.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
+QT_CONFIG_FLAGS_append_armv6-vfp = " -no-neon "
 
 QT_CONFIG_FLAGS += " \
  -exceptions \
diff --git a/meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb b/meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb
index 75c6314..6c8db17 100644
--- a/meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb
+++ b/meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb
@@ -1,9 +1,10 @@ 
 require qt4-x11-free.inc
 require qt-${PV}.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
+QT_CONFIG_FLAGS_append_armv6-vfp = " -no-neon "
 
 QT_CONFIG_FLAGS += " \
  -no-embedded \