| Submitter | Eric BENARD |
|---|---|
| Date | Sept. 7, 2011, 1:17 p.m. |
| Message ID | <1315401430-27997-1-git-send-email-eric@eukrea.com> |
| Download | mbox | patch |
| Permalink | /patch/11155/ |
| State | New, archived |
| Headers | show |
Comments
On Wednesday 07 September 2011 14:17:10 Eric Bénard wrote: > use ${POKY_BASE_INSTALL} in order to have the base files and > ools in the image. > >.. > > IMAGE_INSTALL += "\ > - busybox \ > + ${POKY_BASE_INSTALL} \ > module-init-tools \ > task-qt4e-base \ > " Hmm, I missed this when the original patches came in; surely it would be better to just append to IMAGE_INSTALL after the "inherit core-image" line, then we start with the default value from core-image.bbclass? (Of course with either fix we'll run into the build annoyance pointed out in the other message I just sent, where a whole bunch of X apps we won't need will get built.) Cheers, Paul
Le 07/09/2011 15:23, Paul Eggleton a écrit : > On Wednesday 07 September 2011 14:17:10 Eric Bénard wrote: >> use ${POKY_BASE_INSTALL} in order to have the base files and >> ools in the image. >> >> .. >> >> IMAGE_INSTALL += "\ >> - busybox \ >> + ${POKY_BASE_INSTALL} \ >> module-init-tools \ >> task-qt4e-base \ >> " > > Hmm, I missed this when the original patches came in; surely it would be > better to just append to IMAGE_INSTALL after the "inherit core-image" line, > then we start with the default value from core-image.bbclass? > ok I was not sure this would work this way, I'll test and send a v2. Thanks, Eric
Patch
diff --git a/meta/recipes-qt/images/qt4e-demo-image.bb b/meta/recipes-qt/images/qt4e-demo-image.bb index 6a7c086..6523379 100644 --- a/meta/recipes-qt/images/qt4e-demo-image.bb +++ b/meta/recipes-qt/images/qt4e-demo-image.bb @@ -11,7 +11,7 @@ RDEPENDS_${PN} += " \ " IMAGE_INSTALL += "\ - busybox \ + ${POKY_BASE_INSTALL} \ module-init-tools \ task-qt4e-base \ "
use ${POKY_BASE_INSTALL} in order to have the base files and ools in the image. Signed-off-by: Eric Bénard <eric@eukrea.com> --- meta/recipes-qt/images/qt4e-demo-image.bb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)