Patchwork [0/1] Fix MakeMaker's finding of perl.real

login
register
mail settings
Submitter Saul Wold
Date Sept. 7, 2011, 5:09 a.m.
Message ID <cover.1315371835.git.sgw@linux.intel.com>
Download mbox
Permalink /patch/11125/
State New, archived
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib sgw/fix2

Comments

Saul Wold - Sept. 7, 2011, 5:09 a.m.
When configuring cpan packages, the directories passed to MakeMaker
are the target directories. There was a patch that was applied to the
native perl to find perl.real and convert that to perl.  This does not
apply for the target perl modules and therefore MakeMaker find perl.real.

This patch to cpan configure modifies the Makefile after configure and 
changes the perl.real to just straight perl so we have the correct paths
and shared state info in usable.

Sau!

The following changes since commit 41b7c955cfdc7b4d5c667c8a8742237d5edaca4f:

  icu-3.6: fix building with big make -j (2011-09-05 20:38:50 +0100)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib sgw/fix2
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/fix2

Saul Wold (1):
  cpan.bbclass: fix native perl issue

 meta/classes/cpan.bbclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Eric BENARD - Sept. 7, 2011, 6:38 a.m.
Hi,

Le 07/09/2011 07:09, Saul Wold a écrit :
> When configuring cpan packages, the directories passed to MakeMaker are the
> target directories. There was a patch that was applied to the native perl
> to find perl.real and convert that to perl.  This does not apply for the
> target perl modules and therefore MakeMaker find perl.real.
>
> This patch to cpan configure modifies the Makefile after configure and
> changes the perl.real to just straight perl so we have the correct paths
> and shared state info in usable.
>
when sending 1 patch, is it possible to not use cover letter in order to have
the explanation in the patch commit ?
That's easier to understand what the patch is doing when browsing log.

Eric
Anders Darander - Sept. 7, 2011, 9:07 a.m.
* Eric Bénard <eric@eukrea.com> [110907 08:41]:
> Le 07/09/2011 07:09, Saul Wold a écrit :
> > When configuring cpan packages, the directories passed to MakeMaker are the
> > target directories. There was a patch that was applied to the native perl
> > to find perl.real and convert that to perl.  This does not apply for the
> > target perl modules and therefore MakeMaker find perl.real.
> >
> > This patch to cpan configure modifies the Makefile after configure and
> > changes the perl.real to just straight perl so we have the correct paths
> > and shared state info in usable.
> >
> when sending 1 patch, is it possible to not use cover letter in order to have
> the explanation in the patch commit ?
> That's easier to understand what the patch is doing when browsing log.

Cover letter or not, the patch should include a commit message that
explains the patch. It doesn't really matter if there is only one patch
or a large patch series.

For a single patch, the cover letter can be usefull to provide some
extra information and discussion. In other cases, it can be pretty
useless IMHO.

Regards,
Anders
Richard Purdie - Sept. 7, 2011, 10:42 p.m.
On Wed, 2011-09-07 at 11:07 +0200, Anders Darander wrote:
> * Eric Bénard <eric@eukrea.com> [110907 08:41]:
> > Le 07/09/2011 07:09, Saul Wold a écrit :
> > > When configuring cpan packages, the directories passed to MakeMaker are the
> > > target directories. There was a patch that was applied to the native perl
> > > to find perl.real and convert that to perl.  This does not apply for the
> > > target perl modules and therefore MakeMaker find perl.real.
> > >
> > > This patch to cpan configure modifies the Makefile after configure and
> > > changes the perl.real to just straight perl so we have the correct paths
> > > and shared state info in usable.
> > >
> > when sending 1 patch, is it possible to not use cover letter in order to have
> > the explanation in the patch commit ?
> > That's easier to understand what the patch is doing when browsing log.
> 
> Cover letter or not, the patch should include a commit message that
> explains the patch. It doesn't really matter if there is only one patch
> or a large patch series.
> 
> For a single patch, the cover letter can be usefull to provide some
> extra information and discussion. In other cases, it can be pretty
> useless IMHO.

This commit has slipped into the tree this time but I agree in future
more explanation of a commit is needed...

Cheers,

Richard